Commit graph

5880 commits

Author SHA1 Message Date
rhymes
80f648c837
Filter only ordinary tables in estimated count (#8913)
* Revert "[deploy] Use max_by instead to get the highest value (#8890)"

This reverts commit b0fb0a484d.

* Only count actual ordinary tables
2020-06-25 14:04:13 -04:00
Alex
db4e37781f
[deploy] User subscriptions liquid tag MVP (#8871)
* UX (view, style, JS) progress

* base_data updates

* More JS updates

* Remove unnecessary param of author_id

* Remove author_id from controller

* Restrict email to admins

* Introduce profile images

* Remove base_data and update tag for source

* Use .key?

* I gotchu Codeclimate, don't worry :)

* Add click event listeners to modal buttons

* Refactor

* More refactor

* Refactor subscriber

* Use userData() for subscriber

* Reorganize

* Code cleanup

* Add subscription API call and favor textContent

* Fix API call and showSubscribed

* Add Apple Auth logic and change links to buttons

* Update success message

* Add Apple email check and spec

* Fix default sign in state

* Remove email from async_info :(

* Refactor markdown classes

* Single quote consistency

* Modal bug attempt & subscriber image on success

* Refactor passing source to tags and fix preview
2020-06-25 13:13:19 -04:00
ludwiczakpawel
c9c88c7cc1
[deploy] Dashboard updates (#8879)
* flare tag line height

* .

* .

* .

* .

* specs

* spec

* .

* init

* .

* .

* js refactor

* js

* update spec

* Fix infinite scroll

* typo

* move IF

* pro analytics link fix

* Clean up tests

* Refactor adding of html

Co-authored-by: benhalpern <bendhalpern@gmail.com>
2020-06-25 13:10:17 -04:00
Mac Siri
d7d0c49169
[deploy] Move @honebeybadger-io/webpack out of devDependencies (#8909) 2020-06-25 10:02:23 -04:00
Nick Taylor
5bdbc0480d
Some frontend testing cleanup. (#8902) 2020-06-25 09:07:34 -04:00
Ben Halpern
32ad7aa6d4
[deploy] Avoid running service workers on ios (#8889) 2020-06-25 08:55:38 -04:00
ludwiczakpawel
dbe6f81b43
Actions bar fix on Article view (#8903)
* flare tag line height

* .

* dropdown fix + actions bar fix

* actions bar on mob

* revert
2020-06-25 13:02:38 +02:00
Nick Taylor
ab4753079c
Enabled canned import rules as well as import order rule (fixable via --fix). (#8880) 2020-06-25 10:30:40 +02:00
Mac Siri
967f00793a
Add @honeybadger-io/webpack for source-map upload (#8899) 2020-06-24 20:42:28 -04:00
Molly Struve
e688063bba
Bug Fix: Make FieldTestWorker More Resilient (#8893) 2020-06-24 16:34:55 -04:00
Vaidehi Joshi
26d2d9e43e
Track an event's target when clicking on a welcome notification (#8894) [deploy] 2020-06-24 13:02:37 -07:00
Molly Struve
9fb2a7c6b2
[deploy] Remove Vault ENV variables from Envfile so they arent Required in Prod (#8895) 2020-06-24 15:02:16 -05:00
Molly Struve
0767c34379
[deploy] Feature: Setup Vault and AppSecrets Wrapper Class (#8891) 2020-06-24 14:13:37 -05:00
Nick Taylor
09bb730f9d
Added a11y tests to frontend tests that were missing them (#8873) 2020-06-24 14:38:39 -04:00
Andy Zhao
b0fb0a484d
[deploy] Use max_by instead to get the highest value (#8890) 2020-06-24 14:27:42 -04:00
Ben Halpern
cfa5e882ce
[deploy] Add SiteConfig for feed style (#8721)
* Add SiteConfig for feed style

* Merge master

* Merge master

* Fix typo
2020-06-24 12:14:33 -04:00
Michael Kohl
e25936ff57
Fix RSS import (#8877)
* FIx RSS import part 1

* Add spec for medium.com/feed/@dvirsegal

Co-authored-by: rhymes <rhymesete@gmail.com>
2020-06-24 10:51:07 -04:00
Ben Halpern
26d54e72cf
[deploy] Small mod fixes (#8885) 2020-06-24 10:45:11 -04:00
Molly Struve
757e611f6d
Spec Fix: Use Truncation For Tests Where Transactions Get Stuck (#8865) 2020-06-24 09:23:52 -05:00
Ben Halpern
dda6422e22
[deploy] Use fragment for linking to comments for SEO (#8882) 2020-06-24 10:09:41 -04:00
Vaidehi Joshi
65341d9c6e
Disable ahoy.js visit tracking on server-side (#8872) 2020-06-24 09:53:47 -04:00
Ben Halpern
28e428b21e
[deploy] Only clear negative reactions when using thumbsup (#8874)
* Only clear negative reactions when using thumbsup

* Fix specs
2020-06-24 09:23:18 -04:00
rhymes
9cdd03f0dc
Fix typo in dashboard sort element (#8875) 2020-06-24 08:03:27 -04:00
Jacob Herrington
c2af5d8f59
Fix accessiblity warnings on Listings page (#8841)
This should fix ~60 axe warnings on this page. This commit also removes
some markup that is being overwritten by Preact.
2020-06-24 13:28:03 +02:00
A.D. Faris
7536ad293f
Change the moderate language to reflect mod panel language (#8870) 2020-06-24 09:42:51 +02:00
Ben Halpern
2219366af6
[deploy] Paginate /dashboard posts (#8868)
* Paginate /dashboard

* Fix awkward pagination
2020-06-23 17:29:24 -04:00
Molly Struve
33b68d4b39
Flaky Spec/Bug Fix:Dont Send Mod Notification if No Commentable (#8869) 2020-06-23 17:22:34 -04:00
Vaidehi Joshi
fabef71fb7
[deploy] Disable ahoy.js cookie tracking (#8866) 2020-06-23 17:16:15 -04:00
Molly Struve
e3e3e2c386
[deploy] Bug Fix: Return An Empty Array if Error Occurs in RSS Reader (#8864) 2020-06-23 14:28:43 -05:00
Jacob Herrington
d7768e00ff
Update self hosting docs with info on Forem (#8863)
We haven't updated this since announcing Forem. This isn't a
comprehensive change, but it links to some more information and is more
current that the old message.
2020-06-23 15:14:44 -04:00
Julianna Tetreault
db3cb9a42b
Extract Welcome Broadcast Styling Into Its Own Stylesheet (#8862) [deploy]
* Extract Welcome Broadcast styling into its own stylesheet
  - Adds a stylesheet, notifications-welcome-broadcast.scss, for broadcasts
  - Adds notifications-welcome-broadcast to minimal.scss
  - Removes .broadcast-content from notifications.scss
  - Adds TODOs for team-delightful to both stylesheets for future work

* Adjust TODO to be more team-specific for future greps
2020-06-23 13:05:48 -06:00
Arit Amana
e45742c212
Mod Center MVP 🎉 (#8744)
Co-authored-by: Andy Zhao <17884966+Zhao-Andy@users.noreply.github.com>
2020-06-23 14:58:16 -04:00
rhymes
40f54e317f
[deploy] Use Action Mailer parameterized syntax (#8853) 2020-06-23 13:48:41 -05:00
Alex
8714a36d27
[deploy] User subscriptions API and backend updates (#8779)
* Create "blank" EmailSubscriptionTag

* Refactor liquid_tags_used with spec

* Create /user_subscriptions#create

- Update liquid tag name to UserSubscriptionTag

* Add rate limiting and specs

* Add counter_culture for user_subscriptions

* Update /async_info/base_data

- Alphabetize user_data
- Add email
- Add subscription_source_article_ids
- Cache subscription_source_article_ids on User model

* Add stale email check and specs

* Change user_email to subscriber_email for clarity

* Restrict UserSubscriptionTag

* Rename RESTRICTED_TAGS to RESTRICTED_LIQUID_TAGS

* Make TODO comment more clear

* Refactor error responses and update specs

* Update type to source_type in error message

* Use constantize over safe_constantize

* Add check for active source

* Refactor checking of current_user's subscriptions

- Remove data from async_info
- Create a new service to fetch/cache a user's existing subscriptions

* Restrict email in base_data to admin roles

* Oops! Rename liquid tag file

* Change error back to result...oops!

* It's not goodbye, it's see you later. RIP email :/

* Add current_email to /user_subscriptions/base_data

* Revert adding current_email

* Undo async_info_controller changes/fix conflict

* Move params to constant

* Refactor SubscriptionCacheChecker

* Remove duplicate status code in JSON response

* Remove duplicate status code for #subscribed

* Use response.parsed_body

* Remove user guard in SubscriptionCacheChecker
2020-06-23 13:43:32 -04:00
Andy Zhao
75e5151292
[deploy] Remove github from reserved words (#8860) 2020-06-23 13:36:12 -04:00
Raphael Noriode
463cd07597
modify meta tag according to the twitter doc to return large images (#8858) 2020-06-23 13:03:28 -04:00
rhymes
d25a506b6d
Replace deprecated content_type with media_type (#8846) 2020-06-23 10:09:18 -05:00
Molly Struve
ff1686c70e
Update SRE files in CODEOWNERS (#8857) 2020-06-23 10:07:53 -05:00
Nick Taylor
d1f43ae4f4
Fixed warning notice Storybook name (#8856) 2020-06-23 10:13:58 -04:00
Zach Attas
db468a6cfc
Adds ability to run spec not headlessly (#8844) 2020-06-23 08:37:37 -05:00
Nick Taylor
a9c18b4359
Theme switcher in Storybook persists theme between stories and sessions now (#8855) 2020-06-23 09:05:24 -04:00
Mac Siri
559fc5b446
Remove inline style from KatexTag template (#8833) 2020-06-23 08:56:01 +02:00
Jacob Herrington
b8c35a86d9
Fix accessiblity issues flagged by axe on articles (#8840) 2020-06-23 08:55:15 +02:00
Vaidehi Joshi
439f92cf66
[deploy] Mask ip addresses + no cookies in ahoy (#8843) 2020-06-22 20:54:43 -04:00
Jacob Herrington
b603e03348
Conditionally install foreman during setup (#8391)
We should avoid install foreman during `bin/setup` if it is already
installed.
2020-06-22 19:47:57 -04:00
Rafi
ebc4534246
Fixing listing modal handler (#8773) 2020-06-22 19:11:59 -04:00
Vaidehi Joshi
9fd565d71e
Only track server-side events when needed (#8839) [deploy]
Ensures that we don't create new visits for non-logged-in users, bots,
and users with cookies disabled on every site visit. This will only
allow server-side visits when there is an event to be tracked.
2020-06-22 15:57:20 -07:00
Molly Struve
b16606e613
[deploy] Optimization: Remove followed_user_ids from Async User Data Hash (#8837) 2020-06-22 18:45:16 -04:00
Ben Halpern
e260f86e69
[deploy] Add trailing slash back in (#8838) 2020-06-22 17:22:42 -04:00
dependabot-preview[bot]
da1e703c60
Bump @babel/preset-env from 7.10.2 to 7.10.3 (#8807) 2020-06-22 16:45:07 -04:00