maverick/docbrown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[deploy] Add trailing slash back in (#8838)

Browse source
This commit is contained in:
Ben Halpern 2020-06-22 17:22:42 -04:00 • committed by GitHub
parent da1e703c60
commit e260f86e69
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
app/controllers/page_views_controller.rb
View file

@ -46,7 +46,7 @@ class PageViewsController < ApplicationMetalController
def update_organic_page_views
return if Rails.env.production? && rand(100) != 1 # We need to do this operation only once in a while.
page_views_from_google_com = @article.page_views.where(referrer: "https://www.google.com")
page_views_from_google_com = @article.page_views.where(referrer: "https://www.google.com/")
organic_count = page_views_from_google_com.sum(:counts_for_number_of_views)
@article.update_column(:organic_page_views_count, organic_count) if organic_count > @article.organic_page_views_count

4
spec/requests/page_views_spec.rb
View file

@ -70,12 +70,12 @@ RSpec.describe "PageViews", type: :request do
end
it "stores aggregate organic page views" do
post "/page_views", params: { article_id: article.id, referrer: "https://www.google.com" }
post "/page_views", params: { article_id: article.id, referrer: "https://www.google.com/" }
post "/page_views", params: { article_id: article.id }
expect(article.reload.organic_page_views_count).to eq(10)
expect(article.reload.organic_page_views_past_week_count).to eq(10)
expect(article.reload.organic_page_views_past_month_count).to eq(10)
post "/page_views", params: { article_id: article.id, referrer: "https://www.google.com" }
post "/page_views", params: { article_id: article.id, referrer: "https://www.google.com/" }
expect(article.reload.organic_page_views_count).to eq(20)
post "/page_views", params: { article_id: article.id }
expect(article.reload.organic_page_views_count).to eq(20)