maverick/docbrown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix accessiblity issues flagged by axe on articles (#8840)

Browse source
This commit is contained in:
Jacob Herrington 2020-06-23 01:55:15 -05:00 • committed by GitHub
parent 439f92cf66
commit b8c35a86d9
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
app/views/articles/show.html.erb
View file

@ -88,11 +88,11 @@
<% has_long_markdown = @article.body_markdown && @article.body_markdown.size > 900 %>
<div class="crayons-layout crayons-layout--3-cols crayons-layout--article">
<div class="crayons-layout__sidebar-left">
<aside class="crayons-layout__sidebar-left" aria-label="Article actions">
<%= render "articles/actions" %>
</div>
</aside>
<div class="crayons-layout__content grid gap-4">
<main class="crayons-layout__content grid gap-4">
<% if !@article.published %>
<div class="crayons-notice crayons-notice--danger">
<strong>Unpublished Post.</strong> This URL is public but secret, so share at your own discretion.
@ -219,9 +219,9 @@
<% suggested_articles = ArticleSuggester.new(@article).articles(max: 4) %>
<%= render "articles/bottom_content", articles: suggested_articles %>
<% end %>
</div>
</main>
<aside class="crayons-layout__sidebar-right">
<aside class="crayons-layout__sidebar-right" aria-label="Right sidebar navigation">
<% stick_nav_cache_key = "sticky-sidebar-#{@article.id}-#{(@organization || @user).profile_updated_at}-#{(@organization || @user).last_article_at}-1-#{@user.pro?}" %>
<% cache(stick_nav_cache_key, expires_in: 50.hours) do %>
<%= render "articles/sticky_nav" %>