maverick/docbrown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix accessiblity warnings on Listings page (#8841)

Browse source 
This should fix ~60 axe warnings on this page. This commit also removes
some markup that is being overwritten by Preact.
This commit is contained in:
Jacob Herrington 2020-06-24 06:28:03 -05:00 • committed by GitHub
parent 7536ad293f
commit c2af5d8f59
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 10 additions and 21 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

31
app/views/listings/index.html.erb
View file

@ -26,26 +26,15 @@
<meta name="twitter:card" content="summary_large_image">
<% end %>
<div class="home">
<div class="listings-container" id="listings-index-container"
data-category="<%= params[:category] %>" data-listings="<%= @listings_json %>"
data-allcategories="<%= categories_for_display.to_json %>"
<% if @displayed_listing %>
data-displayedlisting="<%= @displayed_listing_json %> "
<% end %>>
<div class="listing-filters">
<div class="listing-filters-categories">
<a href="<%= listings_path %>" class="<%= "selected" if params[:category].blank? %> data-no-instant=" true ">all</a>
<% categories_for_display.each do |cat| %>
<a href="<%= listing_category_path(category: cat[:slug]) %> " class="<%= "selected" if params[:category] == cat[:slug] %> data-no-instant="true"><%= cat[:name] %></a>
<% end %>
<a href="<%= new_listing_path %>" class='listing-create-link'>Create a Listing</a>
<% if @displayed_listing %>
<div class="listing-listings-modal-background" role='presentation'></div>
<% end %>
</div>
</div>
</div>
<main class="home">
<h1 class="visually-hidden-header">Listings</h1>
<section class="listings-container" id="listings-index-container"
data-category="<%= params[:category] %>" data-listings="<%= @listings_json %>"
data-allcategories="<%= categories_for_display.to_json %>"
<% if @displayed_listing %>
data-displayedlisting="<%= @displayed_listing_json %> "
<% end %>>
</section>
</main>
<%= javascript_packs_with_chunks_tag "listings", defer: true %>