Commit graph

7035 commits

Author SHA1 Message Date
Vaidehi Joshi
54cb0ecefe
Fix required button styling in SiteConfig (#10857) [deploy]
* Use crayons-indicator--critical class when rendering Required note

* Add a bit of padding to the site-config label to give button room
2020-10-14 15:04:36 -07:00
Mac Siri
5b211e33d7
Resave users for Imgproxy migration (#10853) 2020-10-14 17:39:06 -04:00
Rafi
0d2b4c515d
Replace globals with node env (#10767) 2020-10-14 17:05:38 -04:00
Molly Struve
f39219e6e5
[deploy] Optimization:Break up SiteConfig Updates by Groups (#10851) 2020-10-14 15:33:33 -05:00
ludwiczakpawel
ebe398ba23
[deploy] Logo updates (#10840)
* logo updates

* fix

* fix

* drop it like its hot

* no siteconfig

* um...
2020-10-14 16:13:42 -04:00
Diogo Osório
2b72a35d3d
[deploy] Introduce /api/profile_images/:username endpoint (#10547)
* Documents the new /profile-images/:username API endpoint

* Introduces the /api/profile_images/:username endpoint

This endpoint receives either an user or organization username as input
via the URL path and returns the profile image information for that
user/orgnization.

* Updates the /api/profile_images/:username response

Adapts the response according to the review comments:

1. Removes the cache directives
1. Tweaks how the user query is being done
1. Adds a `image_of` property to the response

* Bump API version

Co-authored-by: rhymes <rhymes@hey.com>
Co-authored-by: Molly Struve <mollylbs@gmail.com>
2020-10-14 14:24:25 -05:00
Jean-Francis Bastien
9ff7f82664
[deploy] API - New endpoint to retrieve the articles in the reading list of the authenticated user (#10540) 2020-10-14 13:20:03 -05:00
Ben Halpern
b5f20c0a46
Make allow email password login default true (#10838)
* Make allow email password login default true

* Change test
2020-10-14 13:34:01 -04:00
Mac Siri
30fa3b79a3
Default to Imgproxy on Forem-cloud (#10819) 2020-10-14 12:54:59 -04:00
Rafi
9514df9ea6
Showing example code in storybook (#10765)
Co-authored-by: Nick Taylor <nick@dev.to>
2020-10-14 10:39:32 -04:00
Lisa Sy
36e271e1cb
Deprecate old button stylings with Crayons buttons (#10694) [deploy]
* Deprecate old buttons.scss file

* Replace outdated button styles with Crayons button styling

* Update additional views after removing old button styling

* Update tests

* Update test

* Update test

* Fix button placements
2020-10-14 07:28:41 -07:00
Ridhwana
bb6d450d4b
[deploy] Fix ui for signup with email (#10841)
* fix: add html_safe so that it will render it as html

* fix: use html_safe so that it will render the svg as safe html
2020-10-14 16:04:23 +02:00
Ivan
4f79da26c3
add fullscreen to code blocks (#10784)
* add fullscreen to code blocks

* add review fixes

* remove extra import

* fix approved tests

* code review - paddings

* fix padding to make highlight code scrollable
within  padded area

* add fullscreen to existing webpack entrypoint

* fixed aria: true generated extra ids

* fix tests
2020-10-14 12:01:35 +02:00
Molly Struve
1d8c87715f
Add Specs for Basic Feed Class (#10833) 2020-10-13 17:52:50 -05:00
Lisa Sy
3377b5b69e
Update [authentication] in /admin/config (#10748)
* Write up new accordion view in markup

* Add inline SVG and edit padding of form

* Fix padding

* Remove extraneous buttons for current draft
2020-10-13 16:43:29 -04:00
Mac Siri
01414a5120
Refactor carrierwave config (#10756)
* Refactor carrierwave config

* Remove development specific config

* Remove fog att

* Rearrange attempt #2
2020-10-13 14:15:27 -04:00
Akshay Mahajan
f6c1fe0ade
Fix missing category in delete draft listing URL (#10809)
* added category in DASHBOARD_JSON_OPTIONS in listing_controller.rb

* added test to make sure that draft listings contain category
2020-10-13 14:04:07 -04:00
Molly Struve
73cb7f0d42
Comment out Flaky Basic Feed Spec (#10831) 2020-10-13 13:01:48 -05:00
Ben Halpern
bc248f17e7
Skip edge caching for private forems (#10817)
* Skip edge caching for private forems

* Add test

* Update spec/requests/stories_index_spec.rb

* Adjust comment

* Also check other cache-related headers
2020-10-13 13:36:20 -04:00
Molly Struve
7ce3b8abd2
[deploy] Feature:Add Video States Encoder Key to SiteConfig (#10818) 2020-10-13 12:14:07 -05:00
Molly Struve
ea969748e9
Feature:Notify Devs when Sidekiq is Not Running in Development (#10541) 2020-10-13 12:13:47 -05:00
Ridhwana
9e8ce4569e
SVG logo image re-sizing (#10826)
* feat: add some heights and widths on the logo svg so any svg can be resized to fit in the header

* chore: show a realistic view of the logo as per the header
2020-10-13 17:41:31 +02:00
Julien Maury
fc933b991a
[deploy] fix dropdown svg for dark themes - comment section (#10769)
* fix dropdown svg for dark themes - comment section

* missing classes on buttons

* delete class ghost

* test svg on all themes
2020-10-13 17:08:00 +02:00
Julianna Tetreault
cb93197d43
Fixes "Invite Flow" 404s for Unregistered Users (#10743) [deploy]
* Add conditional to display "<username> is not registered" or Admin User profile in /admin/show.html.erb
  -Displays a "<username> is not registered" message for unregistered users
  -Displays all linked usernames and Admin User info for registered users

* Adds tests around unregistered users Admin User profiles

* Use predicate method in all conditionals in /admin/users/show.html.erb

* Adjusts message alerting admins that a user has not accepted the invite yet
  - Makes the message displayed on the Admin User prof more explicit
  - Makes GETS singular instead of plural in invitations_spec.rb
  - Updates users_spec.rb to test against updated message
2020-10-13 07:53:29 -06:00
Jacob Herrington
54db91bb4b
Add input validation for sidebar tags (#10822) 2020-10-13 08:39:46 -05:00
Christina
16a7d8c47f
Adding name to core-team per my on-boarding doc (#10821) 2020-10-13 11:13:59 +07:00
Ben Halpern
431a00366d
Ensure serviceworker bypass only checks path (#10820) 2020-10-12 17:52:48 -04:00
Ridhwana
66b14fc0bf
[deploy] Dynamic frontend for the sidebar navigation Items (#10754)
* feat: configure the frontend for sidebar nav links

* chore: add a comment

* changes to the admin interface

* feat: move the temporary task to be in the rake tasks and use it in the dev seeds

* feat: use the task in the rake seeds

* refactor: reuse the form across two modals

* refactor: use the form partial

* feat: change the modal to be large

* fix: naming

* Update db/seeds.rb

Co-authored-by: Michael Kohl <me@citizen428.net>

* chore: make the file readable

* chore: removed the if else as the rake task was run on all forems + i sent out a message to new communities

* oops

* refactor: add a scope

* chore: oops removed this

* feat: add navigation links specs

* spec: fix two failing ones

Co-authored-by: Michael Kohl <me@citizen428.net>
2020-10-12 16:05:47 -04:00
dependabot-preview[bot]
ee7ef33c0b
Bump babel-jest from 26.3.0 to 26.5.2 (#10773)
Bumps [babel-jest](https://github.com/facebook/jest/tree/HEAD/packages/babel-jest) from 26.3.0 to 26.5.2.
- [Release notes](https://github.com/facebook/jest/releases)
- [Changelog](https://github.com/facebook/jest/blob/master/CHANGELOG.md)
- [Commits](https://github.com/facebook/jest/commits/v26.5.2/packages/babel-jest)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-10-12 14:13:47 -04:00
Jacob Herrington
221f134d83
Remove code setting SiteConfig values in specs (#10811) 2020-10-12 12:06:10 -05:00
Arit Amana
f4bd1df21c
[Email/Password Authentication] Allow Admins to enable email/password login (#10745)
* Implement Admins ability to allow email login

* Write specs for admin allow email login

* Fix specs causing builds to fail

* Fix spec causing builds to fail

* Use dummyimage.com for spec images

Co-authored-by: Josh Puetz <joshpuetz@gmail.com>

* Use dummyimage.com

* refactor setting of SiteConfig attributes

* Address PR review comments

* fix indentation

* Use "allow to receive and return" approach for other specs

Co-authored-by: Josh Puetz <joshpuetz@gmail.com>
2020-10-12 12:54:35 -04:00
Molly Struve
e42b6d6b46
Flaky Spec Fix:Clear Article Content Before Filling In (#10810) 2020-10-12 10:46:25 -05:00
Jacob Herrington
c37b283865
Allow Forem admins to enable an invite only mode. (#10758)
* Add invite only mode field to SiteConfig

* Add UI elements for invite only mode
2020-10-12 11:27:22 -04:00
dependabot-preview[bot]
ef613b0241
Bump ibm-openapi-validator from 0.30.0 to 0.30.1 (#10781)
Bumps [ibm-openapi-validator](https://github.com/IBM/openapi-validator) from 0.30.0 to 0.30.1.
- [Release notes](https://github.com/IBM/openapi-validator/releases)
- [Changelog](https://github.com/IBM/openapi-validator/blob/master/CHANGELOG.md)
- [Commits](https://github.com/IBM/openapi-validator/compare/v0.30.0...v0.30.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-10-12 11:26:26 -04:00
dependabot-preview[bot]
2a62f27343
Bump pusher from 1.3.3 to 1.4.1 (#10770)
* Bump pusher from 1.3.3 to 1.4.1

Bumps [pusher](https://github.com/pusher/pusher-http-ruby) from 1.3.3 to 1.4.1.
- [Release notes](https://github.com/pusher/pusher-http-ruby/releases)
- [Changelog](https://github.com/pusher/pusher-http-ruby/blob/master/CHANGELOG.md)
- [Commits](https://github.com/pusher/pusher-http-ruby/commits/v1.4.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Bump pusher from 1.3.3 to 1.4.1 (Update vendor/cache)

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-10-12 11:24:59 -04:00
dependabot-preview[bot]
11ceac897e
Bump eslint-plugin-react from 7.21.2 to 7.21.4 (#10772)
Bumps [eslint-plugin-react](https://github.com/yannickcr/eslint-plugin-react) from 7.21.2 to 7.21.4.
- [Release notes](https://github.com/yannickcr/eslint-plugin-react/releases)
- [Changelog](https://github.com/yannickcr/eslint-plugin-react/blob/master/CHANGELOG.md)
- [Commits](https://github.com/yannickcr/eslint-plugin-react/compare/v7.21.2...v7.21.4)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-10-12 11:24:29 -04:00
dependabot-preview[bot]
5e2da9abad
Bump @storybook/addon-storyshots from 6.0.21 to 6.0.26 (#10775)
Bumps [@storybook/addon-storyshots](https://github.com/storybookjs/storybook/tree/HEAD/addons/storyshots/storyshots-core) from 6.0.21 to 6.0.26.
- [Release notes](https://github.com/storybookjs/storybook/releases)
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md)
- [Commits](https://github.com/storybookjs/storybook/commits/v6.0.26/addons/storyshots/storyshots-core)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-10-12 11:24:02 -04:00
dependabot-preview[bot]
dea92ea5e0
Bump sass-loader from 10.0.2 to 10.0.3 (#10776)
Bumps [sass-loader](https://github.com/webpack-contrib/sass-loader) from 10.0.2 to 10.0.3.
- [Release notes](https://github.com/webpack-contrib/sass-loader/releases)
- [Changelog](https://github.com/webpack-contrib/sass-loader/blob/master/CHANGELOG.md)
- [Commits](https://github.com/webpack-contrib/sass-loader/compare/v10.0.2...v10.0.3)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-10-12 11:07:55 -04:00
dependabot-preview[bot]
8b0c2e7225
Bump preact from 10.5.3 to 10.5.4 (#10778)
Bumps [preact](https://github.com/preactjs/preact) from 10.5.3 to 10.5.4.
- [Release notes](https://github.com/preactjs/preact/releases)
- [Commits](https://github.com/preactjs/preact/compare/10.5.3...10.5.4)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-10-12 11:07:29 -04:00
Darshak Parikh
dfaa747405
[deploy] Add im-in.space Mastodon instance (#10804)
Co-authored-by: rhymes <rhymes@hey.com>
2020-10-12 16:59:52 +02:00
dependabot-preview[bot]
5d5be2e883
Bump jest from 26.4.2 to 26.5.3 (#10807)
Bumps [jest](https://github.com/facebook/jest) from 26.4.2 to 26.5.3.
- [Release notes](https://github.com/facebook/jest/releases)
- [Changelog](https://github.com/facebook/jest/blob/master/CHANGELOG.md)
- [Commits](https://github.com/facebook/jest/compare/v26.4.2...v26.5.3)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-10-12 16:14:51 +02:00
dependabot-preview[bot]
bf088132e6
Bump eslint from 7.10.0 to 7.11.0 (#10774)
Bumps [eslint](https://github.com/eslint/eslint) from 7.10.0 to 7.11.0.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md)
- [Commits](https://github.com/eslint/eslint/compare/v7.10.0...v7.11.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-10-12 10:08:33 -04:00
Michael Kohl
c340621924
Remove ignored columns from User (#10787) 2020-10-12 10:04:51 -04:00
dependabot-preview[bot]
cc210ae332
Bump file-loader from 6.1.0 to 6.1.1 (#10780)
Bumps [file-loader](https://github.com/webpack-contrib/file-loader) from 6.1.0 to 6.1.1.
- [Release notes](https://github.com/webpack-contrib/file-loader/releases)
- [Changelog](https://github.com/webpack-contrib/file-loader/blob/master/CHANGELOG.md)
- [Commits](https://github.com/webpack-contrib/file-loader/compare/v6.1.0...v6.1.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-10-12 09:53:46 -04:00
rhymes
a1e8634b90
[deploy] Disable flakey Runkit test (#10806) 2020-10-12 15:48:29 +02:00
Yash Dave
9b693a8a8d
Fix overflow of indented code-blocks in lists (#10782)
* fix overflow in list indented code blocks
- add styling for .highlight to <pre> inside <li>

* add `div.highlight` styling to `li blockquote.highlight`

Co-authored-by: ludwiczakpawel <ludwiczakpawel@gmail.com>

Co-authored-by: ludwiczakpawel <ludwiczakpawel@gmail.com>
2020-10-12 15:19:22 +02:00
Rafi
177659fd2e
Adding role and aria labels to help screen readers (#10785) 2020-10-12 11:01:14 +02:00
dependabot-preview[bot]
4babb9e6de
Bump rubocop from 0.92.0 to 0.93.0 (#10771)
* Bump rubocop from 0.92.0 to 0.93.0

Bumps [rubocop](https://github.com/rubocop-hq/rubocop) from 0.92.0 to 0.93.0.
- [Release notes](https://github.com/rubocop-hq/rubocop/releases)
- [Changelog](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop-hq/rubocop/compare/v0.92.0...v0.93.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Bump rubocop from 0.92.0 to 0.93.0 (Update vendor/cache)

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-10-12 10:49:11 +02:00
Michael Kohl
f95acef2bc
Profile generalization tidbits (#10631)
* Load all profile fields on app start

This time without breaking bin/setup (hopefully)

* A SiteConfig.dev_to? for special case logic

* Update BanishUser#remove_profile_info

* Continue clearing data from users table for now

* Add specs for SiteConfig#dev.to?

* Use correct attribute list

* Update spec/models/site_config_spec.rb

Co-authored-by: Michael Currin <18750745+MichaelCurrin@users.noreply.github.com>

Co-authored-by: Michael Currin <18750745+MichaelCurrin@users.noreply.github.com>
2020-10-12 10:01:27 +07:00
ludwiczakpawel
dd6e2246ab
[deploy] crayons prep (#10737) 2020-10-09 18:07:49 -04:00