maverick/docbrown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Add Specs for Basic Feed Class (#10833)

Browse source
This commit is contained in:
Molly Struve 2020-10-13 17:52:50 -05:00 • committed by GitHub
parent 3377b5b69e
commit 1d8c87715f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 29 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

42
spec/services/articles/feeds/basic_spec.rb
View file

@ -2,23 +2,39 @@ require "rails_helper"
RSpec.describe Articles::Feeds::Basic, type: :service do
let(:user) { create(:user) }
let!(:feed) { described_class.new(user: user, number_of_articles: 100, page: 1) }
let!(:article) { create(:article) }
let(:unique_tag_name) { "foo" }
let!(:article) { create(:article, hotness_score: 10) }
let!(:hot_story) { create(:article, hotness_score: 1000, score: 1000, published_at: 3.hours.ago) }
let!(:old_story) { create(:article, published_at: 3.days.ago) }
let!(:old_story) { create(:article, hotness_score: 500, published_at: 3.days.ago, tags: unique_tag_name) }
let!(:low_scoring_article) { create(:article, score: -1000) }
let!(:month_old_story) { create(:article, published_at: 1.month.ago) }
let!(:month_old_story) { create(:article, published_at: 1.month.ago) } # rubocop:disable RSpec/LetSetup
xit "returns articles in approximately published order" do
result = feed.feed
expect(result.first).to eq hot_story
expect(result.second).to eq article
expect(result.third).to eq old_story
expect(result.last).to eq month_old_story
context "without a user" do
let(:feed) { described_class.new(user: nil, number_of_articles: 100, page: 1) }
it "returns articles with score above 0 in order of hotness score" do
result = feed.feed
expect(result.first).to eq hot_story
expect(result.second).to eq old_story
expect(result.third).to eq article
expect(result).not_to include(low_scoring_article)
end
end
it "does not include low quality" do
result = feed.feed
expect(result).not_to include(low_scoring_article)
context "with a user" do
let(:feed) { described_class.new(user: user, number_of_articles: 100, page: 1) }
it "returns articles with score above 0 sorted by user preference scores" do
allow(feed).to receive(:user_following_users_ids).and_return([old_story.user_id])
old_story_tag = Tag.find_by(name: unique_tag_name)
old_story_tag.update(points: 10)
allow(feed).to receive(:user_followed_tags).and_return([old_story_tag])
result = feed.feed
expect(result.first).to eq old_story
expect(result.second).to eq hot_story
expect(result.third).to eq article
expect(result).not_to include(low_scoring_article)
end
end
end