From 1d8c87715f4f718e849914f6cd2604be53f0c839 Mon Sep 17 00:00:00 2001
From: Molly Struve <mollylbs@gmail.com>
Date: Tue, 13 Oct 2020 17:52:50 -0500
Subject: [PATCH] Add Specs for Basic Feed Class (#10833)

---
 spec/services/articles/feeds/basic_spec.rb | 42 +++++++++++++++-------
 1 file changed, 29 insertions(+), 13 deletions(-)

diff --git a/spec/services/articles/feeds/basic_spec.rb b/spec/services/articles/feeds/basic_spec.rb
index 1712ec9b9..9152689b8 100644
--- a/spec/services/articles/feeds/basic_spec.rb
+++ b/spec/services/articles/feeds/basic_spec.rb
@@ -2,23 +2,39 @@ require "rails_helper"
 
 RSpec.describe Articles::Feeds::Basic, type: :service do
   let(:user) { create(:user) }
-  let!(:feed) { described_class.new(user: user, number_of_articles: 100, page: 1) }
-  let!(:article) { create(:article) }
+  let(:unique_tag_name) { "foo" }
+  let!(:article) { create(:article, hotness_score: 10) }
   let!(:hot_story) { create(:article, hotness_score: 1000, score: 1000, published_at: 3.hours.ago) }
-  let!(:old_story) { create(:article, published_at: 3.days.ago) }
+  let!(:old_story) { create(:article, hotness_score: 500, published_at: 3.days.ago, tags: unique_tag_name) }
   let!(:low_scoring_article) { create(:article, score: -1000) }
-  let!(:month_old_story) { create(:article, published_at: 1.month.ago) }
+  let!(:month_old_story) { create(:article, published_at: 1.month.ago) } # rubocop:disable RSpec/LetSetup
 
-  xit "returns articles in approximately published order" do
-    result = feed.feed
-    expect(result.first).to eq hot_story
-    expect(result.second).to eq article
-    expect(result.third).to eq old_story
-    expect(result.last).to eq month_old_story
+  context "without a user" do
+    let(:feed) { described_class.new(user: nil, number_of_articles: 100, page: 1) }
+
+    it "returns articles with score above 0 in order of hotness score" do
+      result = feed.feed
+      expect(result.first).to eq hot_story
+      expect(result.second).to eq old_story
+      expect(result.third).to eq article
+      expect(result).not_to include(low_scoring_article)
+    end
   end
 
-  it "does not include low quality" do
-    result = feed.feed
-    expect(result).not_to include(low_scoring_article)
+  context "with a user" do
+    let(:feed) { described_class.new(user: user, number_of_articles: 100, page: 1) }
+
+    it "returns articles with score above 0 sorted by user preference scores" do
+      allow(feed).to receive(:user_following_users_ids).and_return([old_story.user_id])
+      old_story_tag = Tag.find_by(name: unique_tag_name)
+      old_story_tag.update(points: 10)
+      allow(feed).to receive(:user_followed_tags).and_return([old_story_tag])
+
+      result = feed.feed
+      expect(result.first).to eq old_story
+      expect(result.second).to eq hot_story
+      expect(result.third).to eq article
+      expect(result).not_to include(low_scoring_article)
+    end
   end
 end