maverick/docbrown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Adding role and aria labels to help screen readers (#10785)

Browse source
This commit is contained in:
Rafi 2020-10-12 14:31:14 +05:30 • committed by GitHub
parent 4babb9e6de
commit 177659fd2e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
app/views/onboardings/_task_card.html.erb
View file

@ -16,7 +16,7 @@
}
</style>
<div class="onboarding-task-card">
<div class="onboarding-task-card" role="dialog" aria-labelledby="task-card-title" aria-describedby="task-card-subtitle">
<button class="close" onclick="closeTaskCard()" aria-label="Close Welcome message">
<svg width="14" height="14" viewBox="0 0 14 14" fill="none" xmlns="http://www.w3.org/2000/svg">
<path d="M6.99974 5.58623L11.9497 0.63623L13.3637 2.05023L8.41374 7.00023L13.3637 11.9502L11.9497 13.3642L6.99974 8.41423L2.04974 13.3642L0.635742 11.9502L5.58574 7.00023L0.635742 2.05023L2.04974 0.63623L6.99974 5.58623Z" fill="white" />
@ -27,8 +27,8 @@
<img alt="onboarding task card image" class="task-card-image" src="<%= safe_logo_url(SiteConfig.onboarding_taskcard_image) %>" />
</div>
<h1 class="task-card-title">You're now a part of the community!</h1>
<p class="task-card-subtitle">SUGGESTED THINGS YOU CAN DO</p>
<h1 class="task-card-title" id="task-card-title">You're now a part of the community!</h1>
<p id="task-card-subtitle" class="task-card-subtitle">SUGGESTED THINGS YOU CAN DO</p>
<ul class="task-card-actions">
<li class="task-card-action">
<a class="task-card-link" href="/welcome">