maverick/docbrown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Make allow email password login default true (#10838)

Browse source 
* Make allow email password login default true

* Change test
This commit is contained in:
Ben Halpern 2020-10-14 13:34:01 -04:00 • committed by GitHub
parent 30fa3b79a3
commit b5f20c0a46
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
app/lib/constants/site_config.rb
View file

@ -6,7 +6,7 @@ module Constants
placeholder: ""
},
allow_email_password_login: {
description: "Can users login with only email and password?",
description: "Can users login using email and password?",
placeholder: ""
},
authentication_providers: {

2
app/models/site_config.rb
View file

@ -23,7 +23,7 @@ class SiteConfig < RailsSettings::Base
# Authentication
field :allow_email_password_registration, type: :boolean, default: false
field :allow_email_password_login, type: :boolean, default: false
field :allow_email_password_login, type: :boolean, default: true
field :authentication_providers, type: :array, default: proc { Authentication::Providers.available }
field :invite_only_mode, type: :boolean, default: false
field :twitter_key, type: :string, default: ApplicationConfig["TWITTER_KEY"]

1
spec/requests/registrations_spec.rb
View file

@ -17,6 +17,7 @@ RSpec.describe "Registrations", type: :request do
it "only shows the single sign on options if they are present" do
allow(Authentication::Providers).to receive(:enabled).and_return([])
allow(SiteConfig).to receive(:allow_email_password_login).and_return(false)
get sign_up_path