Mac Siri
0f5da03ccb
Optimize published_articles_by_tag fetch speed ( #12584 )
2021-02-05 09:25:04 -05:00
Ben Halpern
e1b1fe3ed7
Declare winner in feed_top_articles_query test ( #12308 )
...
* Declare winner in feed_top_articles_query test
* Some WIP modifications to lfe
* Fix up tests and generalize
* Fix style
* Adjust tests to handle different field test scenarios
* Remove socre_randomness tests
* Fix test to fit stub
* Update app/workers/users/record_field_test_event_worker.rb
2021-02-04 13:02:00 -05:00
Michael Kohl
e258e36c92
Remove language settings ( #12502 )
...
* Remove language settings
* Remove more language related code
* Remove leftover spec
* Remove language from ES mapping
2021-02-04 08:35:00 +07:00
rhymes
cb43c9f808
Routine rubocop fixes ( #12530 )
2021-02-03 10:16:19 -05:00
Ben Halpern
472c3d2922
Fix and refactor hide user content ( #12307 )
2021-01-18 11:08:23 -05:00
rhymes
c2c1366a4d
Enable new rules and run Rubocop autocorrect ( #12232 )
2021-01-14 16:35:27 -05:00
Ben Halpern
0ec2a40fe0
Test variants for which posts are fetched on initial "hot articles" home feed query. ( #11982 )
...
* Declare winner in update points worker
* Remove tests
* Test variants for which posts are fetched on home feed
* Add field test
* Rewrite field tests
* Change user to @user
* Fix tests
* Fix user thing
* Check for existence of user before setting experiment
* Fix experiment -> @experiment
* Change spec
* Fix tests
* Fix tests
* Fix tests
* Fix rubocop issues
* Remove unneeded offset value
* Fix up specs
* Final adjustments
* Add comments
* Update app/services/articles/feeds/large_forem_experimental.rb
Co-authored-by: Molly Struve <mollylbs@gmail.com>
* Update app/services/articles/feeds/large_forem_experimental.rb
Co-authored-by: Molly Struve <mollylbs@gmail.com>
* Update app/services/articles/feeds/large_forem_experimental.rb
Co-authored-by: Fernando Valverde <fdov88@gmail.com>
* Update app/services/articles/feeds/large_forem_experimental.rb
Co-authored-by: Fernando Valverde <fdov88@gmail.com>
* Better initial user query
Co-authored-by: Molly Struve <mollylbs@gmail.com>
Co-authored-by: Fernando Valverde <fdov88@gmail.com>
2021-01-05 12:29:46 -05:00
Michael Kohl
bfb505d088
Move LanguageDetector to service ( #12035 )
2021-01-04 19:12:24 -05:00
Ben Halpern
d759ac4627
Add implicit points to follows to improve feed relevancy (in all algorithms) ( #11513 )
...
* Fix menu dropdown disable issue
* Initial base work
* Add real algorithm
* Add working object and test
* Fix schema
* Fix schema
* Fix schema
* Finalize
* Add update script and explict_points
* Proper implicit/explicit points
* Fix tests
* Add docs
* Fix tests
* Fix data update script test
* Fix data update script test
* Fix typo
* Improve efficiency and add more logic
* Changed to find_each
* Change to bulk insert
* Update tests and refactor logic
* Various improvements
* Fix typo
* Fix tests
* Remove extra line
* Fix tests
* Fix test typo
* Cache site-wide tag names
2020-11-25 16:09:51 -05:00
Molly Struve
dc7d9d5843
Refactor/Optimization:Use more_comments_minimal_weight_randomized_at_end for Signed In Feed ( #11604 )
2020-11-24 15:36:55 -06:00
Molly Struve
abbc29dafe
Bug Fix:User >= when filtering by SiteConfig.home_feed_minimum_score ( #11567 )
2020-11-23 09:13:03 -06:00
Molly Struve
cf619caf70
Refactor: Remove more_tag_weight_more_random_experiment ( #11447 )
2020-11-16 15:48:45 -06:00
Michael Kohl
b46323d0b2
Move ArticleSuggester to Articles::Suggest service ( #11370 )
2020-11-11 13:06:33 -05:00
Molly Struve
a0c174fcb7
Refactor:Remove more_experience_level_weight_experiment From Feed Tests ( #11340 )
2020-11-09 13:59:59 -06:00
Molly Struve
ea156a201d
[deploy] Optimization:Remove more_tag_weight_experiment From Feed Tests ( #11089 )
2020-10-27 16:36:53 -05:00
Molly Struve
f54549cca3
[deploy] Optimization:Remove 2 Feed Experiments ( #11007 )
2020-10-22 11:22:00 -05:00
Molly Struve
1d8c87715f
Add Specs for Basic Feed Class ( #10833 )
2020-10-13 17:52:50 -05:00
Molly Struve
73cb7f0d42
Comment out Flaky Basic Feed Spec ( #10831 )
2020-10-13 13:01:48 -05:00
Ben Halpern
0ed408a409
Fix feed order for basic ( #10717 )
...
* Fix feed order for basic
* Fix spec
2020-10-07 11:26:32 -04:00
Ben Halpern
f87e9eace1
[deploy] Add feed_strategy config ( #10245 )
...
* Add feed_strategy config
* Add configs spec
* Fix specs
* Fix field test scenario
* Linting
* A couple small changes
* Rename Optimized and objects
* Add proper namespace
* Fix codeclimate
* Add docs
* Update docs/technical-overview/readme.md
2020-10-06 17:36:27 -04:00
Ben Halpern
986eb87ce8
[deploy] Remove unneeded Analytics update script ( #9852 )
...
* Remove unneeded Analytics update script
* Remove constants
2020-08-19 15:57:27 -04:00
rhymes
3722355e8c
Rubocop: fix Metrics/CyclomaticComplexity and disable Metrics/AbcSize ( #9221 )
...
* Fix Metrics/CyclomaticComplexity
* Disable Metrics/AbcSize
* Refactored Articles::Builder a bit
2020-07-10 15:26:05 +02:00
rhymes
5b62811c98
[deploy] Rubocop: fix violations of Layout/LineLength ( #9197 )
2020-07-08 08:36:36 -05:00
Molly Struve
70ba4eba2f
Spec Speed Up: Memoize Feed objects and Combine some Tests ( #8305 )
2020-06-08 17:15:34 +02:00
ludwiczakpawel
a161d3ce31
[deploy] Redesign article editor ( #7524 )
2020-05-29 11:59:37 -04:00
Ben Halpern
cd18d2f436
[deploy] Add alternate comment-oriented feed algos ( #8042 )
2020-05-26 13:23:03 -04:00
Andy Zhao
c42fd3461e
[deploy] Rename positive_reactions_count to public_reactions_count in logic ( #7926 )
...
* Rename positive_reactions_count to public_reactions_count
* Add positive reactions count back in so we can remove it
* Use public_category method for reactions
* Add positive_reactions_count in case any old caches rely on it
* Add positive_rxn_count to account for API endpoints
* Remove unused method
* One more spot...
* Add method back in because of caches
* Update specs to match new functionality
* Fix typo
* Remove unused methods
2020-05-26 12:36:28 -04:00
Renan Bona
b93306ecc8
Create Articles builder and refactor articles_controller ( #7381 )
...
* Create Articles entity and refactor articles_controller
* Add safe operator into action new from articles_controller
* Renaming files for better understanding
* Move some logic from the articles controller to articles builder
* Add method normalized text into articles builder
2020-04-28 12:24:51 +02:00
Ben Halpern
645920c09f
[deploy] Remove milestone sends ( #7313 )
2020-04-15 19:34:10 -04:00
Michael Kohl
c8845e647a
[deploy] Remove Google Analytics page counts ( #6969 )
...
* Remove Google Analytics page counts
* Update spec
Co-authored-by: rhymes <rhymesete@gmail.com>
Co-authored-by: Ben Halpern <bendhalpern@gmail.com>
2020-04-14 10:44:05 -04:00
Mac Siri
1cb51780cb
Update feed_spec's use of NON_DEFAULT_EXPERIMENTS ( #6975 )
2020-03-31 11:43:34 -04:00
rhymes
d03c751c65
Rubocop fixes ( #6904 )
...
* Run rubocop -a
* Regenerate rubocop todo
* Fix Lint/UselessAssignment
* Fix RSpec/RepeatedDescription
* Fix Style/GuardClause
* Fix Style/NumericPredicate
* Regenerate rubocop todo
2020-03-27 15:30:59 +01:00
Ben Halpern
da8dbd2180
Add feed variants with shuffle post-ranking ( #6766 ) [deploy]
...
* Add feed variants with shuffle post-ranking
* Refactor tests and fix erroneous shuffle
2020-03-23 18:09:30 -04:00
Ben Halpern
8b0cfaf48a
Add two new experiments and one new conversion event ( #6633 ) [deploy]
...
* Add two new experiments and one new conversion event
* change hours in 7 to 24
2020-03-16 18:16:02 -04:00
Anna Buianova
481db91fdc
Remove active job remainders ( #6603 )
...
* Replaced remaining ActiveJob test helpers with sidekiq ones
* Removed unused ActiveJob shared example
2020-03-12 15:31:43 +01:00
Ben Halpern
923afed4e4
Move math around parenthases in score_experience_level ( #6569 ) [deploy]
...
* Move math around parenthases in score_experience_level
* Clean up tests
* Remove flash notice from comments form
2020-03-10 14:14:08 -04:00
Molly Struve
7df5e6cfae
Rename feed method to correct name ( #6557 )
...
* rename method to correct name
* fix spec
2020-03-09 16:59:38 -04:00
Josh Puetz
a01d787301
Create comment ranking feed experiment ( #6511 ) [deploy]
...
* Create more comments feed experiment
* Hook up experiment, rename
* Remove flakey test assertion
2020-03-09 14:20:02 -05:00
Josh Puetz
e2f190512b
Guarantee articles in main article feed ( #6490 ) [deploy]
...
* Adjust feed offset, remove time limits for main feed
* Improve offset construction readability
2020-03-06 12:29:07 -06:00
Ben Halpern
d2bd9e95ae
Add more tag weight/more random variant ( #6451 ) [deploy]
2020-03-04 12:44:52 -05:00
Josh Puetz
6d7cbfff1f
Restore featured story on timeframe pages for logged out users ( #6427 ) [deploy]
...
* Restore featured story on timeframe pages for logged out users
* Handle arrays and empty collections when finding featured article
2020-03-04 08:01:24 -06:00
Ben Halpern
1dc1723709
Add field test gem to establish a/b testing ( #6283 ) [deploy]
...
* Initial field test spec work
* Clean up specs
* Fix codeclimage
* Cleanups
* Update names
* Rename and remove need to pass logged in status
* Leadup to prod: two experiments
* Move test logic to controller and add tests
Co-authored-by: Josh Puetz <josh@grorichpuetz.com>
2020-03-03 10:21:29 -05:00
Josh Puetz
4cb60958dd
Add page and article limit options ( #6349 ) [deploy]
2020-02-28 06:45:09 -06:00
Josh Puetz
df98591d6d
Fix flapping test ( #6346 ) [deploy]
2020-02-27 14:44:04 -06:00
Josh Puetz
47ec81cf14
Implement home page feed article ranking in Ruby ( #6320 ) [deploy]
...
* WIP - JS feed logic ported to Rails
* Port JS ranking logic to ruby
* PR feedback, sort call from stories vs feeds controller
* Optimize `score_followed_tags`
* Optimize article ranking
* remove unused RankedArticle struct
2020-02-27 12:06:24 -06:00
Mohamed ABDELLANI
da133bcbb5
Require body_markdown Be Present for Articles ( #5982 ) [deploy]
2020-02-27 11:44:17 -05:00
rhymes
bc385ae6d5
Switch decorators to Rails builtin decorations - take 2 ( #6125 ) [deploy]
...
* Revert "Revert "[deploy] Switch decorators from Draper to Rails builtin decorations (#6040 )" (#6122 ) [deploy]"
This reverts commit d438349550
2020-02-19 15:30:53 -05:00
Josh Puetz
35c2800c89
Add json support at stories/index endpoint ( #6070 )
...
* Add json support at stories/index endpoint
* Tweak tests
* Add main image
* Some light refactoring in StoriesController
* Tiny test refactor
* Split feed generation to it's own controller
* Use Jbuilder for article formatting
* Blank lines thanks Rubocop
* Don't cache this response: we want it generated per use each time
* Whoops!
* PR changes and tweaks to Timeframmer constants
* Remove initializer test since arguments aren't required
2020-02-18 15:15:40 -06:00
rhymes
f3c2adfa45
Routine rubocop fixes ( #6138 )
2020-02-18 11:21:42 -05:00
rhymes
d438349550
Revert "[deploy] Switch decorators from Draper to Rails builtin decorations ( #6040 )" ( #6122 ) [deploy]
...
This reverts commit cc53b55a4a
2020-02-17 11:28:32 -05:00
