maverick/docbrown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[deploy] Remove milestone sends (#7313)

Browse source
This commit is contained in:
Ben Halpern 2020-04-15 19:34:10 -04:00 • committed by GitHub
parent 3a22087383
commit 645920c09f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
app/services/articles/analytics_updater.rb
View file

@ -24,8 +24,8 @@ module Articles
qualified_articles.each_slice(15) do |chunk|
chunk.each do |article|
article.update_columns(previous_positive_reactions_count: article.positive_reactions_count)
Notification.send_milestone_notification(type: "Reaction", article_id: article.id)
Notification.send_milestone_notification(type: "View", article_id: article.id)
# Notification.send_milestone_notification(type: "Reaction", article_id: article.id)
# Notification.send_milestone_notification(type: "View", article_id: article.id)
end
end
end

2
spec/services/articles/analytics_updater_spec.rb
View file

@ -33,7 +33,7 @@ RSpec.describe Articles::AnalyticsUpdater, type: :service do
analytics_updater_service.call
end
it "sends send_milestone_notification for Reaction and View" do
xit "sends send_milestone_notification for Reaction and View" do
%w[Reaction View].each do |type|
expect(Notification).to have_received(:send_milestone_notification).with(type: type, article_id: article.id)
end