maverick/docbrown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Refactor:Remove more_experience_level_weight_experiment From Feed Tests (#11340)

Browse source
This commit is contained in:
Molly Struve 2020-11-09 14:59:59 -05:00 • committed by GitHub
parent 1db388510e
commit a0c174fcb7
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 7 additions and 32 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
app/controllers/stories/feeds_controller.rb
View file

@ -5,10 +5,7 @@ module Stories
VARIANTS = {
"more_tag_weight_more_random_experiment" => :more_tag_weight_more_random_experiment,
"more_comments_experiment" => :more_comments_experiment,
"more_experience_level_weight_experiment" => :more_experience_level_weight_experiment,
"more_tag_weight_randomized_at_end_experiment" => :more_tag_weight_randomized_at_end_experiment,
"more_experience_level_weight_randomized_at_end_experiment" =>
:more_experience_level_weight_randomized_at_end_experiment,
"more_comments_randomized_at_end_experiment" => :more_comments_randomized_at_end_experiment,
"more_comments_medium_weight_randomized_at_end_experiment" =>
:more_comments_medium_weight_randomized_at_end_experiment,

24
app/services/articles/feeds/large_forem_experimental.rb
View file

@ -88,14 +88,8 @@ module Articles
stories
end
def more_experience_level_weight_experiment
@experience_level_weight = 3
_featured_story, stories = default_home_feed_and_featured_story(user_signed_in: true)
stories
end
def mix_of_everything_experiment
case rand(9)
case rand(7)
when 0
default_home_feed(user_signed_in: true)
when 1
@ -103,16 +97,12 @@ module Articles
when 2
more_comments_experiment
when 3
more_experience_level_weight_experiment
when 4
more_tag_weight_randomized_at_end_experiment
when 5
more_experience_level_weight_randomized_at_end_experiment
when 6
when 4
more_comments_randomized_at_end_experiment
when 7
when 5
more_comments_medium_weight_randomized_at_end_experiment
when 8
when 6
more_comments_minimal_weight_randomized_at_end_experiment
else
default_home_feed(user_signed_in: true)
@ -131,12 +121,6 @@ module Articles
first_half(results).shuffle + last_half(results)
end
def more_experience_level_weight_randomized_at_end_experiment
@randomness = 0
results = more_experience_level_weight_experiment
first_half(results).shuffle + last_half(results)
end
def more_comments_randomized_at_end_experiment
@randomness = 0
results = more_comments_experiment

10
config/field_test.yml
View file

@ -4,21 +4,17 @@ experiments:
- base
- more_tag_weight_more_random_experiment
- more_comments_experiment
- more_experience_level_weight_experiment
- mix_of_everything_experiment
- more_tag_weight_randomized_at_end_experiment
- more_experience_level_weight_randomized_at_end_experiment
- more_comments_randomized_at_end_experiment
- more_comments_medium_weight_randomized_at_end_experiment
- more_comments_minimal_weight_randomized_at_end_experiment
weights:
- 5
- 5
- 10
- 10
- 10
- 10
- 15
- 10
- 10
- 15
- 20
- 10
- 10

2
spec/services/articles/feeds/large_forem_experimental_spec.rb
View file

@ -3,9 +3,7 @@ require "rails_helper"
NON_DEFAULT_EXPERIMENTS = %i[
more_tag_weight_more_random_experiment
more_comments_experiment
more_experience_level_weight_experiment
more_tag_weight_randomized_at_end_experiment
more_experience_level_weight_randomized_at_end_experiment
more_comments_randomized_at_end_experiment
more_comments_medium_weight_randomized_at_end_experiment
more_comments_minimal_weight_randomized_at_end_experiment