From a0c174fcb78c1d2f2a5383e33bf1a869dbed2417 Mon Sep 17 00:00:00 2001
From: Molly Struve <mollylbs@gmail.com>
Date: Mon, 9 Nov 2020 14:59:59 -0500
Subject: [PATCH] Refactor:Remove more_experience_level_weight_experiment From
 Feed Tests (#11340)

---
 app/controllers/stories/feeds_controller.rb   |  3 ---
 .../feeds/large_forem_experimental.rb         | 24 ++++---------------
 config/field_test.yml                         | 10 +++-----
 .../feeds/large_forem_experimental_spec.rb    |  2 --
 4 files changed, 7 insertions(+), 32 deletions(-)

diff --git a/app/controllers/stories/feeds_controller.rb b/app/controllers/stories/feeds_controller.rb
index 4dd74d411..e83a97d4c 100644
--- a/app/controllers/stories/feeds_controller.rb
+++ b/app/controllers/stories/feeds_controller.rb
@@ -5,10 +5,7 @@ module Stories
     VARIANTS = {
       "more_tag_weight_more_random_experiment" => :more_tag_weight_more_random_experiment,
       "more_comments_experiment" => :more_comments_experiment,
-      "more_experience_level_weight_experiment" => :more_experience_level_weight_experiment,
       "more_tag_weight_randomized_at_end_experiment" => :more_tag_weight_randomized_at_end_experiment,
-      "more_experience_level_weight_randomized_at_end_experiment" =>
-        :more_experience_level_weight_randomized_at_end_experiment,
       "more_comments_randomized_at_end_experiment" => :more_comments_randomized_at_end_experiment,
       "more_comments_medium_weight_randomized_at_end_experiment" =>
         :more_comments_medium_weight_randomized_at_end_experiment,
diff --git a/app/services/articles/feeds/large_forem_experimental.rb b/app/services/articles/feeds/large_forem_experimental.rb
index 51ea17273..946a186bb 100644
--- a/app/services/articles/feeds/large_forem_experimental.rb
+++ b/app/services/articles/feeds/large_forem_experimental.rb
@@ -88,14 +88,8 @@ module Articles
         stories
       end
 
-      def more_experience_level_weight_experiment
-        @experience_level_weight = 3
-        _featured_story, stories = default_home_feed_and_featured_story(user_signed_in: true)
-        stories
-      end
-
       def mix_of_everything_experiment
-        case rand(9)
+        case rand(7)
         when 0
           default_home_feed(user_signed_in: true)
         when 1
@@ -103,16 +97,12 @@ module Articles
         when 2
           more_comments_experiment
         when 3
-          more_experience_level_weight_experiment
-        when 4
           more_tag_weight_randomized_at_end_experiment
-        when 5
-          more_experience_level_weight_randomized_at_end_experiment
-        when 6
+        when 4
           more_comments_randomized_at_end_experiment
-        when 7
+        when 5
           more_comments_medium_weight_randomized_at_end_experiment
-        when 8
+        when 6
           more_comments_minimal_weight_randomized_at_end_experiment
         else
           default_home_feed(user_signed_in: true)
@@ -131,12 +121,6 @@ module Articles
         first_half(results).shuffle + last_half(results)
       end
 
-      def more_experience_level_weight_randomized_at_end_experiment
-        @randomness = 0
-        results = more_experience_level_weight_experiment
-        first_half(results).shuffle + last_half(results)
-      end
-
       def more_comments_randomized_at_end_experiment
         @randomness = 0
         results = more_comments_experiment
diff --git a/config/field_test.yml b/config/field_test.yml
index 6673619e6..d4636f122 100644
--- a/config/field_test.yml
+++ b/config/field_test.yml
@@ -4,21 +4,17 @@ experiments:
       - base
       - more_tag_weight_more_random_experiment
       - more_comments_experiment
-      - more_experience_level_weight_experiment
       - mix_of_everything_experiment
       - more_tag_weight_randomized_at_end_experiment
-      - more_experience_level_weight_randomized_at_end_experiment
       - more_comments_randomized_at_end_experiment
       - more_comments_medium_weight_randomized_at_end_experiment
       - more_comments_minimal_weight_randomized_at_end_experiment
     weights:
-      - 5
-      - 5
-      - 10
-      - 10
-      - 10
+      - 10
+      - 15
       - 10
       - 10
+      - 15
       - 20
       - 10
       - 10
diff --git a/spec/services/articles/feeds/large_forem_experimental_spec.rb b/spec/services/articles/feeds/large_forem_experimental_spec.rb
index 32877ed4d..93bc9bf23 100644
--- a/spec/services/articles/feeds/large_forem_experimental_spec.rb
+++ b/spec/services/articles/feeds/large_forem_experimental_spec.rb
@@ -3,9 +3,7 @@ require "rails_helper"
 NON_DEFAULT_EXPERIMENTS = %i[
   more_tag_weight_more_random_experiment
   more_comments_experiment
-  more_experience_level_weight_experiment
   more_tag_weight_randomized_at_end_experiment
-  more_experience_level_weight_randomized_at_end_experiment
   more_comments_randomized_at_end_experiment
   more_comments_medium_weight_randomized_at_end_experiment
   more_comments_minimal_weight_randomized_at_end_experiment