maverick/docbrown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[deploy] Optimization:Remove more_tag_weight_experiment From Feed Tests (#11089)

Browse source
This commit is contained in:
Molly Struve 2020-10-27 17:36:53 -04:00 • committed by GitHub
parent b0ee1c3905
commit ea156a201d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 16 additions and 28 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
app/controllers/stories/feeds_controller.rb
View file

@ -3,7 +3,6 @@ module Stories
respond_to :json
VARIANTS = {
"more_tag_weight_experiment" => :more_tag_weight_experiment,
"more_tag_weight_more_random_experiment" => :more_tag_weight_more_random_experiment,
"more_comments_experiment" => :more_comments_experiment,
"more_experience_level_weight_experiment" => :more_experience_level_weight_experiment,

28
app/services/articles/feeds/large_forem_experimental.rb
View file

@ -60,13 +60,6 @@ module Articles
stories
end
# Test variation: tags make bigger impact
def more_tag_weight_experiment
@tag_weight = 2
_featured_story, stories = default_home_feed_and_featured_story(user_signed_in: true)
stories
end
def more_tag_weight_more_random_experiment
@tag_weight = 2
@randomness = 7
@ -102,26 +95,24 @@ module Articles
end
def mix_of_everything_experiment
case rand(10)
case rand(9)
when 0
default_home_feed(user_signed_in: true)
when 1
more_tag_weight_experiment
when 2
more_tag_weight_more_random_experiment
when 3
when 2
more_comments_experiment
when 4
when 3
more_experience_level_weight_experiment
when 5
when 4
more_tag_weight_randomized_at_end_experiment
when 6
when 5
more_experience_level_weight_randomized_at_end_experiment
when 7
when 6
more_comments_randomized_at_end_experiment
when 8
when 7
more_comments_medium_weight_randomized_at_end_experiment
when 9
when 8
more_comments_minimal_weight_randomized_at_end_experiment
else
default_home_feed(user_signed_in: true)
@ -135,7 +126,8 @@ module Articles
def more_tag_weight_randomized_at_end_experiment
@randomness = 0
results = more_tag_weight_experiment
@tag_weight = 2
_featured_story, results = default_home_feed_and_featured_story(user_signed_in: true)
first_half(results).shuffle + last_half(results)
end

14
config/field_test.yml
View file

@ -2,7 +2,6 @@ experiments:
user_home_feed: # Home feed collection for logged in user
variants:
- base
- more_tag_weight_experiment
- more_tag_weight_more_random_experiment
- more_comments_experiment
- more_experience_level_weight_experiment
@ -13,17 +12,16 @@ experiments:
- more_comments_medium_weight_randomized_at_end_experiment
- more_comments_minimal_weight_randomized_at_end_experiment
weights:
- 10
- 10
- 10
- 5
- 5
- 10
- 10
- 5
- 25
- 5
- 5
- 10
- 10
- 10
- 20
- 10
- 10
goals:
- user_creates_comment
- user_creates_reaction

1
spec/services/articles/feeds/large_forem_experimental_spec.rb
View file

@ -1,7 +1,6 @@
require "rails_helper"
NON_DEFAULT_EXPERIMENTS = %i[
more_tag_weight_experiment
more_tag_weight_more_random_experiment
more_comments_experiment
more_experience_level_weight_experiment