Vaidehi Joshi
c7a1bd9449
Fix logging for dev and test environments ( #5922 )
...
* Fix logging for dev and test environments
We had some unused code for Timber in our config files for development and test.
However, this was completely clobbering Rails' default behavior of logging out to log/development.log and log/test.log. We should allow for logging in these environments in particular, and since we're not using Timber there, we can just revert to using the Rails default debugging log levels.
* Add Timber logger to specs that explicitly require it
* Restore default Rails.logger in specs using Timber logger
* Explicitly use Rails.logger in OmniauthCallbacksController
We seem to have different logger classes leaking into this controller in tests.
I'm not entirely sure why this is/haven't been able to investigate yet, but I do think we should be using the Rails.logger explicitly until we can figure that out.
2020-02-07 10:15:08 -05:00
Molly Struve
bbeb3fc79d
Ensure user is authenticated before doing onboarding Actions ( #5937 )
...
* ensure user is authenticated before doing onboarding checks
* add specs for authenticating users for onboarding updates
2020-02-07 09:56:29 -05:00
rhymes
6cd46ae2f9
Enable bullet during tests to catch N+1 early (and some cleanups) ( #5930 ) [deploy]
...
* Remove unused methods
* Small refactorings
* Enable bullet in testing mode
* Remove unused eager loading for notes
* Skip bullet on rolify method
* Use .present?
* Fix method name
2020-02-07 09:02:22 -05:00
Molly Struve
a13533c920
Setup Elasticsearch indexes during Deploy and Local App Setup ( #5939 )
...
* setup Elasticsearch indexes during deploy and local app setup
* cleanup previous duplicate sentence
* remove more duplicate docs
2020-02-07 09:01:58 -05:00
Alex
7909d9825d
Remove .first query on notifications ( #5943 )
2020-02-07 08:58:51 -05:00
Sebastien
665f5aac0f
Refactor ProfileImage ( #5803 )
2020-02-07 08:56:16 -05:00
Viraj Chavan
4ca5932dc0
Fixes the link 'Other tools' in docs (on /getting-started/start-app/) ( #5935 )
...
* Fixes the link 'Other tools'
* Update docs/getting-started/start-app.md
Co-Authored-By: rhymes <rhymesete@gmail.com>
Co-authored-by: rhymes <rhymesete@gmail.com>
2020-02-06 19:20:13 -06:00
rhymes
44670e2939
Add various badges to README [skip ci] ( #5931 )
...
* Add some badges to the README
* Add proper Netlify badge
* Add Honeybadger badge
2020-02-06 19:23:18 -05:00
Jacob Herrington
2d3a974803
Include instructions to set Algolia plan ( #5941 )
2020-02-06 17:21:05 -06:00
Josh Puetz
af9c4832c5
Correct startup script and docs ( #5940 )
2020-02-06 17:04:54 -05:00
rhymes
c6e9fd9844
Properly rename Podcasts::BustCacheWorker spec ( #5864 )
2020-02-06 16:53:03 -05:00
Ben Halpern
f3c86c6377
Add mod channel automation to tags ( #5731 ) [deploy]
...
* Add mod channel automation to tags
* Change mod_relations to mod_relations_admin
* Run migration properly
* Make queries consistent and fix test
2020-02-06 16:27:12 -05:00
Frederico Hasegawa
7436e70158
Onboarding JS: refactor function out of repetitive blocks ( #5564 ) [deploy]
2020-02-06 16:00:57 -05:00
Michael Kohl
4872422373
Remove extra whitespace from text inputs in Buffer share ( #5924 ) [deploy]
2020-02-06 15:18:58 -05:00
dependabot-preview[bot]
5aa6e2664c
Bump doorkeeper from 5.2.3 to 5.3.0 ( #5854 ) [deploy]
...
Bumps [doorkeeper](https://github.com/doorkeeper-gem/doorkeeper ) from 5.2.3 to 5.3.0.
- [Release notes](https://github.com/doorkeeper-gem/doorkeeper/releases )
- [Changelog](https://github.com/doorkeeper-gem/doorkeeper/blob/master/CHANGELOG.md )
- [Commits](https://github.com/doorkeeper-gem/doorkeeper/compare/v5.2.3...v.5.3.0 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-02-06 14:31:59 -05:00
Andy Zhao
975a716e5e
Use simpler messaging for ghost account deletion ( #5906 )
...
* Use simpler messaging for ghost account deletion
* Add 'have questions' section
* Use same language for confirm destroy page
2020-02-06 14:31:18 -05:00
Deepu K Sasidharan
5194c009ce
Style: update height of speakerdeck tag to be avoid scaling ( #5818 )
...
* style: update height of speackerdeck tag to be avoid scaling
* style: remove incorrect padding and margin from speackerdeck tag
* add a comment
2020-02-06 14:29:34 -05:00
Nick Taylor
631867b30f
Refactored userData while working on hompage makeover. ( #5916 ) [deploy]
2020-02-06 11:18:52 -08:00
Julianna Tetreault
c9d4dde19c
Adjust cloning example to use SSH rather than HTTPS ( #5802 )
...
* Adjust cloning example to use SSH rather than HTTPS
* Add SSH example alongside HTTPS example when cloning DEV repo
2020-02-06 12:53:12 -05:00
Maykon Menezes
01dc81afa9
Move Podcasts::GetEpisodesJob to Sidekiq ( #5443 ) [deploy]
...
* Refactored Podcast::GetEpisodesJob to sidekiq
* fixing specs
* removing env keys
* Change arguments to Hash
* Update specs and add spec for queue
* Update references for Hash argument
* Add comment to explain parameters of #perform
Co-authored-by: Alex <alexandersmith223@gmail.com>
2020-02-06 09:42:55 -08:00
rhymes
79dcc185cd
Use Node lts/erbium (v12) for Netlify builds ( #5925 )
2020-02-06 12:03:11 -05:00
Alex
231e8d49b2
Add index to notifications to optimize query ( #5921 ) [deploy]
...
- Index notifications on notifiable_id, notifiable_type, and action
2020-02-06 08:49:25 -08:00
Molly Struve
00fefe5865
Add Code To Setup the Elasticsearch Tag Index ( #5919 ) [deploy]
2020-02-06 11:46:11 -05:00
Jacob Herrington
31a1ccc384
Add an internal user interface guide [ci skip] ( #5721 ) [deploy]
2020-02-06 11:34:20 -05:00
rhymes
92f6a9f007
Fix serialization error with video_thumbnail_url ( #5933 )
2020-02-06 10:50:44 -05:00
Molly Struve
a972c8b892
log Notification db table size ( #5920 ) [deploy]
2020-02-06 08:33:04 -05:00
rhymes
fd5643bc9d
Improve API controllers efficiency by selecting only columns needed for serialization ( #5805 ) [deploy]
2020-02-06 07:36:56 -05:00
JCowie
c6434d377b
Update CONTRIBUTING.md ( #5891 )
...
Edited some grammar - Thanks Grammarly!
2020-02-05 19:02:57 -05:00
Nick Taylor
f2b79a94dd
Removed isRequired for whole user entity ( #5902 )
...
This is already done in components that consume these PropTypes
2020-02-05 17:52:53 -05:00
Nick Taylor
261a4f9efa
Add common tag PropTypes ( #5882 )
2020-02-05 17:38:43 -05:00
rhymes
71e1c8d3e6
Upgrade gemoji to support disability emojis ( #5842 )
2020-02-05 17:32:56 -05:00
Nick Taylor
1f3d88c9b3
Created documenation for Common PropTypes. ( #5900 )
2020-02-05 17:22:16 -05:00
Nick Taylor
5ede660601
Preact/React developer tools documentation. ( #5884 )
2020-02-05 17:21:09 -05:00
Michael Kohl
52759c9427
Allow deleting comments if article has already been deleted ( #5889 ) [deploy]
2020-02-05 17:10:19 -05:00
dependabot-preview[bot]
22c643669a
Bump jsdom from 15.2.1 to 16.1.0 ( #5845 ) [deploy]
...
Bumps [jsdom](https://github.com/jsdom/jsdom ) from 15.2.1 to 16.1.0.
- [Release notes](https://github.com/jsdom/jsdom/releases )
- [Changelog](https://github.com/jsdom/jsdom/blob/master/Changelog.md )
- [Commits](https://github.com/jsdom/jsdom/compare/15.2.1...16.1.0 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-02-05 17:05:31 -05:00
rhymes
89852abd82
Use yarn 1.21.1 ( #5786 )
2020-02-05 17:04:06 -05:00
Michael Kohl
424c141539
Remove Foreman gem ( #5821 )
2020-02-05 17:01:04 -05:00
Fernando Valverde
e8523c0749
Adds core team member [ci skip] ( #5881 )
2020-02-05 16:59:21 -05:00
Alex
662d62fe72
Remove Notifications::TagAdjustmentNotificationJob ( #5915 ) [deploy]
2020-02-05 13:33:20 -08:00
Alex
2f4ee09736
Remove UpdateMainImageBackgroundHexJob & spec ( #5911 )
2020-02-05 13:32:58 -08:00
Alex
8a46f4c701
Remove HtmlVariantTrialCreateJob & spec ( #5910 )
2020-02-05 13:32:45 -08:00
Alex
6a100415cc
Move Notifications::TagAdjustmentNotificationJob to Sidekiq ( #5909 ) [deploy]
...
* Create TagAdjustmentNotificationWorker
* Create TagAdjustmentNotificationWorker spec
* Update references and specs for new worker
* Future proof specs
2020-02-05 09:52:21 -08:00
Josh Puetz
41481b532f
Ignore html_safe in erb files ( #5913 )
2020-02-05 12:26:41 -05:00
rhymes
3260270103
Have counters:update_users use a transaction per user and customizable batch size ( #5912 ) [deploy]
2020-02-05 12:26:03 -05:00
Gonzalo Ricco
dd796aaef3
Fix raising validation if followable already exist(race condition) ( #5826 )
...
* Fix raising validation if followable already exist(race condition)
* Change Rails Logger for DataDogStatsClient and remove 'begin' keyword in follow method
Co-authored-by: Gonzalo Ricco <gonzalo.ricco@leniolabs.com>
2020-02-05 12:25:26 -05:00
Maja Komel
28440d1fa1
Return NotFound error if ChatChannelMembership is not found ( #5806 )
2020-02-05 12:24:40 -05:00
Michael Kohl
7270d5ab4c
Move user deletion by moderator to worker ( #5887 ) [deploy]
2020-02-05 08:27:07 -05:00
rhymes
a95877e8ff
Use cleverer patterns to fetch/iterate AR objects when checking presence ( #5833 ) [deploy]
2020-02-05 08:21:20 -05:00
Andy Zhao
be6aaf750c
Add user as reactable ( #5893 )
...
* Add user as reactable
* Make title method public
* Use constants for reactable_type and status
2020-02-04 21:25:56 -06:00
codekatas
bae7ee8b73
Migrate update main image background job to sidekiq ( #5345 ) [deploy]
...
* Add new UpdateMainImageBackgroundHexWorker worker class
This is a port of app/jobs/update_main_image_background_job.rb
that works with Sidekiq instead of DelayedJob.
* Update all references to UpdateMainImageBackgroundHexJob
This updates all references to UpdateMainImageBackgroundHexJob
so they now call UpdateMainImageBackgroundHexWorker, which works
with Sidekiq instead of DelayedJob.
* Move method call to after_commit callback
* Fix article specs with sidekiq helpers
Co-authored-by: Alex <alexandersmith223@gmail.com>
2020-02-04 17:51:09 -08:00
