maverick/docbrown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix raising validation if followable already exist(race condition) (#5826)

Browse source 
* Fix raising validation if followable already exist(race condition)

* Change Rails Logger for DataDogStatsClient and remove 'begin' keyword in follow method

Co-authored-by: Gonzalo Ricco <gonzalo.ricco@leniolabs.com>
This commit is contained in:
Gonzalo Ricco 2020-02-05 14:25:26 -03:00 • committed by GitHub
parent 28440d1fa1
commit dd796aaef3
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
app/controllers/follows_controller.rb
View file

@ -70,8 +70,10 @@ class FollowsController < ApplicationController
def follow(followable, need_notification: false)
user_follow = current_user.follow(followable)
Notification.send_new_follower_notification(user_follow) if need_notification
"followed"
rescue ActiveRecord::RecordInvalid
DataDogStatsClient.increment("users.invalid_follow")
"already followed"
end
def unfollow(followable, need_notification: false)