maverick/docbrown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Return NotFound error if ChatChannelMembership is not found (#5806)

Browse source
This commit is contained in:
Maja Komel 2020-02-05 18:24:40 +01:00 • committed by GitHub
parent 7270d5ab4c
commit 28440d1fa1
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
app/controllers/chat_channel_memberships_controller.rb
View file

@ -2,7 +2,7 @@ class ChatChannelMembershipsController < ApplicationController
after_action :verify_authorized
def find_by_chat_channel_id
@membership = ChatChannelMembership.where(chat_channel_id: params[:chat_channel_id], user_id: current_user.id).first
@membership = ChatChannelMembership.where(chat_channel_id: params[:chat_channel_id], user_id: current_user.id).first!
authorize @membership
render json: @membership.to_json(
only: %i[id status viewable_by chat_channel_id last_opened_at],

8
spec/requests/chat_channel_memberships_spec.rb
View file

@ -88,4 +88,12 @@ RSpec.describe "ChatChannelMemberships", type: :request do
expect(ChatChannelMembership.find(membership.id).status).to eq("left_channel")
end
end
describe "GET /chat_channel_memberships/find_by_chat_channel_id" do
it "renders not_found" do
expect do
get "/chat_channel_memberships/find_by_chat_channel_id", params: {}
end.to raise_error(ActiveRecord::RecordNotFound)
end
end
end