rhymes
ae8a58fec2
[deploy] Decouple GitHub authentication from fetching GitHub issues ( #7660 )
...
* Improve error handling
* Add tests for Github::Client
* Add GithubIssue validation
* Refactor GithubIssue and fix bug with pull requests
* Improve tests
* Fix PR API URL generation
* Improve logic and get rid of the issue fragment
* Fix disappeared avatar
* Improve rendering
* Activate client side caching using Redis
* Remove unnecessary file
* Add RemoveGithubIssues data update script
* Fix comma
* Forgot to disable the approvals verify text
* Apply PR feedback
2020-05-04 16:17:16 -04:00
Alex
b74b035e22
[deploy] Add new VCL snippets for Fastly ( #7654 )
...
* Add new VCL snippets
* Fix specs
* Partial match Fuzz Faster
* Remove PHP
2020-05-04 10:18:19 -04:00
Molly Struve
48c47b5c47
[deploy] Log RateLimit hits to Datadog for Better Reporting ( #7653 )
2020-05-01 16:47:31 -05:00
Alex
7149070bca
[deploy] Create FastlyConfig & refactor params safe list ( #7630 )
...
* Fastly refactor
- Create FastlyConfig
- Create FastlyConfig::Base
- Create FastlyConfig::Snippets
- Move safe_params to its own VCL file
- Rescue unauthorized errors in development
- Add FastlyConfig errors
* Move active version to method
* Update naming option --> config
* Refactor InvalidConfigsFormat msg to Error class
* Refactor active version logic
* Fix log_to_datadog call
* Move get_active_version logic back into method
* Add some specs ¯\_(ツ)_/¯
* Update Fastly rake task
* Remove old Fastly way
* Update docs for Fastly
* Move snippets to config/ & remove old config
* Change update_config to upsert_config
* Change error type to SubclassResponsibility
* Refactor get_updated_files with filter_map
* Refactor update
* Cleanup update_config --> upsert_config
* Fix updater specs
2020-05-01 11:23:48 -04:00
Michael Kohl
46f94b135d
[deploy] Classified listings refactor part 3 ( #7498 )
...
* Ignore category column
* Move view oriented class methods to helper
* Start refactoring ClassifiedListingsToolkit
* Add attr_accessor instead of category
* Replace old category column with association
* More cleanup
* Trigger Travis
* Don't rename associations, category_slug -> category
* Indiana Kohl and the missing newline
* More refactoring and spec fixes
* Add dashboard for classified listing categories
* Remove TODO comment
Co-authored-by: rhymes <rhymesete@gmail.com>
2020-04-30 18:57:01 -04:00
rhymes
7ebd95f193
Upgrade field_test to 0.3.2 ( #7592 )
...
* Make sure tests are testing the right thing
* Upgrade gem field_test to 0.3.2
* Fix things
* Add test
* Fix typo
2020-04-30 18:43:30 -04:00
Molly Struve
385e167f74
Clear Elasticsearch Data Instead of Resetting Entire Index for Specs ( #7602 )
...
* Clear Elasticsearch Data Instead of Resetting Entire Index for Specs
* only reset for specs that are messing with index creation and deletion, recreate indexes before and after those
* add back elasticsearch meta info to specs and update data update specs
* update serializer specs
* update search and rest of specs with new meta data tag
2020-04-30 11:59:10 -04:00
Molly Struve
a4cc606291
[deploy] Remove Elasticsearch from Index Worker Names ( #7594 )
2020-04-29 12:12:29 -05:00
rhymes
8407bf9b4e
[deploy] Authentication refactoring: cleanups ( #7576 )
...
* Use Devise registry to list available providers
* Cleanups following Devise+Omniauth docs
* More cleanups
* Use helpers
* More cleanups
* Oops, forgot to remove these specs
2020-04-29 10:33:30 -04:00
Sai Bhargav
279de9cb21
Fix typos in specs ( #7572 )
2020-04-28 14:32:33 -05:00
rhymes
883eb170de
[deploy] Authentication refactoring: add available and enabled providers ( #7505 )
...
* Add Providers(.available|.enabled|.enabled?)
* Add provider_sidebar partial
* Add providers_signup_modal partial and Providers.sign_in_url
* Use path helpers
* Add providers_nav_menu partial
* Add providers_registration_form partial
* Generalize users/additional_authentication
* Refactor sign_in_path and authentication_path
* Add .official_name and fix specs
* Preload authentication providers correctly and use less Ruby magic
* Put require_dependency in the correct place
2020-04-28 16:16:28 +02:00
Sai Bhargav
2d20d67594
[deploy] Fix listing tags bug ( #7533 )
...
* Fix listing tags bug
* Fix failing specs
* Fix failing specs
* Fix failig spec
* Fix failing specs
* Refactor code
* Fix failing specs
* Support AND/OR queries based on params
* Add tag_boolean to search params
2020-04-28 16:04:09 +02:00
Renan Bona
b93306ecc8
Create Articles builder and refactor articles_controller ( #7381 )
...
* Create Articles entity and refactor articles_controller
* Add safe operator into action new from articles_controller
* Renaming files for better understanding
* Move some logic from the articles controller to articles builder
* Add method normalized text into articles builder
2020-04-28 12:24:51 +02:00
rhymes
2d26318cf9
[deploy] Replace (black|white)list with more inclusive language ( #7459 )
...
* Replace isBlacklisted
* Update fastly.rake task
* More renames
* Rename Faslty config file
* More changes
* Replace isForbiddenFromPreloading with isNotPreloadable
* Skip problematic test
* Re-enable
2020-04-27 18:00:12 +02:00
Molly Struve
527c98fa01
[deploy] remove no longer used index! and check for main_image method in view ( #7526 )
2020-04-27 10:16:49 -05:00
rhymes
f5a6ff32cc
Finalize Slack messengers refactoring ( #7484 )
...
* Remove dead code
* Rename SlackBotPingWorker to Slack::Messengers::Worker
* Remove useless Slack mock
* Fix specs
2020-04-24 21:15:10 +02:00
Fernando Valverde
baac7997c3
[deploy] Send push to Android phones and use Pusher broadcasting ( #6883 )
2020-04-24 13:50:59 -04:00
Molly Struve
4ab202ab0a
[deploy] Execute Reading List searches in Elasticsearch ( #7440 )
...
* Execute Reading List searches in Elasticsearch
* add additional readinglist front tests
2020-04-24 10:30:17 -04:00
Michael Kohl
9df68f3920
Use new classified listing categories ( #7250 )
...
* Add ClassifiedListingCategoryModel
* Add data update script for classified listing categories
* Refactor and fix specs
* Resolve conflict
* Incorporate PR feedback
2020-04-23 10:06:58 +07:00
Molly Struve
73120a67c9
[deploy] Bug Fix: Use strings with colons for all Datadog tags ( #7442 )
2020-04-22 12:24:57 -05:00
Vaidehi Joshi
638fd8f1ad
[deploy] Wrap user/identity coupled logic in a transaction ( #7368 )
...
* Wrap user/identity coupled logic in a transaction
Creating a user and then setting an identiy should occur as an all-or-nothing step.
Wrapping this in an ActiveRecord::Transaction ensures that we don't update an identity
unless we succesfully create/update the user first in the same database transaction.
* Allow errors from authenticator service to bubble up
* Address some issues with logic in ActiveRecord::Base.transaction
* Pull out calls to DataDog from transaction.
* Add additional DataDog call in case something goes wrong in the transaction.
* Rename some methods, add some specs.
* Re-raise errors after notifying DataDog
* Add error message to DataDog tags in Authenticator
2020-04-22 11:05:46 -04:00
Molly Struve
556bb565bf
[deploy] allow option to search by all tags in Elasticsearch for reactions ( #7425 )
2020-04-21 18:30:04 -04:00
Molly Struve
13e8ea1f64
Ensure records are updated properly after a user merge ( #7416 )
2020-04-21 14:17:11 -04:00
Molly Struve
a813598998
[deploy] Ensure Readinglist Reactions are Removed from Elasticsearch when Deleted ( #7402 )
2020-04-21 08:44:15 -05:00
Molly Struve
61b6f8ea3e
[deploy] record identity creation metrics ( #7366 )
2020-04-17 13:15:03 -05:00
Molly Struve
3832e9356d
rescue Addressable::URI::InvalidURIError and mark podcast ep unreachable ( #7343 )
2020-04-17 13:11:08 -05:00
rhymes
a2893056b6
Routine rubocop fixes ( #7356 )
...
* rubocop -a
* Fix stuff
* rubocop -a again
* autocorrect
2020-04-17 15:48:39 +02:00
Molly Struve
2d40174a92
implement backend search functionality for readinglist Reactions ( #7308 )
2020-04-17 08:37:22 -05:00
Alex
cc6249beff
[deploy] Update whitelisted params on Fastly on deployments ( #7279 )
...
* Add Fastly whitelisted params
* Create FastlyVCL::WhitelistedParams.update service
* Add specs
* Create rake task to call new service
* Add rake task to setup script
* Add documentatoin
* Move sort inside params_to_array method
* Rename VCL_REGEX to VCL_DELIMITER
* Add PR URL to docs
* Move snippet name to SNIPPET_NAME constant
* Refactor setting content
* Rename params_to_array to params_to_sorted_array
* Change guard and log success on update
- Return early if params are equal
- Log success message to Rails.logger on update
- Log params diff to Datadog
* Return true explicitly
* Move rake task execution from to release-tasks
* Remove unnecessary environment guard in task
* Remove duplicate code param
* Refactor string from build_content
* Remove reliance on sort
* Reorder logging to implicitly return true
* Update docs to reference release-script.sh
* Update docs
* Update whitelisted params
* Fix params_updated? bug and add more specs
* Remove duplicate param...oopsie!
2020-04-16 15:11:57 -04:00
Molly Struve
8f6fb35404
flaky spec fix: compare org updated_at properly ( #7336 )
2020-04-16 11:37:07 -05:00
Ben Halpern
645920c09f
[deploy] Remove milestone sends ( #7313 )
2020-04-15 19:34:10 -04:00
Molly Struve
223703f0d3
[deploy] Update URLSearchParams to handle arrays correctly for Rails ( #7300 )
2020-04-15 14:58:18 -05:00
rhymes
f5166e28a8
Nullify audit logs on users delete ( #7275 )
...
* Nullify audit logs on users delete
* Fix specs
* Set user as optional and test moderator audit log page
* Fix spec
2020-04-15 18:26:16 +02:00
rhymes
d6e47a03c7
[deploy] Authentication refactoring - step 1 ( #7259 )
...
* Add Authentication providers
* Making strides on refactoring
* New usr from Twitter
* Existing Twitter user
* Existing user Github
* Test skip_confirmation!
* Refactor a bit and add simplecov groups
* Test user already logged in
* Rename to Authentication::Authenticator
* Refactor to a common class
* Add existing user test for twitter login
* Refactor global handler
* Fix spec and comment Twitter provider
* Update comments and strategy TODO
* Move providers loading code to Authentication::Providers
* add SubclassResponsibility error
* Use delegation
2020-04-15 12:13:10 -04:00
Molly Struve
b10668a454
[deploy] Create a Bulk Index Elasticsearch Worker ( #7265 )
2020-04-15 09:08:59 -05:00
Michael Kohl
c8845e647a
[deploy] Remove Google Analytics page counts ( #6969 )
...
* Remove Google Analytics page counts
* Update spec
Co-authored-by: rhymes <rhymesete@gmail.com>
Co-authored-by: Ben Halpern <bendhalpern@gmail.com>
2020-04-14 10:44:05 -04:00
Molly Struve
07050baa28
[deploy] Refactor search_documents Method Into Search Base.rb Class ( #7260 )
2020-04-14 08:39:50 -05:00
Molly Struve
91972dd2c4
ensure that when Tag and ActsAsTaggableOn::Tag are updated their respective related docs are as well ( #7218 )
2020-04-14 08:38:09 -05:00
rhymes
34848a4209
Upgrade Rubocop to 0.81 ( #7219 )
...
* Upgrade rubocop to 0.81.0
* Reordered rubocop file and updated it
* Regenerate todo
* Correct some things
* Fix specs
2020-04-11 10:10:04 +02:00
Molly Struve
10b094b4b6
[deploy] refactor data syncing methods to use a base class and take a single argument ( #7204 )
2020-04-10 11:11:35 -05:00
Molly Struve
26acabce51
[deploy] add custom sorting and scoring for feed content ( #7199 )
2020-04-09 18:30:27 -04:00
Molly Struve
578d09a54e
[deploy] return cloudinary url to ensure videos are viewable in feeds ( #7157 )
2020-04-08 15:47:47 -04:00
Molly Struve
2048bf00f7
[deploy] keep articles updated in Elasticsearch when organization is updated ( #7154 )
2020-04-08 10:49:06 -05:00
Molly Struve
bca0573a14
rescue invalid URL errors and mark as unreachable for podcast episodes ( #7137 )
2020-04-07 12:32:04 -04:00
Molly Struve
b1ebc32e45
hook up data syncing for articles and switch to using call ( #7115 )
2020-04-07 09:39:23 +02:00
Molly Struve
6f95744698
Move create PodcastEpisode callbacks to create Podcast Service ( #7077 ) [deploy]
...
* move create podcast callbacks to create podcast service
* add indexing spec to creator
2020-04-06 12:41:00 +02:00
Vaidehi Joshi
3f8961a299
Remove onboarding type broadcasts ( #7067 ) [deploy]
...
Also clean up some pending comments.
2020-04-03 13:11:49 -07:00
Molly Struve
5f322210ce
[deploy] Separate counts by class_name from Feed Content index ( #7069 )
2020-04-03 13:36:13 -05:00
Molly Struve
2ef17099ed
By Default Search for Users that are not Banned ( #7052 )
...
Co-authored-by: Mac Siri <krairit.siri@gmail.com>
2020-04-03 10:03:24 -05:00
rhymes
f2b0be2043
Add Slack messengers: part 2 ( #6916 )
...
* Add Slack::Messengers::ArticlePublished
* Add Slack::Messengers::ReactionVomit
* Add Slack::Messengers::CommentUserWarned
* Add missing URL helpers
* Add Slack::Messengers::ArticleFetchedFeed
* Remove callback condition
* Build, don't create
2020-04-03 17:00:06 +02:00
