maverick/docbrown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

rescue Addressable::URI::InvalidURIError and mark podcast ep unreachable (#7343)

Browse source
This commit is contained in:
Molly Struve 2020-04-17 13:11:08 -05:00 • committed by GitHub
parent 1b93666b3b
commit 3832e9356d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 10 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
app/services/podcasts/get_media_url.rb
View file

@ -35,7 +35,7 @@ module Podcasts
def url_reachable?(url)
url = Addressable::URI.parse(url).normalize.to_s
HTTParty.head(url).code == 200
rescue Net::OpenTimeout, SystemCallError, URI::InvalidURIError
rescue Net::OpenTimeout, SystemCallError, URI::InvalidURIError, Addressable::URI::InvalidURIError
false
end
end

9
spec/services/podcasts/get_media_url_spec.rb
View file

@ -74,4 +74,13 @@ RSpec.describe Podcasts::GetMediaUrl, type: :service do
expect(result.reachable).to be false
expect(result.url).to eq(http_url)
end
it "marks unreachable with addressable invalid url exception" do
allow(HTTParty).to receive(:head).with(https_url).and_raise(Addressable::URI::InvalidURIError)
allow(HTTParty).to receive(:head).with(http_url).and_raise(Addressable::URI::InvalidURIError)
result = described_class.call(http_url)
expect(result.https).to be false
expect(result.reachable).to be false
expect(result.url).to eq(http_url)
end
end