Commit graph

5218 commits

Author SHA1 Message Date
rhymes
ae8a58fec2
[deploy] Decouple GitHub authentication from fetching GitHub issues (#7660)
* Improve error handling

* Add tests for Github::Client

* Add GithubIssue validation

* Refactor GithubIssue and fix bug with pull requests

* Improve tests

* Fix PR API URL generation

* Improve logic and get rid of the issue fragment

* Fix disappeared avatar

* Improve rendering

* Activate client side caching using Redis

* Remove unnecessary file

* Add RemoveGithubIssues data update script

* Fix comma

* Forgot to disable the approvals verify text

* Apply PR feedback
2020-05-04 16:17:16 -04:00
Mac Siri
f75bcf8673
Set Jest's timezone to UTC (#7670) 2020-05-04 14:10:46 -04:00
Molly Struve
930ccdccf5
[deploy] Refactor Tracking Rate Limits for Actions (#7668) 2020-05-04 13:05:53 -05:00
rhymes
fc1cf71a3d
Fix showing "Remove OAuth" in settings with disabled identities (#7665) 2020-05-04 20:00:43 +02:00
Nick Taylor
ddf6a06bc2
Fixed a typo in a a folder name. (#7671) 2020-05-04 13:53:43 -04:00
Alex
edf0e62e96
[deploy] Remove FASTLY_SAFE_PARAMS_SNIPPET_NAME env var (#7669) 2020-05-04 13:13:05 -04:00
rhymes
5a94cd9235
[deploy] Upgrade Doorkeeper to 5.3.2 (#7667) 2020-05-04 16:57:54 +02:00
Alex
b74b035e22
[deploy] Add new VCL snippets for Fastly (#7654)
* Add new VCL snippets

* Fix specs

* Partial match Fuzz Faster

* Remove PHP
2020-05-04 10:18:19 -04:00
ludwiczakpawel
2ad5403045
Boxes coloring fix (#7656)
* boxes fix

* fix
2020-05-04 08:42:11 -04:00
Ben Halpern
b63bd98c2b
Clear sponsor cache more frequently (#7662) 2020-05-03 15:18:00 -04:00
Michael Kohl
fcd0639d2a
[deploy] Remove column and minor cleanup (#7642)
* Remove column and minor cleanup

* More cleanup

* Fix spec

* Remove category from select

* Wake up Travis

* No space for you
2020-05-03 11:52:03 -04:00
Molly Struve
48c47b5c47
[deploy] Log RateLimit hits to Datadog for Better Reporting (#7653) 2020-05-01 16:47:31 -05:00
Vaidehi Joshi
692243ab50
Allow admins to configure default users to follow during onboarding (#7637) [deploy]
* Allow admins to suggest default users to follow during onboarding

Allows the onboarding "follow users" slide to be configured by admins.
Closes https://github.com/thepracticaldev/dev.to/issues/7106.

* Remove redundant safety checks, refactor specs

* Add explicit note about how suggested users are used in onboarding

* Some configs_controller cleanup and fix copypasta in configs/show template

* Fetch SiteConfig.suggested_users via before_action

* Use presence instead of empty?
2020-05-01 14:03:48 -07:00
Fernando Valverde
8f567524f7
Adds an extra check for Android Native app for playing podcasts (#7651) 2020-05-01 15:04:26 -04:00
Molly Struve
ba0ebbafa8
[deploy] RateLimit Refactor: Consolidate Logic for Checking a Limit and Raising an Error (#7636) 2020-05-01 13:31:44 -05:00
rhymes
e6f9841bca
Update Windows 10 installation docs (#7647) 2020-05-01 13:49:44 -04:00
Ben Halpern
195da03edf
[deploy] Add proper 301 status to username change redirects (#7650) 2020-05-01 13:36:29 -04:00
Julianna Tetreault
0ee7b97b44
Remove Unnecessary .downcases From the Stories::Controller (#7646)
* Remove unnecessary .downcases from methods in Stories::Controller
  * Removes .downcase from methods using params[:username]
  * Removes .downcase from handle_user_or_organization_or_podcast_or_page_index
  * Removes .downcase from handle_user_index

* Add shared_examples for lowercase routing to stories_index_spec.rb

* Replace create with build in stories_index_spec.rb
2020-05-01 11:24:22 -06:00
Fernando Valverde
96c27ecdc6
[deploy] Android native audio feature support (#7554)
* First commit Android Bridge for Podcasts

* Working Android Bridge controls

* Adds Android metadata message & cleans up a couple longs functions

* Brings back use strict

* Cleans up a bit the conditional for either ios/android native players
2020-05-01 13:09:05 -04:00
Mac Siri
c7e3971736
Remove ClassifiedListing.categories_available.keys in seed (#7648) 2020-05-01 13:01:49 -04:00
dependabot-preview[bot]
db7aa197fa
Bump @babel/core from 7.9.0 to 7.9.6 (#7612)
Bumps [@babel/core](https://github.com/babel/babel) from 7.9.0 to 7.9.6.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/master/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/compare/v7.9.0...v7.9.6)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-05-01 11:52:08 -04:00
Mac Siri
a9cead5c91
Update bin/setup's db setup logic (#7644)
* Update bin/setup's db setup logic

* Remove duplicate seeds
2020-05-01 11:32:54 -04:00
Alex
7149070bca
[deploy] Create FastlyConfig & refactor params safe list (#7630)
* Fastly refactor

- Create FastlyConfig
- Create FastlyConfig::Base
- Create FastlyConfig::Snippets
- Move safe_params to its own VCL file
- Rescue unauthorized errors in development
- Add FastlyConfig errors

* Move active version to method

* Update naming option --> config

* Refactor InvalidConfigsFormat msg to Error class

* Refactor active version logic

* Fix log_to_datadog call

* Move get_active_version logic back into method

* Add some specs ¯\_(ツ)_/¯

* Update Fastly rake task

* Remove old Fastly way

* Update docs for Fastly

* Move snippets to config/ & remove old config

* Change update_config to upsert_config

* Change error type to SubclassResponsibility

* Refactor get_updated_files with filter_map

* Refactor update

* Cleanup update_config --> upsert_config

* Fix updater specs
2020-05-01 11:23:48 -04:00
Alex
5060652939
Validate images are files (#7639)
* Validate images are files

* Skip image validation if there aren't any images
2020-05-01 10:39:20 -04:00
ludwiczakpawel
7e88ad1a7d
Selects & Ghost Fields (#7607)
* ghost forms

* syntax error

* typo
2020-05-01 14:14:14 +02:00
Anna Buianova
c734457a44
Fix finding existing podcast episode by website url (#7608) 2020-04-30 19:08:17 -04:00
dependabot-preview[bot]
671073bc66
Bump ibm-openapi-validator from 0.26.1 to 0.27.0 (#7614)
Bumps [ibm-openapi-validator](https://github.com/IBM/openapi-validator) from 0.26.1 to 0.27.0.
- [Release notes](https://github.com/IBM/openapi-validator/releases)
- [Changelog](https://github.com/IBM/openapi-validator/blob/master/CHANGELOG.md)
- [Commits](https://github.com/IBM/openapi-validator/compare/v0.26.1...v0.27.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-04-30 19:06:54 -04:00
Molly Struve
2ba6c98e81
Limit 1 message every second for single user (#7631)
* limit 1 message every second for  single user

* increase message limit to 2 in a second
2020-04-30 19:06:19 -04:00
Michael Kohl
46f94b135d
[deploy] Classified listings refactor part 3 (#7498)
* Ignore category column

* Move view oriented class methods to helper

* Start refactoring ClassifiedListingsToolkit

* Add attr_accessor instead of category

* Replace old category column with association

* More cleanup

* Trigger Travis

* Don't rename associations, category_slug -> category

* Indiana Kohl and the missing newline

* More refactoring and spec fixes

* Add dashboard for classified listing categories

* Remove TODO comment

Co-authored-by: rhymes <rhymesete@gmail.com>
2020-04-30 18:57:01 -04:00
rhymes
7ebd95f193
Upgrade field_test to 0.3.2 (#7592)
* Make sure tests are testing the right thing

* Upgrade gem field_test to 0.3.2

* Fix things

* Add test

* Fix typo
2020-04-30 18:43:30 -04:00
dependabot-preview[bot]
176293bc96
Bump style-loader from 1.1.4 to 1.2.1 (#7616)
Bumps [style-loader](https://github.com/webpack-contrib/style-loader) from 1.1.4 to 1.2.1.
- [Release notes](https://github.com/webpack-contrib/style-loader/releases)
- [Changelog](https://github.com/webpack-contrib/style-loader/blob/master/CHANGELOG.md)
- [Commits](https://github.com/webpack-contrib/style-loader/compare/v1.1.4...v1.2.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-04-30 18:03:09 -04:00
dependabot-preview[bot]
d9467858be
Bump lint-staged from 10.1.7 to 10.2.1 (#7613) 2020-04-30 17:22:53 -04:00
dependabot-preview[bot]
aed164caa1
Bump intersection-observer from 0.9.0 to 0.10.0 (#7610) 2020-04-30 17:22:06 -04:00
dependabot-preview[bot]
23b4690596
Bump @babel/preset-env from 7.9.5 to 7.9.6 (#7617) 2020-04-30 17:20:45 -04:00
dependabot-preview[bot]
c8cc5df172
Bump jest from 25.4.0 to 25.5.2 (#7618) 2020-04-30 17:19:44 -04:00
dependabot-preview[bot]
7c3c2c280a
[deploy] Bump css-loader from 3.5.2 to 3.5.3 (#7611)
Bumps [css-loader](https://github.com/webpack-contrib/css-loader) from 3.5.2 to 3.5.3.
- [Release notes](https://github.com/webpack-contrib/css-loader/releases)
- [Changelog](https://github.com/webpack-contrib/css-loader/blob/master/CHANGELOG.md)
- [Commits](https://github.com/webpack-contrib/css-loader/compare/v3.5.2...v3.5.3)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-04-30 15:52:32 -05:00
Molly Struve
2e67cc252e
return usable error message when chat creation fails (#7629) 2020-04-30 15:49:09 -05:00
Molly Struve
9ca423fed8
Refactor Setting Internal Configurable Rate Limits (#7635)
Co-authored-by: Vaidehi Joshi <vaidehi.sj@gmail.com>
2020-04-30 15:48:42 -05:00
Alex
c222f78760
[deploy] Turn off broken article show spec - date time (#7634)
* Turn off broken spec

* Restore original spec
2020-04-30 15:17:07 -04:00
Vaidehi Joshi
8e555201d7
Extract onboarding + mascot configs (#7632) [deploy]
* Move onboarding-related configs into new onboarding section

* Extract mascot-related configs into a mascot section

* Update order of fields in SiteConfig model to match order in view

* Update ordering of specs for onboarding/mascot config changes
2020-04-30 11:54:23 -07:00
Alex
01d4972962
[deploy] Temporary article show date time spec fix (#7633) 2020-04-30 14:32:30 -04:00
dependabot-preview[bot]
b08d235bfe
[deploy] Bump twilio-ruby from 5.33.1 to 5.34.0 (#7623)
Bumps [twilio-ruby](https://github.com/twilio/twilio-ruby) from 5.33.1 to 5.34.0.
- [Release notes](https://github.com/twilio/twilio-ruby/releases)
- [Changelog](https://github.com/twilio/twilio-ruby/blob/master/CHANGES.md)
- [Commits](https://github.com/twilio/twilio-ruby/compare/5.33.1...5.34.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-04-30 12:20:23 -05:00
dependabot-preview[bot]
94eaf4212b
Bump factory_bot_rails from 5.1.1 to 5.2.0 (#7619)
Bumps [factory_bot_rails](https://github.com/thoughtbot/factory_bot_rails) from 5.1.1 to 5.2.0.
- [Release notes](https://github.com/thoughtbot/factory_bot_rails/releases)
- [Changelog](https://github.com/thoughtbot/factory_bot_rails/blob/v5.2.0/NEWS.md)
- [Commits](https://github.com/thoughtbot/factory_bot_rails/compare/v5.1.1...v5.2.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-04-30 12:20:00 -05:00
dependabot-preview[bot]
a6fb5c927c
Bump stripe from 5.18.0 to 5.21.0 (#7625)
Bumps [stripe](https://github.com/stripe/stripe-ruby) from 5.18.0 to 5.21.0.
- [Release notes](https://github.com/stripe/stripe-ruby/releases)
- [Changelog](https://github.com/stripe/stripe-ruby/blob/master/CHANGELOG.md)
- [Commits](https://github.com/stripe/stripe-ruby/compare/v5.18.0...v5.21.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-04-30 12:19:33 -05:00
dependabot-preview[bot]
07972b8273
Bump amazing_print from 1.0.0 to 1.1.0 (#7624)
Bumps [amazing_print](https://github.com/amazing-print/amazing_print) from 1.0.0 to 1.1.0.
- [Release notes](https://github.com/amazing-print/amazing_print/releases)
- [Changelog](https://github.com/amazing-print/amazing_print/blob/master/CHANGELOG.md)
- [Commits](https://github.com/amazing-print/amazing_print/compare/v1.0.0...v1.1.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-04-30 12:19:13 -05:00
Molly Struve
385e167f74
Clear Elasticsearch Data Instead of Resetting Entire Index for Specs (#7602)
* Clear Elasticsearch Data Instead of Resetting Entire Index for Specs

* only reset for specs that are messing with index creation and deletion, recreate indexes before and after those

* add back elasticsearch meta info to specs and update data update specs

* update serializer specs

* update search and rest of specs with new meta data tag
2020-04-30 11:59:10 -04:00
Ben Halpern
0e1e4f89e4
[deploy] Fix jumping content in obboarding (#7601) 2020-04-30 11:57:00 -04:00
Molly Struve
74e75b4067
[deploy] Rate Limit Organization Creation (#7595) 2020-04-30 10:55:37 -05:00
Molly Struve
1d6c1fe445
load article page AFTER updating the article (#7627) 2020-04-30 10:54:55 -05:00
dependabot-preview[bot]
13d3f3292b
Bump emoji_regex from 2.0.0 to 3.0.0 (#7621)
Bumps [emoji_regex](https://github.com/ticky/ruby-emoji-regex) from 2.0.0 to 3.0.0.
- [Release notes](https://github.com/ticky/ruby-emoji-regex/releases)
- [Commits](https://github.com/ticky/ruby-emoji-regex/compare/v2.0.0...v3.0.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-04-30 10:51:33 -05:00