rhymes
ae8a58fec2
[deploy] Decouple GitHub authentication from fetching GitHub issues ( #7660 )
...
* Improve error handling
* Add tests for Github::Client
* Add GithubIssue validation
* Refactor GithubIssue and fix bug with pull requests
* Improve tests
* Fix PR API URL generation
* Improve logic and get rid of the issue fragment
* Fix disappeared avatar
* Improve rendering
* Activate client side caching using Redis
* Remove unnecessary file
* Add RemoveGithubIssues data update script
* Fix comma
* Forgot to disable the approvals verify text
* Apply PR feedback
2020-05-04 16:17:16 -04:00
Molly Struve
930ccdccf5
[deploy] Refactor Tracking Rate Limits for Actions ( #7668 )
2020-05-04 13:05:53 -05:00
Molly Struve
48c47b5c47
[deploy] Log RateLimit hits to Datadog for Better Reporting ( #7653 )
2020-05-01 16:47:31 -05:00
Molly Struve
ba0ebbafa8
[deploy] RateLimit Refactor: Consolidate Logic for Checking a Limit and Raising an Error ( #7636 )
2020-05-01 13:31:44 -05:00
Alex
7149070bca
[deploy] Create FastlyConfig & refactor params safe list ( #7630 )
...
* Fastly refactor
- Create FastlyConfig
- Create FastlyConfig::Base
- Create FastlyConfig::Snippets
- Move safe_params to its own VCL file
- Rescue unauthorized errors in development
- Add FastlyConfig errors
* Move active version to method
* Update naming option --> config
* Refactor InvalidConfigsFormat msg to Error class
* Refactor active version logic
* Fix log_to_datadog call
* Move get_active_version logic back into method
* Add some specs ¯\_(ツ)_/¯
* Update Fastly rake task
* Remove old Fastly way
* Update docs for Fastly
* Move snippets to config/ & remove old config
* Change update_config to upsert_config
* Change error type to SubclassResponsibility
* Refactor get_updated_files with filter_map
* Refactor update
* Cleanup update_config --> upsert_config
* Fix updater specs
2020-05-01 11:23:48 -04:00
rhymes
c7c498834f
[deploy] Authentication refactoring: generalize account settings ( #7597 )
...
* Rename remove_association to remove_identity and future proof its tests
* Use the signin_path everywhere
* Generalize account settings
* Use delegation
2020-04-30 17:29:53 +02:00
Molly Struve
a4cc606291
[deploy] Remove Elasticsearch from Index Worker Names ( #7594 )
2020-04-29 12:12:29 -05:00
rhymes
8407bf9b4e
[deploy] Authentication refactoring: cleanups ( #7576 )
...
* Use Devise registry to list available providers
* Cleanups following Devise+Omniauth docs
* More cleanups
* Use helpers
* More cleanups
* Oops, forgot to remove these specs
2020-04-29 10:33:30 -04:00
Molly Struve
ee373fa6c0
[deploy] Remove Algolia from Article Model ( #7540 )
2020-04-28 09:55:48 -05:00
rhymes
883eb170de
[deploy] Authentication refactoring: add available and enabled providers ( #7505 )
...
* Add Providers(.available|.enabled|.enabled?)
* Add provider_sidebar partial
* Add providers_signup_modal partial and Providers.sign_in_url
* Use path helpers
* Add providers_nav_menu partial
* Add providers_registration_form partial
* Generalize users/additional_authentication
* Refactor sign_in_path and authentication_path
* Add .official_name and fix specs
* Preload authentication providers correctly and use less Ruby magic
* Put require_dependency in the correct place
2020-04-28 16:16:28 +02:00
Sai Bhargav
2d20d67594
[deploy] Fix listing tags bug ( #7533 )
...
* Fix listing tags bug
* Fix failing specs
* Fix failing specs
* Fix failig spec
* Fix failing specs
* Refactor code
* Fix failing specs
* Support AND/OR queries based on params
* Add tag_boolean to search params
2020-04-28 16:04:09 +02:00
Renan Bona
b93306ecc8
Create Articles builder and refactor articles_controller ( #7381 )
...
* Create Articles entity and refactor articles_controller
* Add safe operator into action new from articles_controller
* Renaming files for better understanding
* Move some logic from the articles controller to articles builder
* Add method normalized text into articles builder
2020-04-28 12:24:51 +02:00
Rafi
bdcfba7d70
[deploy] Saving youtube url ( #7516 )
...
* Saving youtube url
* Fixing description in the spec
* Optimizing youtube logo svg
* Fixing indentation of form
2020-04-27 14:14:07 -04:00
rhymes
2d26318cf9
[deploy] Replace (black|white)list with more inclusive language ( #7459 )
...
* Replace isBlacklisted
* Update fastly.rake task
* More renames
* Rename Faslty config file
* More changes
* Replace isForbiddenFromPreloading with isNotPreloadable
* Skip problematic test
* Re-enable
2020-04-27 18:00:12 +02:00
Molly Struve
527c98fa01
[deploy] remove no longer used index! and check for main_image method in view ( #7526 )
2020-04-27 10:16:49 -05:00
Molly Struve
a7e664fc9c
[deploy] Remove Algolia from User Model ( #7454 )
...
* Remove Algolia from User Model
* check banned on self for user
* fine have your redundant method
* remove a couple more unnecessary specs
2020-04-24 18:39:36 -04:00
rhymes
f5a6ff32cc
Finalize Slack messengers refactoring ( #7484 )
...
* Remove dead code
* Rename SlackBotPingWorker to Slack::Messengers::Worker
* Remove useless Slack mock
* Fix specs
2020-04-24 21:15:10 +02:00
Fernando Valverde
baac7997c3
[deploy] Send push to Android phones and use Pusher broadcasting ( #6883 )
2020-04-24 13:50:59 -04:00
rhymes
0186fd9aee
Add Retry-After for API rate limit errors and document limits in API spec ( #7444 )
...
* Add correct rate limit exception to Articles::Updater
* Send Retry-After with HTTP 429 back to the client
* Update API specs for error 429
* Test build
* Fix spec
* Add retry after to ImageUploadsController and fix specs
* Generalize a bit
2020-04-24 17:35:28 +02:00
Molly Struve
4ab202ab0a
[deploy] Execute Reading List searches in Elasticsearch ( #7440 )
...
* Execute Reading List searches in Elasticsearch
* add additional readinglist front tests
2020-04-24 10:30:17 -04:00
Molly Struve
73120a67c9
[deploy] Bug Fix: Use strings with colons for all Datadog tags ( #7442 )
2020-04-22 12:24:57 -05:00
Alex
397734b29c
Generalize Fastly rake task ( #7349 )
...
* Generalize Fastly rake task
- Update Rubocop to disable DescribeClass on rake task specs
* Change default Fastly ENV vars to ""
* Move snippet name to ENV
* Update ENV to FASTLY_WHITELIST_PARAMS_SNIPPET_NAME
* Add FASTLY_WHITELIST_PARAMS_SNIPPET_NAME to the docs
* Update docs
* Quick refactor
2020-04-22 11:49:54 -04:00
Vaidehi Joshi
638fd8f1ad
[deploy] Wrap user/identity coupled logic in a transaction ( #7368 )
...
* Wrap user/identity coupled logic in a transaction
Creating a user and then setting an identiy should occur as an all-or-nothing step.
Wrapping this in an ActiveRecord::Transaction ensures that we don't update an identity
unless we succesfully create/update the user first in the same database transaction.
* Allow errors from authenticator service to bubble up
* Address some issues with logic in ActiveRecord::Base.transaction
* Pull out calls to DataDog from transaction.
* Add additional DataDog call in case something goes wrong in the transaction.
* Rename some methods, add some specs.
* Re-raise errors after notifying DataDog
* Add error message to DataDog tags in Authenticator
2020-04-22 11:05:46 -04:00
Molly Struve
de88a08ebd
[deploy] handle rate limit errors gracefully ( #7422 )
2020-04-22 08:55:26 -05:00
Molly Struve
556bb565bf
[deploy] allow option to search by all tags in Elasticsearch for reactions ( #7425 )
2020-04-21 18:30:04 -04:00
Molly Struve
13e8ea1f64
Ensure records are updated properly after a user merge ( #7416 )
2020-04-21 14:17:11 -04:00
Molly Struve
a813598998
[deploy] Ensure Readinglist Reactions are Removed from Elasticsearch when Deleted ( #7402 )
2020-04-21 08:44:15 -05:00
Molly Struve
4f374acbc5
[deploy] filter Elasticsearch by org id properly ( #7389 )
2020-04-20 10:01:30 -05:00
Ben Halpern
3d4944ebae
[deploy] Add video duration to search results ( #7377 )
2020-04-18 15:16:38 -04:00
Ben Halpern
a0504f5f77
[deploy] Include organization in feed_content results ( #7374 )
2020-04-18 13:07:59 -04:00
Molly Struve
61b6f8ea3e
[deploy] record identity creation metrics ( #7366 )
2020-04-17 13:15:03 -05:00
Molly Struve
3832e9356d
rescue Addressable::URI::InvalidURIError and mark podcast ep unreachable ( #7343 )
2020-04-17 13:11:08 -05:00
rhymes
1b93666b3b
[deploy] Add user_id presence validation for Identity ( #7365 )
...
* Add user_id presence validation for Identity
* Remove duplicated validation
* Save user within build_user
* Fix typo
* Fix spec with in memory user
2020-04-17 20:02:26 +02:00
Molly Struve
2c99424205
[deploy] Execute Feed Searches through Elasticsearch (Round 2) ( #7231 )
2020-04-17 08:38:07 -05:00
Molly Struve
2d40174a92
implement backend search functionality for readinglist Reactions ( #7308 )
2020-04-17 08:37:22 -05:00
Molly Struve
7be90d1b4b
[deploy] overwrite name field for honeycomb when sending Elasticsearch requests ( #7338 )
2020-04-17 12:30:29 +02:00
Alex
cc6249beff
[deploy] Update whitelisted params on Fastly on deployments ( #7279 )
...
* Add Fastly whitelisted params
* Create FastlyVCL::WhitelistedParams.update service
* Add specs
* Create rake task to call new service
* Add rake task to setup script
* Add documentatoin
* Move sort inside params_to_array method
* Rename VCL_REGEX to VCL_DELIMITER
* Add PR URL to docs
* Move snippet name to SNIPPET_NAME constant
* Refactor setting content
* Rename params_to_array to params_to_sorted_array
* Change guard and log success on update
- Return early if params are equal
- Log success message to Rails.logger on update
- Log params diff to Datadog
* Return true explicitly
* Move rake task execution from to release-tasks
* Remove unnecessary environment guard in task
* Remove duplicate code param
* Refactor string from build_content
* Remove reliance on sort
* Reorder logging to implicitly return true
* Update docs to reference release-script.sh
* Update docs
* Update whitelisted params
* Fix params_updated? bug and add more specs
* Remove duplicate param...oopsie!
2020-04-16 15:11:57 -04:00
Ben Halpern
645920c09f
[deploy] Remove milestone sends ( #7313 )
2020-04-15 19:34:10 -04:00
Molly Struve
223703f0d3
[deploy] Update URLSearchParams to handle arrays correctly for Rails ( #7300 )
2020-04-15 14:58:18 -05:00
rhymes
d6e47a03c7
[deploy] Authentication refactoring - step 1 ( #7259 )
...
* Add Authentication providers
* Making strides on refactoring
* New usr from Twitter
* Existing Twitter user
* Existing user Github
* Test skip_confirmation!
* Refactor a bit and add simplecov groups
* Test user already logged in
* Rename to Authentication::Authenticator
* Refactor to a common class
* Add existing user test for twitter login
* Refactor global handler
* Fix spec and comment Twitter provider
* Update comments and strategy TODO
* Move providers loading code to Authentication::Providers
* add SubclassResponsibility error
* Use delegation
2020-04-15 12:13:10 -04:00
Molly Struve
b10668a454
[deploy] Create a Bulk Index Elasticsearch Worker ( #7265 )
2020-04-15 09:08:59 -05:00
Josh Puetz
73c16c9a9d
[deploy] Tweak comments in feed ( #7261 )
...
* Only include needed fields for top comments
* Test for included user info in comments in feed
* Omit hidden and deleted comments from feed json
* Optimize selected columns from comment
* Revert field selection to prevent user n+1
* Add profile_image_90 to users in comments in feed
2020-04-14 15:23:14 -05:00
Michael Kohl
c8845e647a
[deploy] Remove Google Analytics page counts ( #6969 )
...
* Remove Google Analytics page counts
* Update spec
Co-authored-by: rhymes <rhymesete@gmail.com>
Co-authored-by: Ben Halpern <bendhalpern@gmail.com>
2020-04-14 10:44:05 -04:00
Molly Struve
07050baa28
[deploy] Refactor search_documents Method Into Search Base.rb Class ( #7260 )
2020-04-14 08:39:50 -05:00
Molly Struve
91972dd2c4
ensure that when Tag and ActsAsTaggableOn::Tag are updated their respective related docs are as well ( #7218 )
2020-04-14 08:38:09 -05:00
Josh Puetz
802e225a07
[deploy] Add top comments to articles feed ( #6988 )
...
* Add 'top_comments' to article feed
* Only include root comments
* Cache and eagerly load top comments
* Clear top comments cache when article score is updated
* Add articles.top_comments to bullet whitelist
* Update app/models/article.rb
Co-Authored-By: rhymes <rhymesete@gmail.com>
* Remove limit in top_comments association, remove Rails caching of top comments
* Remove unnecessary test
Co-authored-by: rhymes <rhymesete@gmail.com>
2020-04-13 10:21:03 -04:00
rhymes
34848a4209
Upgrade Rubocop to 0.81 ( #7219 )
...
* Upgrade rubocop to 0.81.0
* Reordered rubocop file and updated it
* Regenerate todo
* Correct some things
* Fix specs
2020-04-11 10:10:04 +02:00
Molly Struve
10b094b4b6
[deploy] refactor data syncing methods to use a base class and take a single argument ( #7204 )
2020-04-10 11:11:35 -05:00
rhymes
63893e4ac1
Upgrade twilio-ruby to 5.33.0 and elasticsearch to 7.6.0 ( #7208 )
...
* Upgrade gems
* Switch ES client to Patron
2020-04-10 15:30:51 +02:00
Mac Siri
604345a85a
Allow img's data-src in RSS ( #7195 )
2020-04-10 10:47:14 +07:00
