Commit graph

3175 commits

Author SHA1 Message Date
Ridhwana
6c8cbabdff
Remove unused file and fix social media icon css on information page (#7295)
* chore: does not look like this file is being used anywhere

* fix: the svg's didn't seem to be resizing because we did not have a viewBox tag on the svg

* chore: update spec file
2020-04-15 13:22:28 +02:00
rhymes
f70afe0d34
Fix UI for settings - api secrets (#7243) 2020-04-15 10:53:43 +02:00
Molly Struve
c5bca2ba49
Record DB counts with count, Fallback on estimated_count (#7286)
* call count on model and if that times out fallback on estimated

* improve specs
2020-04-15 10:53:21 +02:00
Ridhwana
586703f9b7
[deploy] Cleanup some more dev.to generalisation (#7263)
* feat: rename ApplicationConfig[COMMUNITY_NAME] to just community_name

* refactor: use the method name defined in the file

* chore: use community name on the information template

* refactor: move the social media links into a partial

* chore: reuse the css

* chore: update the partners page

* chore: make the code-of conduct DEV related vars dynamic

* feat: update the code of conduct

* feat: first pass at the editor guide

* feat: update more templates (maybe this one should go?)

* feat: update the tags page

* feat: set configurable email

* feat: article urls updated to be dynamic

* feat: add comment

* feat: update rss guide to use local dev

* chore: revert hashtag as it will come from https://github.com/thepracticaldev/dev.to/issues/7254

* chore: string interpolation

* feat: add the code for the svg resizing on the information page.
2020-04-14 21:30:13 -04:00
Michael Kohl
0d59f92670
Add CodeNewbie staff redirect (#7272) 2020-04-14 20:54:42 -04:00
Mac Siri
f4c9df2d8e
[deploy] Add footer toggle to Onboarding's user-follow slide (#7266) 2020-04-14 18:25:03 -04:00
Josh Puetz
73c16c9a9d
[deploy] Tweak comments in feed (#7261)
* Only include needed fields for top comments

* Test for included user info in comments in feed

* Omit hidden and deleted comments from feed json

* Optimize selected columns from comment

* Revert field selection to prevent user n+1

* Add profile_image_90 to users in comments in feed
2020-04-14 15:23:14 -05:00
Mac Siri
d2de9386f2
[deploy] Fix Feeds' VARIANTS issue (#7282) 2020-04-14 16:10:41 -04:00
Andy Zhao
50ba93c232
[deploy] Add character limits for reported_url and message (#7283)
* Add character limits for reported_url and message

* Use one line for reported_url validation

* Revert accidental removal of index line

* Adjust length limits to account for production values
2020-04-14 15:57:21 -04:00
Ben Halpern
e1dd1fe9e4
[deploy] Fix onboarding profile slide for short screens (#7269) 2020-04-14 15:30:26 -04:00
rhymes
53a71c3930
Synchronously render the editor guide (#7140) 2020-04-14 17:10:16 +02:00
Michael Kohl
c8845e647a
[deploy] Remove Google Analytics page counts (#6969)
* Remove Google Analytics page counts

* Update spec

Co-authored-by: rhymes <rhymesete@gmail.com>
Co-authored-by: Ben Halpern <bendhalpern@gmail.com>
2020-04-14 10:44:05 -04:00
rhymes
4e72579d6f
[deploy] Validate API key description length (#7274) 2020-04-14 15:40:56 +02:00
Molly Struve
07050baa28
[deploy] Refactor search_documents Method Into Search Base.rb Class (#7260) 2020-04-14 08:39:50 -05:00
Molly Struve
91972dd2c4
ensure that when Tag and ActsAsTaggableOn::Tag are updated their respective related docs are as well (#7218) 2020-04-14 08:38:09 -05:00
Ben Halpern
ea1c27f6be
[deploy] Add some keyboard shortcuts for /connect active content (#7268)
* Add some keyboard shortcuts for /connect active content

* Account for no rich links
2020-04-13 19:20:39 -04:00
Ben Halpern
dc76277f0d
[deploy] Add functionality to /connect (#7264) 2020-04-13 17:27:32 -04:00
Molly Struve
7103b406ad
ignore reaction not found errors when trying to index them (#7258) 2020-04-13 13:45:21 -04:00
Alex
7dfffac3db
[deploy] Copy ActiveRecord methods from fastly-rails (#7145)
* Add comment referencing Fastly gem

* Create purgable concern and include it

* Typo: deprecate --> deprecated

* Include Purgable on the Tag model

* Rename Purgable to Purgeable

* Reorganize fastly and service methods in Purgeable

* Add and fix specs

* Add development env guards
2020-04-13 10:46:15 -04:00
Ben Halpern
9a88b7a88e
[deploy] Fix chat rerender issues (#7253) 2020-04-13 10:35:18 -04:00
Josh Puetz
802e225a07
[deploy] Add top comments to articles feed (#6988)
* Add 'top_comments' to article feed

* Only include root comments

* Cache and eagerly load top comments

* Clear top comments cache when article score is updated

* Add articles.top_comments to bullet whitelist

* Update app/models/article.rb

Co-Authored-By: rhymes <rhymesete@gmail.com>

* Remove limit in top_comments association, remove Rails caching of top comments

* Remove unnecessary test

Co-authored-by: rhymes <rhymesete@gmail.com>
2020-04-13 10:21:03 -04:00
Michael Kohl
ca23b8e1c6
[deploy] Introduce ClassifiedListingCategory model (#7172)
* Add ClassifiedListingCategoryModel

* Add data update script for classified listing categories

* Add foreign key to reference

* Move data update script to temporary rake task

* Update factory

* Add and fix specs

* Fix typo

* Fix migration

* Correctly add unique index

* Fix migration

* Add slug column to classified listing categories

* Add unique index for slug column
2020-04-13 09:01:58 -04:00
Ben Halpern
b711c2ea9e
[deploy] Fix scrolling issues and small fixes (#7245) 2020-04-12 22:36:32 -04:00
Ben Halpern
00e79b1fd3
[deploy] Sidecar content fullscreen proof of concept (#7244) 2020-04-12 20:45:09 -04:00
rhymes
b2fab26918
[deploy] Fix broken RSS settings page (#7238) 2020-04-12 18:28:51 -04:00
rhymes
32694a22ef
Add rel noopener to links opening in a separate tab (#7235)
* Add rel noopener to links opening in a separate tab

* Trigger Travis!
2020-04-12 17:04:07 +02:00
rhymes
540dd21ea0
[deploy] Use atomic increment for rate limiter counters (#7209)
* Use atomic increment for rate limiter

* Increase testing

* Fix spec with memory store

* Test uploading rate limit with Redis
2020-04-11 12:11:32 -04:00
Ben Halpern
b0a95cdcd7
[deploy] Small design and functionality touches to /connect (#7234)
* Small design and functionality touches to /connect

* Small fixes

* Fix test

* Fix test
2020-04-11 10:56:52 -04:00
rhymes
34848a4209
Upgrade Rubocop to 0.81 (#7219)
* Upgrade rubocop to 0.81.0

* Reordered rubocop file and updated it

* Regenerate todo

* Correct some things

* Fix specs
2020-04-11 10:10:04 +02:00
Julianna Tetreault
61bb4b42ac
[deploy] Revert generalization of meta content in offline.html (#7232)
* Remove erb from meta tags for both url and site_name
  * Remove extra parentheses from tags/index.html.erb
2020-04-10 21:45:49 -04:00
Ben Halpern
8144b98007
[deploy] Fix video chat typo (#7221) 2020-04-10 14:00:47 -04:00
Ben Halpern
9b7cee5be9
[deploy] Use roomtype variable (#7220) 2020-04-10 13:13:31 -04:00
Ben Halpern
5ce2152a5c
[deploy] Remove old video code and clean up some functionality (#7217) 2020-04-10 12:54:49 -04:00
Andy Zhao
ea1c0b85af
Add single resource admin roles for a few internal pages (#7202)
* Add resourcify to allow single resource admin access

* Override application_controller resource b/c custom name

* Don't resourcify audit log because moderator actions model exists

* Add tests for checking single resource admin access

* Use rails path helpers

* Add happy path spec for single resource admin, negative reactions
2020-04-10 12:51:19 -04:00
Ben Halpern
358edf8817
Add canonical url to /new (#7206) 2020-04-10 12:49:00 -04:00
Ridhwana
8e3ba184e7
Update all the static (i.e. DEV or dev.to) text on mailers to be dynamic (#7216)
* feat: update all the static text on mailers to be dynamic

* feat: use community_qualified_name
2020-04-10 12:48:38 -04:00
Anna Buianova
c975838013
[deploy] Replaced overriden pages with placeholders (#7210)
* Remove dev-specific info from a couple of pages

* Replace hardcoded pages that are already overriden on prod with placeholders

* Fix pages' specs
2020-04-10 12:48:21 -04:00
Molly Struve
10b094b4b6
[deploy] refactor data syncing methods to use a base class and take a single argument (#7204) 2020-04-10 11:11:35 -05:00
Ridhwana
c627f4e98a
Replace DEV with the community name... almost everywhere (#7211)
* chore: search and replace carefully

* fix: small updates

* fix: spec contains DEV hardcoded

* chore: update on badges

* feat: upcase
2020-04-10 17:03:16 +02:00
Anna Buianova
406cc95fcd
Remove /sponsorship-info (#7213) 2020-04-10 17:29:09 +03:00
rhymes
63893e4ac1
Upgrade twilio-ruby to 5.33.0 and elasticsearch to 7.6.0 (#7208)
* Upgrade gems

* Switch ES client to Patron
2020-04-10 15:30:51 +02:00
Mac Siri
604345a85a
Allow img's data-src in RSS (#7195) 2020-04-10 10:47:14 +07:00
Molly Struve
26acabce51
[deploy] add custom sorting and scoring for feed content (#7199) 2020-04-09 18:30:27 -04:00
Alex
10c1882548
[deploy] Log image data to Datadog for file name too long error (#7200)
* Log image data to Datadog for file name too long error

* Add guard for when no images are found
2020-04-09 18:25:26 -04:00
Ridhwana
a1ef72f3f9
feat: make the togglability on the card header and not the button only for enhanced user experience (#7197) 2020-04-09 18:13:19 -04:00
Nick Taylor
7aaa379422
Fixed generation of z-index utility CSS classes (#7203) 2020-04-09 17:13:19 -04:00
Mac Siri
4c62c5e43d
[deploy] Account for falsey test_variant in FeedsController (#7146) 2020-04-09 14:10:50 -04:00
Ridhwana
e626cfa933
[deploy] Split out social media options (Important: post deployment task to be run) (#7173)
* feat: define the different social media handles

* feat: dynamically render all the social media fields

* feat: ensure that the social media handles are permitter and dealt in a separate path from the rest

* test: update  social_networks_handle to social_media_handles

* feat: update the sidebar to use different social media

* feat: update the twitter:site meta handle to be  SiteConfig.social_media_handles["twitter"]

* feat: update the a links to tweets

* feat: make the links dynamic and only show those that there is a value for

* refactor: make @ThePracticalDev dynamic

* refactor: make @ThePracticalDev dynamic

* feat: add dynamic social media handles

* chore: rename values

* chore: remove extra social handles

* chore: some spacing

* chore: remove lines

* rafector: user rails-settings-cached type: :hash to set the type and the defaults

* feat: use nil and blank instead of "" and empty

* chore: move the social media handles into the right box

* refactor: rearrange model placement based on the UI

* chore: code climate

* refactor: comments from PR

* chore: rename the ff

* chore: amended twitter username

* chore: add a temporary rake task

* feat: update names

* chore: why am i using the old syntax :(

* chore: revert dynamic erb variable in offline.html
2020-04-09 19:51:11 +02:00
Mac Siri
39aca8993c
Combine profile onboarding slide (#7163) [deploy] 2020-04-09 13:47:42 -04:00
Vaidehi Joshi
dbbeaf2422
Onboarding intro slide tweaks (#7162) [deploy]
* Render the user's name on intro slide of onboarding

* Refactor terms + conditions form in onboarding view

* Style the back button using crayons design system.
* Remove redundant scroll styles (only need `overflow-y: scroll` here).
* Ensure that content is readable, and back button doesn't conflict with content.
* Ensure size of content is same size as "intro slide".
* Remove unnecesary inline styles, use CSS class instead.

* Fix missing userData issue

* Onboarding test cleanup, inline greeting instead of in a variable
2020-04-09 08:57:50 -07:00