maverick/docbrown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[deploy] Add character limits for reported_url and message (#7283)

Browse source 
* Add character limits for reported_url and message

* Use one line for reported_url validation

* Revert accidental removal of index line

* Adjust length limits to account for production values
This commit is contained in:
Andy Zhao 2020-04-14 15:57:21 -04:00 • committed by GitHub
parent e1dd1fe9e4
commit 50ba93c232
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
app/models/feedback_message.rb
View file

@ -7,7 +7,8 @@ class FeedbackMessage < ApplicationRecord
has_many :notes, as: :noteable, inverse_of: :noteable, dependent: :destroy
validates :feedback_type, :message, presence: true
validates :reported_url, :category, presence: { if: :abuse_report? }
validates :reported_url, :category, presence: { if: :abuse_report? }, length: { maximum: 250 }
validates :message, length: { maximum: 2500 }
validates :category,
inclusion: {
in: ["spam", "other", "rude or vulgar", "harassment", "bug", "listings"]

2
spec/models/feedback_message_spec.rb
View file

@ -14,6 +14,8 @@ RSpec.describe FeedbackMessage, type: :model do
it { is_expected.to validate_presence_of(:feedback_type) }
it { is_expected.to validate_presence_of(:reported_url) }
it { is_expected.to validate_presence_of(:message) }
it { is_expected.to validate_length_of(:reported_url).is_at_most(250) }
it { is_expected.to validate_length_of(:message).is_at_most(2500) }
it do
expect(feedback_message).to validate_inclusion_of(:category).