From 50ba93c23257bc51950cc23395c737f08956dc22 Mon Sep 17 00:00:00 2001
From: Andy Zhao <17884966+Zhao-Andy@users.noreply.github.com>
Date: Tue, 14 Apr 2020 15:57:21 -0400
Subject: [PATCH] [deploy] Add character limits for reported_url and message
 (#7283)

* Add character limits for reported_url and message

* Use one line for reported_url validation

* Revert accidental removal of index line

* Adjust length limits to account for production values
---
 app/models/feedback_message.rb       | 3 ++-
 spec/models/feedback_message_spec.rb | 2 ++
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/app/models/feedback_message.rb b/app/models/feedback_message.rb
index 116b6d850..d6a9f60ec 100644
--- a/app/models/feedback_message.rb
+++ b/app/models/feedback_message.rb
@@ -7,7 +7,8 @@ class FeedbackMessage < ApplicationRecord
   has_many :notes, as: :noteable, inverse_of: :noteable, dependent: :destroy
 
   validates :feedback_type, :message, presence: true
-  validates :reported_url, :category, presence: { if: :abuse_report? }
+  validates :reported_url, :category, presence: { if: :abuse_report? }, length: { maximum: 250 }
+  validates :message, length: { maximum: 2500 }
   validates :category,
             inclusion: {
               in: ["spam", "other", "rude or vulgar", "harassment", "bug", "listings"]
diff --git a/spec/models/feedback_message_spec.rb b/spec/models/feedback_message_spec.rb
index 0e1991cfd..2de7ad999 100644
--- a/spec/models/feedback_message_spec.rb
+++ b/spec/models/feedback_message_spec.rb
@@ -14,6 +14,8 @@ RSpec.describe FeedbackMessage, type: :model do
     it { is_expected.to validate_presence_of(:feedback_type) }
     it { is_expected.to validate_presence_of(:reported_url) }
     it { is_expected.to validate_presence_of(:message) }
+    it { is_expected.to validate_length_of(:reported_url).is_at_most(250) }
+    it { is_expected.to validate_length_of(:message).is_at_most(2500) }
 
     it do
       expect(feedback_message).to validate_inclusion_of(:category).