maverick/docbrown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[deploy] Account for falsey test_variant in FeedsController (#7146)

Browse source
This commit is contained in:
Mac Siri 2020-04-09 14:10:50 -04:00 • committed by GitHub
parent e626cfa933
commit 4c62c5e43d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
app/controllers/stories/feeds_controller.rb
View file

@ -2,7 +2,6 @@ class Stories::FeedsController < ApplicationController
respond_to :json
VARIANTS = {
"base" => [:default_home_feed, user_signed_in: true],
"more_random_experiment" => :default_home_feed_with_more_randomness_experiment,
"mix_base_more_random_experiment" => :mix_default_and_more_random_experiment,
"more_tag_weight_experiment" => :more_tag_weight_experiment,
@ -38,6 +37,10 @@ class Stories::FeedsController < ApplicationController
def ab_test_user_signed_in_feed(feed)
test_variant = field_test(:user_home_feed, participant: current_user)
Honeycomb.add_field("field_test_user_home_feed", test_variant) # Monitoring different variants
feed.public_send(*VARIANTS[test_variant || "base"]) # Splat operator required for the array variant
if test_variant == "base" || test_variant == "" || test_variant.nil?
feed.default_home_feed(user_signed_in: true)
else
feed.public_send(VARIANTS[test_variant])
end
end
end