maverick/docbrown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[deploy] Fix broken RSS settings page (#7238)

Browse source
This commit is contained in:
rhymes 2020-04-13 00:28:51 +02:00 • committed by GitHub
parent 32694a22ef
commit b2fab26918
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
app/views/users/_publishing_from_rss.html.erb
View file

@ -1,4 +1,4 @@
<h3>Publishing to dev.to from RSS</h3>
<h3>Publishing to <%= community_name %> from RSS</h3>
<% if @user.feed_url.present? %>
<%= form_for(@user) do |f| %>
<div class="field">
@ -15,7 +15,7 @@
<% end %>
<p>
Posts will land in your <a href="/dashboard">dashboard</a>
<b><em>as drafts</em></b>, and then you can publish from there (or give dev.to admins permission to do so).
<b><em>as drafts</em></b>, and then you can publish from there (or give <%= community_name %> admins permission to do so).
</p>
<p>
Formatting will typically look good, but you may have to make manual fixes. In the case of Medium, you may have to manually fix embeds.
@ -50,7 +50,7 @@
<div class="sub-field">
<%= f.check_box :feed_referential_link %>
<%= f.label :feed_referential_link, "Replace self-referential links with #{community_name} %>-specific links" %>
<%= f.label :feed_referential_link, "Replace self-referential links with #{community_name}-specific links" %>
<div class="field-explainer">
If you check this box, the post will automatically change any URLs included in the post to refer to the version of that article on <%= community_name %> if available. This is primarily meant for folks migrating their entire blog onto <%= community_name %>.
</div>

6
spec/requests/user/user_settings_spec.rb
View file

@ -36,6 +36,12 @@ RSpec.describe "UserSettings", type: :request do
expect(response.body).to include("Style Customization")
end
it "displays content on RSS tab properly" do
get "/settings/publishing-from-rss"
title = "Publishing to #{ApplicationConfig['COMMUNITY_NAME']} from RSS"
expect(response.body).to include(title)
end
it "renders heads up dupe account message with proper param" do
get "/settings?state=previous-registration"
error_message = "There is an existing account authorized with that social account"