Michael Kohl
52759c9427
Allow deleting comments if article has already been deleted ( #5889 ) [deploy]
2020-02-05 17:10:19 -05:00
dependabot-preview[bot]
22c643669a
Bump jsdom from 15.2.1 to 16.1.0 ( #5845 ) [deploy]
...
Bumps [jsdom](https://github.com/jsdom/jsdom ) from 15.2.1 to 16.1.0.
- [Release notes](https://github.com/jsdom/jsdom/releases )
- [Changelog](https://github.com/jsdom/jsdom/blob/master/Changelog.md )
- [Commits](https://github.com/jsdom/jsdom/compare/15.2.1...16.1.0 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-02-05 17:05:31 -05:00
rhymes
89852abd82
Use yarn 1.21.1 ( #5786 )
2020-02-05 17:04:06 -05:00
Michael Kohl
424c141539
Remove Foreman gem ( #5821 )
2020-02-05 17:01:04 -05:00
Fernando Valverde
e8523c0749
Adds core team member [ci skip] ( #5881 )
2020-02-05 16:59:21 -05:00
Alex
662d62fe72
Remove Notifications::TagAdjustmentNotificationJob ( #5915 ) [deploy]
2020-02-05 13:33:20 -08:00
Alex
2f4ee09736
Remove UpdateMainImageBackgroundHexJob & spec ( #5911 )
2020-02-05 13:32:58 -08:00
Alex
8a46f4c701
Remove HtmlVariantTrialCreateJob & spec ( #5910 )
2020-02-05 13:32:45 -08:00
Alex
6a100415cc
Move Notifications::TagAdjustmentNotificationJob to Sidekiq ( #5909 ) [deploy]
...
* Create TagAdjustmentNotificationWorker
* Create TagAdjustmentNotificationWorker spec
* Update references and specs for new worker
* Future proof specs
2020-02-05 09:52:21 -08:00
Josh Puetz
41481b532f
Ignore html_safe in erb files ( #5913 )
2020-02-05 12:26:41 -05:00
rhymes
3260270103
Have counters:update_users use a transaction per user and customizable batch size ( #5912 ) [deploy]
2020-02-05 12:26:03 -05:00
Gonzalo Ricco
dd796aaef3
Fix raising validation if followable already exist(race condition) ( #5826 )
...
* Fix raising validation if followable already exist(race condition)
* Change Rails Logger for DataDogStatsClient and remove 'begin' keyword in follow method
Co-authored-by: Gonzalo Ricco <gonzalo.ricco@leniolabs.com>
2020-02-05 12:25:26 -05:00
Maja Komel
28440d1fa1
Return NotFound error if ChatChannelMembership is not found ( #5806 )
2020-02-05 12:24:40 -05:00
Michael Kohl
7270d5ab4c
Move user deletion by moderator to worker ( #5887 ) [deploy]
2020-02-05 08:27:07 -05:00
rhymes
a95877e8ff
Use cleverer patterns to fetch/iterate AR objects when checking presence ( #5833 ) [deploy]
2020-02-05 08:21:20 -05:00
Andy Zhao
be6aaf750c
Add user as reactable ( #5893 )
...
* Add user as reactable
* Make title method public
* Use constants for reactable_type and status
2020-02-04 21:25:56 -06:00
codekatas
bae7ee8b73
Migrate update main image background job to sidekiq ( #5345 ) [deploy]
...
* Add new UpdateMainImageBackgroundHexWorker worker class
This is a port of app/jobs/update_main_image_background_job.rb
that works with Sidekiq instead of DelayedJob.
* Update all references to UpdateMainImageBackgroundHexJob
This updates all references to UpdateMainImageBackgroundHexJob
so they now call UpdateMainImageBackgroundHexWorker, which works
with Sidekiq instead of DelayedJob.
* Move method call to after_commit callback
* Fix article specs with sidekiq helpers
Co-authored-by: Alex <alexandersmith223@gmail.com>
2020-02-04 17:51:09 -08:00
Alex
97ee0a804f
Move HtmlVariantTrial#create inline ( #5901 ) [deploy]
2020-02-04 17:29:46 -08:00
Alex
8261ab74d7
Remove Notifications::ModerationNotificationJob ( #5905 ) [deploy]
2020-02-04 17:03:08 -08:00
Alex
8578c78158
Remove Notifications::UpdateJob and spec ( #5903 )
2020-02-04 17:02:47 -08:00
Alex
15b4565ac8
Remove Articles::ScoreCalcJob and spec ( #5898 )
2020-02-04 17:01:59 -08:00
Alex
aa7bc6b7b2
Remove Tags::BustCacheJob and spec ( #5897 )
2020-02-04 17:01:06 -08:00
Vaidehi Joshi
e84dec1db6
Allow broadcasts to be created from internal/broadcast ( #5908 ) [deploy]
...
Also raise errors when necessary in all broadcast endpoints.
Clean up tests and add specs for POST /internal/broadcast
2020-02-04 15:57:17 -08:00
Michael Kohl
a26ea73771
Remove direct chat channels when banishing user ( #5784 ) [deploy]
...
* Remove direct chat channels when banishing user
* Also remove article's buffer updates
* Incorporate PR feedback and make deletion safer
2020-02-04 17:10:39 -05:00
dependabot-preview[bot]
1b79b03874
Bump eslint-config-prettier from 6.9.0 to 6.10.0 ( #5850 )
2020-02-04 15:47:30 -05:00
Vaidehi Joshi
a396d024de
Remove quotes from broadcast options in internal form ( #5904 ) [deploy]
2020-02-04 12:37:28 -08:00
dependabot-preview[bot]
95b1bd832b
Bump eslint-plugin-react from 7.18.0 to 7.18.3 ( #5851 )
2020-02-04 15:29:17 -05:00
Michael Kohl
9e6a363cfc
Add readonly ApplicationConfig to /internal/config ( #5662 ) [deploy]
...
* Add readonly ApplicationConfig to /internal/config
* Incorporate PR feedback
* Remove spurious div
2020-02-04 15:13:34 -05:00
dependabot-preview[bot]
2f7ca83ac8
Bump kaminari from 1.1.1 to 1.2.0 ( #5860 )
2020-02-04 14:06:40 -05:00
Alex
67894aa1f8
Move Articles::DetectHumanLanguage from background job to inline ( #5888 ) [deploy]
...
* Move DetectHumanLanguage inline
* Remove old DetectHumanLanguage job and spec
* Fix copy/pasta mixup...oopsie!
* Update article_spec for inline LanguageDetector
2020-02-04 10:45:42 -08:00
Alex
de3ee9ebec
Move HtmlVariantSuccessesCreate from job to inline ( #5879 ) [deploy]
2020-02-04 10:24:39 -08:00
Alex
8168a5e8f5
Move Articles::ScoreCalcJob to Sidekiq ( #5875 ) [deploy]
...
* Create Articles::ScoreCalcWorker
* Create Articles::ScoreCalcWorker spec
* Update references to the new ScoreCalcWorker
* Refactoring conditional callbacks and biz logic
- Move update_columns to a model method
- Move conditions on callback to guard clause in callback method
- Make article_destroy_spec more explicit
2020-02-04 10:01:46 -08:00
Michael Kohl
5c74464b30
Add documentation for ENVied & SiteConfig ( #5841 )
...
* Add documentation for ENVied & SiteConfig
* Add images
* Fix swapped screenshots and update list
2020-02-04 11:41:25 -06:00
Alex
0c42ea2b43
Move Tags::BustCacheJob to Sidekiq ( #5870 ) [deploy]
...
* Create Tags::BustCacheWorker
* Create Tags::BustCacheWorker spec
* Update references to new worker
2020-02-04 09:24:37 -08:00
Vaidehi Joshi
267e08f6f0
Improve dropdown UX for internal/badges ( #5880 ) [deploy]
...
* Improve dropdown UX for internal/badges
Add a "blank" option to the dropdown to list of badges on internal/badges route.
Also add some checks to handle if an admin accidentally tries to award a "blank" badge.
* Ensure error is surfaced as flash message
2020-02-04 09:02:14 -08:00
Vaidehi Joshi
b09a0c60f3
Add comment to highlight difference between previewing in v1 and v2 editors ( #5894 )
...
A follow-up to https://github.com/thepracticaldev/dev.to/pull/5873 .
2020-02-04 08:32:06 -08:00
Michael Kohl
79ff4cbd19
Update contributor guide with new tag name ( #5822 )
2020-02-04 11:26:33 -05:00
rhymes
42b33f29ae
Add signin=true as a param correctly if the URL already has params ( #5866 ) [deploy]
2020-02-04 09:41:10 -05:00
Molly Struve
2207f795b1
Hookup Elasticsearch in travis ( #5871 )
2020-02-04 08:20:14 -05:00
Nick Taylor
59f5cd7e07
Cleanup proptypes exports ( #5874 )
2020-02-03 17:52:23 -05:00
dependabot-preview[bot]
62b9c9ac86
Bump oj from 3.10.1 to 3.10.2 ( #5856 )
2020-02-03 17:46:57 -05:00
Mohamed ABDELLANI
058f6a2939
Remove footer rendering from shecoded.html.erb ( #5823 )
2020-02-03 17:02:01 -05:00
Vaidehi Joshi
db3e6128ac
Render main image in article preview for v2 editor ( #5873 ) [deploy]
...
Previewing a main image on an article was broken in v2 of the editor :(
We had some tests for this (which I wrote), but the setup for the tests weren't quite right!
This commit fixes the bug, and also refactors and cleans up our tests quite a bit.
Also adds some snapshots for both v1 and v2 editors in a "no image" preview state.
2020-02-03 16:58:11 -05:00
Alex
e579914b1a
Remove BadgeAchievements::SendEmailNotificationJob ( #5869 ) [deploy]
2020-02-03 11:10:47 -08:00
Alex
59437f518f
Remove old SubscribeToMailchimpNewsletterJob & spec ( #5868 )
2020-02-03 10:35:10 -08:00
Alex
c0ebb38560
Remove old ResaveArticlesJob and spec ( #5867 )
2020-02-03 10:34:47 -08:00
dependabot-preview[bot]
4a3411f33a
Bump honeybadger-js from 2.0.2 to 2.1.0 ( #5849 )
2020-02-03 12:05:07 -05:00
Jacob Herrington
e8130565e1
Add whitespace to internal users edit page ( #5840 )
...
Co-authored-by: MichaelaHunter <michaela1234@gmail.com>
Co-authored-by: MichaelaHunter <60361569+MichaelaHunter@users.noreply.github.com>
2020-02-03 11:34:31 -05:00
rhymes
3b25b014a3
Replace the initial migration for strong_migrations gem ( #5865 )
2020-02-03 11:32:46 -05:00
Fran Zekan
cba4e99525
Return a 404 response If @event is Not Found ( #5798 ) [deploy]
2020-02-03 11:30:52 -05:00
