Mac Siri
16cc9014f8
Revert "Remove IE-specific setting ( #16073 )" ( #16719 )
...
This reverts commit 92b1958181
2022-02-28 11:40:09 -05:00
Suzanne Aitchison
a70bb4811c
amend csrf token retries ( #16714 )
2022-02-28 15:05:13 +00:00
Jeremy Friesen
acd5b175ed
Ensuring POST api/v0/articles authorizes by policy ( #16685 )
...
As part of the [Authorization System Use Case
1:1](https://github.com/orgs/forem/projects/46 ) project, we are driving
towards the feature of: "Only admin's may post articles in this Forem."
This commit ensures that the API's "create an article" end-point
delivers on that feature.
Along the way, I've added reading notes and comments, to help us further
flex in the future (namely move all authorization checks into a policy
object).
Closes forem/forem#16488
2022-02-28 08:50:33 -05:00
dependabot[bot]
3a3018ff93
Bump counter_culture from 3.2.0 to 3.2.1 ( #16707 )
...
* Bump counter_culture from 3.2.0 to 3.2.1
Bumps [counter_culture](https://github.com/magnusvk/counter_culture ) from 3.2.0 to 3.2.1.
- [Release notes](https://github.com/magnusvk/counter_culture/releases )
- [Changelog](https://github.com/magnusvk/counter_culture/blob/master/CHANGELOG.md )
- [Commits](https://github.com/magnusvk/counter_culture/compare/v3.2.0...v3.2.1 )
---
updated-dependencies:
- dependency-name: counter_culture
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
* Wake up, Travis
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Julianna Tetreault <32834804+juliannatetreault@users.noreply.github.com>
2022-02-25 13:56:50 -07:00
dependabot[bot]
d5019301c2
Bump stackprof from 0.2.18 to 0.2.19 ( #16706 )
...
Bumps [stackprof](https://github.com/tmm1/stackprof ) from 0.2.18 to 0.2.19.
- [Release notes](https://github.com/tmm1/stackprof/releases )
- [Changelog](https://github.com/tmm1/stackprof/blob/master/CHANGELOG.md )
- [Commits](https://github.com/tmm1/stackprof/compare/v0.2.18...v0.2.19 )
---
updated-dependencies:
- dependency-name: stackprof
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-02-25 12:44:05 -07:00
dependabot[bot]
1601aa05a3
Bump gibbon from 3.4.3 to 3.4.4 ( #16705 )
...
Bumps [gibbon](https://github.com/amro/gibbon ) from 3.4.3 to 3.4.4.
- [Release notes](https://github.com/amro/gibbon/releases )
- [Changelog](https://github.com/amro/gibbon/blob/master/CHANGELOG.md )
- [Commits](https://github.com/amro/gibbon/compare/v3.4.3...v3.4.4 )
---
updated-dependencies:
- dependency-name: gibbon
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-02-25 11:24:54 -07:00
Julianna Tetreault
2be6ecfc14
Updates the copy for the Flags tab ( #16697 )
2022-02-25 08:41:47 -07:00
Ridhwana
92e59d76c4
remove verify emails from the dropdown ( #16699 )
2022-02-25 17:36:46 +02:00
Michael Kohl
3322b49e84
✂️ Remove myself from core contributors ( #16672 )
...
* Remove myself from core contributors
* Update comments
* Update more comments
2022-02-25 09:56:19 -05:00
Julianna Tetreault
0fd55d1c14
Update the Copy for the "Emails" Tab in the Admin Member Detail View ( #16693 )
...
* Adjusts the copy and layout of the Emails section
* Revert design changes to the Emails tab
2022-02-25 07:33:52 -07:00
Julianna Tetreault
70e6aecfc3
Update the Copy for the "Reports" Tab in the Admin Member Detail View ( #16696 )
...
* Updates the copy on the Reports tab
* Update app/views/admin/users/show/reports/_index.html.erb
2022-02-25 07:33:13 -07:00
Julianna Tetreault
5f26dc6809
Update the Copy for the "Overview" Tab and Its Modals ( #16645 )
...
* Updates the overview copy and over modal copy
* Updates E2E tests for Admin Member View overview fields
* Fixes copy on credit button in manageCredits.spec.js
2022-02-25 07:17:00 -07:00
Julianna Tetreault
d7993df25a
Update copy for Admin Member Detail View notes section (empty and not) ( #16691 )
2022-02-25 07:43:52 -05:00
Dwight Scott
ab224d34b2
Add ability to bulk search tags by name or id ( #16671 )
...
* Trigger Build
* Remove cache header before_action and add ability to search by tag name
* Remove cache header before_action and add ability to search by tag name
* Add internal bulk tag endpoint to get tags by array of names or ids
* Restore V0 tags controller
2022-02-24 12:34:50 -05:00
Jeremy Friesen
e0e4003671
Removing somewhat duplicated logic ( #16684 )
...
In conversations with citizen428, this method looked to be a holdover
from a past approach. Reviewing the code, we can get the same behavior
with other methods.
Further, I added some comments for future considerations, and refactored
for more readily scannable guard clauses.
Related to forem/forem#16488 , forem/forem#16681 , and forem/forem#6255
2022-02-24 12:16:48 -05:00
Suzanne Aitchison
1dcd593c10
✂️ Remove clipboard packages no longer needed ✂️ ( #16683 )
...
* remove clipboard copy packages no longer needed
* add to tests to make sure clipboard populated
2022-02-24 16:47:22 +00:00
Michael Kohl
f917a501af
Silence parser/current warnings ( #16682 )
2022-02-24 21:43:59 +07:00
ludwiczakpawel
80422120b4
GIF button z-index issue ( #16649 )
...
* fix
* fix sneak in
2022-02-24 09:40:18 +01:00
Jeremy Friesen
8ec81e80e9
Removing duplicate logic and adding docs ( #16681 )
...
As I was investigating an approach for #16488 , I stumbled upon two
methods partially doing the same thing. This helps consolidate the
logic and provides some guiding documentation.
2022-02-23 15:22:35 -05:00
Daniel Uber
71a4c47181
Update identities where the auth data dump is a plain hash ( #16676 )
...
* Update identities where the auth data dump is a plain hash
All but 3 records in DEV have OmniAuth::AuthHash objects serialized as
auth data dump. Normalize the remaining ones so they don't cause no
method errors when we treat the auth_data_dump as an object (sending
`#info` instead of asking for `['info']`).
should address https://app.honeybadger.io/projects/66984/faults/84183659
Add null safety check in a second example (that null values should not
cause an error, and should not be coerced to auth hashes).
* Ignore rubocop suggestion to create list
Because the factory for identities doesn't automatically create the
required user object, this is impractical.
While I'm here, move the identity hash update into the creation block
rather than doing this in two passes.
Co-authored-by: Jamie Gaskins <jgaskins@hey.com>
2022-02-23 14:14:14 -06:00
dependabot[bot]
9a0682d652
Bump pg from 1.3.2 to 1.3.3 ( #16680 )
...
Bumps [pg](https://github.com/ged/ruby-pg ) from 1.3.2 to 1.3.3.
- [Release notes](https://github.com/ged/ruby-pg/releases )
- [Changelog](https://github.com/ged/ruby-pg/blob/master/History.rdoc )
- [Commits](https://github.com/ged/ruby-pg/compare/v1.3.2...v1.3.3 )
---
updated-dependencies:
- dependency-name: pg
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-02-23 12:35:25 -06:00
ludwiczakpawel
a313d8ad38
Text overflow on profile preview cards ( #16650 )
2022-02-23 16:52:05 +01:00
yheuhtozr
c5faab1736
extra tweaks for i18n ( #16192 )
...
* extra tweaks for i18n
* fix for PR
* fix for #16115
* fix for rubocop
* fixes for spec
2022-02-23 06:48:52 -07:00
Suzanne Aitchison
24d02b6a53
Add new ColorPicker to organization settings ( #16642 )
...
* Use new color picker in org settings
* add cypress spec
* remove i18n keys no longer needed
2022-02-23 09:05:39 +00:00
Michael Kohl
b07ea0a87e
More listings refactoring ( #16343 )
2022-02-23 13:44:30 +07:00
Michael Kohl
d4ec02bf6d
Update profile image for orgs in seeds ( #16666 )
2022-02-23 10:13:43 +07:00
Michael Kohl
e1bce8c398
Update device_detector, remove warning workaround ( #16665 )
...
Co-authored-by: Dan Uber <dan@forem.com>
2022-02-23 10:13:21 +07:00
Julianna Tetreault
45b7806120
Remove Remaining logo_svg Code ( #16291 )
...
* Removes logo_svg-related code
* Removes logo_svg-related specs
* Removes the logo_uploader and logo_uploader DUS spec
* Removes the logo_uploader_spec.rb
* Adds a DUS to remove the logo_svg var from the DB
* Reverts the removal of the logo_svg_uploader.rb
2022-02-22 12:05:16 -07:00
Mac Siri
5fc1f48e51
Add ChunkLoadError to Honeybadger's ignorePatterns ( #16662 )
2022-02-22 13:48:43 -05:00
dependabot[bot]
3d0c968f57
Bump nokogiri from 1.13.2 to 1.13.3 ( #16668 )
...
Bumps [nokogiri](https://github.com/sparklemotion/nokogiri ) from 1.13.2 to 1.13.3.
- [Release notes](https://github.com/sparklemotion/nokogiri/releases )
- [Changelog](https://github.com/sparklemotion/nokogiri/blob/v1.13.3/CHANGELOG.md )
- [Commits](https://github.com/sparklemotion/nokogiri/compare/v1.13.2...v1.13.3 )
---
updated-dependencies:
- dependency-name: nokogiri
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-02-22 12:27:03 -06:00
Daniel Uber
a052b16015
Don't sanitize anchor elements with no href ( #16667 )
...
* If href is nil, allow node
* Add unit test showing no change
My first pass had the `<a>` within an h1 content, but the scrubber
added a newline after the closing a tag?
2022-02-22 11:27:38 -06:00
Ryan Palo
40639ea602
Fix RSS feed validity issue ( #16418 ) ( #16517 )
2022-02-22 09:22:05 -06:00
Ben Halpern
8649eaed0f
[Small win] Add display name to campaign settings ( #16653 )
...
* Add display name to campaign settings
* Update app/models/settings/campaign.rb
* Update app/views/admin/settings/forms/_campaign.html.erb
2022-02-22 10:01:52 -05:00
ludwiczakpawel
ec41d12246
theme-color ( #16651 )
2022-02-22 15:52:14 +01:00
Arit Amana
9c92ce03dc
Implement Loom Embed (not merging now) ( #16633 )
...
* started implementation and specs
* complete implementation and specs
* refactor
* update doc
* fix failing specs
* typos will NOT be the death of me
2022-02-22 09:05:55 -05:00
dependabot[bot]
0014cffcf9
Bump eslint-config-prettier from 8.3.0 to 8.4.0 ( #16658 )
...
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-02-22 12:34:04 +07:00
dependabot[bot]
708023b62e
Bump @babel/core from 7.17.3 to 7.17.5 ( #16659 )
...
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-02-22 12:33:29 +07:00
Daniel Uber
ca741582a5
Update nokogiri from 1.13.1 to 1.13.2 ( #16663 )
...
Fixes CVE-2021-30560 / GHSA-fq42-c5rg-92c2 and bundle-audit failure
2022-02-21 14:58:30 -06:00
dependabot[bot]
505df69784
Bump @honeybadger-io/js from 3.2.7 to 3.2.8 ( #16657 )
...
Bumps [@honeybadger-io/js](https://github.com/honeybadger-io/honeybadger-js ) from 3.2.7 to 3.2.8.
- [Release notes](https://github.com/honeybadger-io/honeybadger-js/releases )
- [Changelog](https://github.com/honeybadger-io/honeybadger-js/blob/master/CHANGELOG.md )
- [Commits](https://github.com/honeybadger-io/honeybadger-js/compare/v3.2.7...v3.2.8 )
---
updated-dependencies:
- dependency-name: "@honeybadger-io/js"
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-02-21 13:44:39 -06:00
dependabot[bot]
33697db9a8
Bump sass from 1.49.7 to 1.49.8 ( #16660 )
...
Bumps [sass](https://github.com/sass/dart-sass ) from 1.49.7 to 1.49.8.
- [Release notes](https://github.com/sass/dart-sass/releases )
- [Changelog](https://github.com/sass/dart-sass/blob/main/CHANGELOG.md )
- [Commits](https://github.com/sass/dart-sass/compare/1.49.7...1.49.8 )
---
updated-dependencies:
- dependency-name: sass
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-02-21 13:44:05 -06:00
dependabot[bot]
d33fdeea45
Bump core-js from 3.21.0 to 3.21.1 ( #16661 )
...
Bumps [core-js](https://github.com/zloirock/core-js ) from 3.21.0 to 3.21.1.
- [Release notes](https://github.com/zloirock/core-js/releases )
- [Changelog](https://github.com/zloirock/core-js/blob/master/CHANGELOG.md )
- [Commits](https://github.com/zloirock/core-js/compare/v3.21.0...v3.21.1 )
---
updated-dependencies:
- dependency-name: core-js
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-02-21 13:43:11 -06:00
Daniel Uber
ba25055e74
Update flipper in gemfile.lock ( #16654 )
...
This showed as a deploy error in
https://app.travis-ci.com/forem/forem/builds/246802177
2022-02-21 10:40:49 -06:00
Jeremy Friesen
d055613676
Adjusting ArticlePolicy for admin only posting ( #16614 )
...
* Adjusting ArticlePolicy for admin only posting
The goal of this commit is actually two fold:
1) To add documentation regarding my current emerging understanding of
our caching implementation as it relates to our authorization and
authentication.
2) Flippiing "on" the feature's core authorization check.
Buried within this is the desired normalization of the authorization
between the `ArticlePolicy`'s `#create?`, `#preview?`, `#new?`.
My testing plan for this is to ask for SRE to spin-up a canary, then
test. What does that look like? I'm uncertain because this is nudge
closer towards our edge-caching strategy. Which makes robust testing
more difficult.
Closes forem/forem#16483
Related to #16529 , #16571 , #16536 , #16529
Informs #16490 , #16606
* Update spec/requests/editor_spec.rb
Co-authored-by: Jamie Gaskins <jgaskins@hey.com>
Co-authored-by: Jamie Gaskins <jgaskins@hey.com>
2022-02-21 10:09:13 -05:00
Jeremy Friesen
909766c049
Adjusting suspended user authorizations ( #16634 )
...
Closes forem/forem#16537
2022-02-21 10:08:24 -05:00
Julianna Tetreault
e43a7b9450
Removes what appears to be an usused comment from admin_menu.rb ( #16644 )
2022-02-21 06:52:57 -07:00
leewynne
075d1cf1e4
removed dev.to from _terms text and replaced with community_name ( #16646 )
...
Co-authored-by: leewynne <lee@fullfury.co.uk>
2022-02-21 06:51:54 -07:00
dependabot[bot]
3eca77ad00
Bump flipper-ui, flipper-active_record, flipper-active_support_cache_store, flipper, flipper, flipper, flipper and flipper ( #16630 )
...
Bumps [flipper-ui](https://github.com/jnunemaker/flipper ), [flipper-active_record](https://github.com/jnunemaker/flipper ), [flipper-active_support_cache_store](https://github.com/jnunemaker/flipper ), [flipper](https://github.com/jnunemaker/flipper ), [flipper](https://github.com/jnunemaker/flipper ), [flipper](https://github.com/jnunemaker/flipper ), [flipper](https://github.com/jnunemaker/flipper ) and [flipper](https://github.com/jnunemaker/flipper ). These dependencies needed to be updated together.
Updates `flipper-ui` from 0.23.1 to 0.24.0
- [Release notes](https://github.com/jnunemaker/flipper/releases )
- [Changelog](https://github.com/jnunemaker/flipper/blob/master/Changelog.md )
- [Commits](https://github.com/jnunemaker/flipper/compare/v0.23.1...v0.24.0 )
Updates `flipper-active_record` from 0.23.1 to 0.24.0
- [Release notes](https://github.com/jnunemaker/flipper/releases )
- [Changelog](https://github.com/jnunemaker/flipper/blob/master/Changelog.md )
- [Commits](https://github.com/jnunemaker/flipper/compare/v0.23.1...v0.24.0 )
Updates `flipper-active_support_cache_store` from 0.23.1 to 0.24.0
- [Release notes](https://github.com/jnunemaker/flipper/releases )
- [Changelog](https://github.com/jnunemaker/flipper/blob/master/Changelog.md )
- [Commits](https://github.com/jnunemaker/flipper/compare/v0.23.1...v0.24.0 )
Updates `flipper` from 0.23.1 to 0.24.0
- [Release notes](https://github.com/jnunemaker/flipper/releases )
- [Changelog](https://github.com/jnunemaker/flipper/blob/master/Changelog.md )
- [Commits](https://github.com/jnunemaker/flipper/compare/v0.23.1...v0.24.0 )
Updates `flipper` from 0.23.1 to 0.24.0
- [Release notes](https://github.com/jnunemaker/flipper/releases )
- [Changelog](https://github.com/jnunemaker/flipper/blob/master/Changelog.md )
- [Commits](https://github.com/jnunemaker/flipper/compare/v0.23.1...v0.24.0 )
Updates `flipper` from 0.23.1 to 0.24.0
- [Release notes](https://github.com/jnunemaker/flipper/releases )
- [Changelog](https://github.com/jnunemaker/flipper/blob/master/Changelog.md )
- [Commits](https://github.com/jnunemaker/flipper/compare/v0.23.1...v0.24.0 )
Updates `flipper` from 0.23.1 to 0.24.0
- [Release notes](https://github.com/jnunemaker/flipper/releases )
- [Changelog](https://github.com/jnunemaker/flipper/blob/master/Changelog.md )
- [Commits](https://github.com/jnunemaker/flipper/compare/v0.23.1...v0.24.0 )
Updates `flipper` from 0.23.1 to 0.24.0
- [Release notes](https://github.com/jnunemaker/flipper/releases )
- [Changelog](https://github.com/jnunemaker/flipper/blob/master/Changelog.md )
- [Commits](https://github.com/jnunemaker/flipper/compare/v0.23.1...v0.24.0 )
---
updated-dependencies:
- dependency-name: flipper-ui
dependency-type: direct:production
update-type: version-update:semver-minor
- dependency-name: flipper-active_record
dependency-type: direct:production
update-type: version-update:semver-minor
- dependency-name: flipper-active_support_cache_store
dependency-type: direct:production
update-type: version-update:semver-minor
- dependency-name: flipper
dependency-type: direct:production
update-type: version-update:semver-minor
- dependency-name: flipper
dependency-type: direct:production
update-type: version-update:semver-minor
- dependency-name: flipper
dependency-type: direct:production
update-type: version-update:semver-minor
- dependency-name: flipper
dependency-type: direct:production
update-type: version-update:semver-minor
- dependency-name: flipper
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-02-18 14:58:06 -05:00
Julianna Tetreault
b8a87b842b
Implement Tabs for the Admin Member Detail View ( #16640 )
...
* WIP: Adds tabs to the Admin Member Detail View
* WIP: Adds tabs in the least elegant way to Admin Member Detail View
* WIP: Comments out unused code
* WIP: Initial code set up for tabs
* feat: add a tab param to the route
* feat: set the current tab and direct to the overview tab in all other cases
* chore: remove all other unused code
* Renames @tab to @current_tab and MemberDetails to UserDetails
* Removes unused route and reverts renaming of params
* Removes unused route from admin.rb
* Adds an E2E test that tests tabbing through Admin Member Detail tabs
* Updates navigateTabs E2E and _tabs.html.erb per feedback
* Updates tnavigateTabs.spec.js
* Updates navigateTabs.spec.js per Suzannes suggestion :)
* Removes useless comment from Admin::UsersController
Co-authored-by: Ridhwana <ridhwana.khan16@gmail.com>
2022-02-18 10:47:53 -07:00
Suzanne Aitchison
b358c3810c
Revert "Only make one network call to fetch all existing tags in editor ( #16610 )" ( #16641 )
...
This reverts commit c76909a428
2022-02-18 11:54:38 +00:00
Suzanne Aitchison
46404ed8c2
Add new color picker to user settings page ( #16625 )
2022-02-18 08:43:56 +00:00
