Update device_detector, remove warning workaround (#16665)

Co-authored-by: Dan Uber <dan@forem.com>

Gemfile

@@ -107,7 +107,6 @@ gem "twitter", "~> 7.0" # A Ruby interface to the Twitter API
 gem "uglifier", "~> 4.2" # Uglifier minifies JavaScript files
 gem "validate_url", "~> 1.0" # Library for validating urls in Rails
 gem "vault", "~> 0.16" # Used to store secrets
-gem "warning", "~> 1.2" # Adds custom processing for warnings, including the ability to ignore specific warning messages
 gem "wcag_color_contrast", "~> 0.1" # Detect contrast of colors to determine readability and a11y.
 gem "webpacker", "~> 5.4.3" # Use webpack to manage app-like JavaScript modules in Rails
 

Gemfile.lock

@@ -196,7 +196,7 @@ GEM
       rake (> 10, < 14)
       ruby-statistics (>= 2.1)
       thor (>= 0.19, < 2)
-    device_detector (1.0.6)
+    device_detector (1.0.7)
     devise (4.8.1)
       bcrypt (~> 3.0)
       orm_adapter (~> 0.1)
@@ -851,7 +851,6 @@ GEM
     vcr (6.0.0)
     warden (1.2.9)
       rack (>= 2.0.9)
-    warning (1.2.1)
     wcag_color_contrast (0.1.0)
     web-console (4.2.0)
       actionview (>= 6.0.0)
@@ -1037,7 +1036,6 @@ DEPENDENCIES
   validate_url (~> 1.0)
   vault (~> 0.16)
   vcr (~> 6.0)
-  warning (~> 1.2)
   wcag_color_contrast (~> 0.1)
   web-console (~> 4.2)
   webdrivers (~> 5.0)

config/initializers/warning.rb

@@ -1,6 +0,0 @@
-# Avoid this warning since it's unlikely to be fixed upstream.
-# See: https://github.com/podigee/device_detector/issues/91
-if (device_detector_source_path = Gem.loaded_specs["device_detector"]&.full_gem_path)
-  parser_source_file_path = Pathname.new(device_detector_source_path) / "lib/device_detector/parser.rb"
-  Warning.ignore(/regular expression/, parser_source_file_path.to_s)
-end