✂️ Remove myself from core contributors (#16672)

* Remove myself from core contributors

* Update comments

* Update more comments
This commit is contained in:
Michael Kohl 2022-02-25 21:56:19 +07:00 committed by GitHub
parent 0fd55d1c14
commit 3322b49e84
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
7 changed files with 8 additions and 10 deletions

View file

@ -122,7 +122,6 @@ Please see our installation guides, such as the
- [@zhao-andy](https://dev.to/andy)
- [@lightalloy](https://dev.to/lightalloy)
- [@atsmith813](https://dev.to/atsmith813)
- [@citizen428](https://dev.to/citizen428)
- [@nickytonline](https://dev.to/nickytonline)
- [@joshpuetz](http://dev.to/joshpuetz)
- [@juliannatetreault](https://dev.to/juliannatetreault)

View file

@ -253,8 +253,7 @@ class Article < ApplicationRecord
end
}
# NOTE: @citizen428
# I'd usually avoid using Arel directly like this. However, none of the more
# We usually try to avoid using Arel directly like this. However, none of the more
# straight-forward ways of negating the above scope worked:
# 1. A subquery doesn't work because we're not dealing with a simple NOT IN scenario.
# 2. where.not(cached_tagged_with_any(tags).where_values_hash) doesn't work because where_values_hash

View file

@ -7,8 +7,8 @@ module Users
def initialize(user, given_tag)
@user = user
@given_tag = given_tag
# TODO: @citizen428 - I just moved this code from elsewhere, but 25 seems
# to be geared towards DEV and may not work for smaller communities.
# TODO: This code got moved from elsewhere, but 25 seems to be geared
# towards DEV and may not work for smaller communities.
@minimum_reaction_count = Rails.env.production? ? 25 : 0
end

View file

@ -130,7 +130,7 @@ Rails.application.configure do
Bullet.add_safelist(type: :unused_eager_loading, class_name: "Article", association: :top_comments)
Bullet.add_safelist(type: :unused_eager_loading, class_name: "Article", association: :collection)
Bullet.add_safelist(type: :unused_eager_loading, class_name: "Comment", association: :user)
# NOTE: @citizen428 Temporarily ignoring this while working out user - profile relationship
# TODO: Temporarily ignoring this while working out user - profile relationship
Bullet.add_safelist(type: :n_plus_one_query, class_name: "User", association: :profile)
# Check if there are any data update scripts to run during startup

View file

@ -83,7 +83,7 @@ Rails.application.configure do
Bullet.add_safelist(type: :unused_eager_loading, class_name: "Article", association: :top_comments)
Bullet.add_safelist(type: :unused_eager_loading, class_name: "Article", association: :collection)
Bullet.add_safelist(type: :unused_eager_loading, class_name: "Comment", association: :user)
# @citizen428: We have not yet resolved all user - profile preloads related to profile generalization
# TODO: We have not yet resolved all user - profile preloads related to profile generalization
Bullet.add_safelist(type: :n_plus_one_query, class_name: "User", association: :profile)
Bullet.add_safelist(type: :n_plus_one_query, class_name: "Profile", association: :user)
Bullet.add_safelist(type: :n_plus_one_query, class_name: "User", association: :setting)

View file

@ -97,8 +97,8 @@ namespace :admin do
resources :navigation_links, only: %i[index update create destroy]
resources :pages, only: %i[index new create edit update destroy]
# NOTE: @citizen428 The next two resources have a temporary constraint
# while profile generalization is still WIP
# NOTE: The next two resources have a temporary constraint while profile
# generalization is still WIP
constraints(->(_request) { FeatureFlag.enabled?(:profile_admin) }) do
resources :profile_field_groups, only: %i[update create destroy]
resources :profile_fields, only: %i[index update create destroy]

View file

@ -6,7 +6,7 @@ describe('Set a landing page from the admin portal', () => {
cy.loginAndVisit(user, '/admin/customization/config').then(() => {
cy.get('#new_settings_user_experience').as('userExperienceSectionForm');
// Ensure Forem instance is private
// NOTE: @citizen428 - We may need to find a better situation for this
// NOTE: We may need to find a better situation for this
// long-term.
cy.get('@userExperienceSectionForm')