From 3322b49e844cf470124c1dca951f7cb01a57f0ed Mon Sep 17 00:00:00 2001 From: Michael Kohl Date: Fri, 25 Feb 2022 21:56:19 +0700 Subject: [PATCH] =?UTF-8?q?=E2=9C=82=EF=B8=8F=20=20Remove=20myself=20from?= =?UTF-8?q?=20core=20contributors=20(#16672)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * Remove myself from core contributors * Update comments * Update more comments --- README.md | 1 - app/models/article.rb | 3 +-- app/services/users/suggest_for_sidebar.rb | 4 ++-- config/environments/development.rb | 2 +- config/environments/test.rb | 2 +- config/routes/admin.rb | 4 ++-- .../seededFlows/adminFlows/pages/landingPage.spec.js | 2 +- 7 files changed, 8 insertions(+), 10 deletions(-) diff --git a/README.md b/README.md index fba8c32be..a5d64e584 100644 --- a/README.md +++ b/README.md @@ -122,7 +122,6 @@ Please see our installation guides, such as the - [@zhao-andy](https://dev.to/andy) - [@lightalloy](https://dev.to/lightalloy) - [@atsmith813](https://dev.to/atsmith813) -- [@citizen428](https://dev.to/citizen428) - [@nickytonline](https://dev.to/nickytonline) - [@joshpuetz](http://dev.to/joshpuetz) - [@juliannatetreault](https://dev.to/juliannatetreault) diff --git a/app/models/article.rb b/app/models/article.rb index 5b517a1e9..eb603d216 100644 --- a/app/models/article.rb +++ b/app/models/article.rb @@ -253,8 +253,7 @@ class Article < ApplicationRecord end } - # NOTE: @citizen428 - # I'd usually avoid using Arel directly like this. However, none of the more + # We usually try to avoid using Arel directly like this. However, none of the more # straight-forward ways of negating the above scope worked: # 1. A subquery doesn't work because we're not dealing with a simple NOT IN scenario. # 2. where.not(cached_tagged_with_any(tags).where_values_hash) doesn't work because where_values_hash diff --git a/app/services/users/suggest_for_sidebar.rb b/app/services/users/suggest_for_sidebar.rb index 94742c1a2..278c4449f 100644 --- a/app/services/users/suggest_for_sidebar.rb +++ b/app/services/users/suggest_for_sidebar.rb @@ -7,8 +7,8 @@ module Users def initialize(user, given_tag) @user = user @given_tag = given_tag - # TODO: @citizen428 - I just moved this code from elsewhere, but 25 seems - # to be geared towards DEV and may not work for smaller communities. + # TODO: This code got moved from elsewhere, but 25 seems to be geared + # towards DEV and may not work for smaller communities. @minimum_reaction_count = Rails.env.production? ? 25 : 0 end diff --git a/config/environments/development.rb b/config/environments/development.rb index 08f2d15ba..2f45c39cb 100644 --- a/config/environments/development.rb +++ b/config/environments/development.rb @@ -130,7 +130,7 @@ Rails.application.configure do Bullet.add_safelist(type: :unused_eager_loading, class_name: "Article", association: :top_comments) Bullet.add_safelist(type: :unused_eager_loading, class_name: "Article", association: :collection) Bullet.add_safelist(type: :unused_eager_loading, class_name: "Comment", association: :user) - # NOTE: @citizen428 Temporarily ignoring this while working out user - profile relationship + # TODO: Temporarily ignoring this while working out user - profile relationship Bullet.add_safelist(type: :n_plus_one_query, class_name: "User", association: :profile) # Check if there are any data update scripts to run during startup diff --git a/config/environments/test.rb b/config/environments/test.rb index 72ad06680..2d99316ed 100644 --- a/config/environments/test.rb +++ b/config/environments/test.rb @@ -83,7 +83,7 @@ Rails.application.configure do Bullet.add_safelist(type: :unused_eager_loading, class_name: "Article", association: :top_comments) Bullet.add_safelist(type: :unused_eager_loading, class_name: "Article", association: :collection) Bullet.add_safelist(type: :unused_eager_loading, class_name: "Comment", association: :user) - # @citizen428: We have not yet resolved all user - profile preloads related to profile generalization + # TODO: We have not yet resolved all user - profile preloads related to profile generalization Bullet.add_safelist(type: :n_plus_one_query, class_name: "User", association: :profile) Bullet.add_safelist(type: :n_plus_one_query, class_name: "Profile", association: :user) Bullet.add_safelist(type: :n_plus_one_query, class_name: "User", association: :setting) diff --git a/config/routes/admin.rb b/config/routes/admin.rb index 3c47504ef..c2f16a37d 100644 --- a/config/routes/admin.rb +++ b/config/routes/admin.rb @@ -97,8 +97,8 @@ namespace :admin do resources :navigation_links, only: %i[index update create destroy] resources :pages, only: %i[index new create edit update destroy] - # NOTE: @citizen428 The next two resources have a temporary constraint - # while profile generalization is still WIP + # NOTE: The next two resources have a temporary constraint while profile + # generalization is still WIP constraints(->(_request) { FeatureFlag.enabled?(:profile_admin) }) do resources :profile_field_groups, only: %i[update create destroy] resources :profile_fields, only: %i[index update create destroy] diff --git a/cypress/integration/seededFlows/adminFlows/pages/landingPage.spec.js b/cypress/integration/seededFlows/adminFlows/pages/landingPage.spec.js index 8a184bd21..8cc43792e 100644 --- a/cypress/integration/seededFlows/adminFlows/pages/landingPage.spec.js +++ b/cypress/integration/seededFlows/adminFlows/pages/landingPage.spec.js @@ -6,7 +6,7 @@ describe('Set a landing page from the admin portal', () => { cy.loginAndVisit(user, '/admin/customization/config').then(() => { cy.get('#new_settings_user_experience').as('userExperienceSectionForm'); // Ensure Forem instance is private - // NOTE: @citizen428 - We may need to find a better situation for this + // NOTE: We may need to find a better situation for this // long-term. cy.get('@userExperienceSectionForm')