docbrown/spec/requests
Lawrence 0c93bde6c2
Subscribe to Comment Functionality (#19555)
* Move save over and add button labels

* comment notification design and functionality

* controller error handling

* add ternery operator for background class

* minor cleanup

* add proper styling toggles

* tests and mobile spec

* add for all buttons

* add article as a param

* comment is not required on article preview

* update policy spec

* add test for coverage

* add proper button titles

* use the last user comment as comment id

* add better error handling and remove multiple fetch calls in js

* copy change to threads

* update copy, fix multiple fetch calls, add observer for loading more notifications

* update spec

* add rspecs

* more test specs

* fix test specs

* subscribe button text tests

* add export

* optimistically update ui function tests

* button initialize test

* check for comment ancestry

* add feature flag block

* some cleanup

* update logic and specs

* oops

* rubocop issues

* change config names

* change config names

* fix spec

* add one more conditional

* check for comments

* service-object the toggler

* separate routes

* continual refactoring

* refine spec tests

* clean up policy

* Adjust js and view files to match be params

* some service object refactoring

* separate endpoints on client-side

* broken spec

* service specs

* policy spec fixes

* remove action param

* remove action param from spec

* minor updates

* trigger build

* update to post

* Services don't need permitted params

* Notifications continue to be a mess, decorator specs to follow

* Not toggling now

* This doesn't really belong here

* Fix tests after moving

* Streamline front-end

* There could be errors?

* polymorphic_name is a class thing

* ☠️ json_data in notification views

* Use feature_flag helper to get current_user

* Cannot derive current subscription status from notification, only from subscription

* Default is subscribe to all article comments

* Sync up matching unsubscribe, make subscribe idempotent-ish

* Temporarily comment-out button jest tests to see if I can unstick CI

* Stop trying to detect potential subscribe-to-comment

* Stop trying to detect potential subscribe-to-comment

* Minor spec refactoring

* Add specs for article notification decoration

* NotificationDecorator specs are rather long

* Rubocop likes it?

* Minor spec refactoring

* Doesn't need to stay pending

* Add spec for subscription finder

* Expand Subscribe service specs

* YAGNI, but I don't like hard-coded config

* Refactor Unsubscribe service specs

* nobody expects the infinite scroll

* This *might* work, except for feature flag

* Ancestry can be quite deep actually

* Rubocop

* Update subscribe button for subscribe-to-thread

* Jest tests are just tests

* hasAttribute != getAttribute

* Test knows **nothing** about window size

* Tests have been lying about mobileLabel this whole time

* Make payload/endpoint testable

* Is Jest actually happy???

* Still cleaning up jest/eslint

* Temporarily comment-out cypress tests pending feature flag

* Thanks, Rubocop, what would we do without you

* Preserve round-trip for 'top-level' and 'only-author' subscriptions

* Update specs

* Move save button icon

* Update test with better config param

* Try feature flag specific to cypress env

* Tell cypress to wait for (un)subscribing to work

---------

Co-authored-by: Lawrence S <lawrence@forem.com>
Co-authored-by: Joshua Wehner <joshua@forem.com>
2023-07-10 17:11:46 +02:00
..
admin Rename Admin::DisplayAds controller to Billboards (#19687) 2023-07-07 08:11:35 -04:00
api Follow-ups for suggested organizations follows during onboarding (#19619) 2023-06-29 11:49:01 +02:00
articles Upgrade ruby 3.0.6 (#19651) 2023-07-06 16:42:20 -04:00
incoming_webhooks/mailchimp Rubocop fixes in spec/requests (#18946) 2023-01-12 19:10:16 +03:00
notifications Rubocop fixes in spec/requests (#18946) 2023-01-12 19:10:16 +03:00
podcasts Rubocop fixes in spec/requests (#18946) 2023-01-12 19:10:16 +03:00
shared_examples Routine rubocop fix on /spec (#19217) 2023-03-21 09:55:26 -04:00
stories Upgrade ruby 3.0.6 (#19651) 2023-07-06 16:42:20 -04:00
user Add organizations to onboarding follow suggestions (#19564) 2023-06-09 10:32:03 +02:00
api_secrets_create_spec.rb Rubocop fixes in spec/requests (#18946) 2023-01-12 19:10:16 +03:00
api_secrets_destroy_spec.rb Rubocop fixes in spec/requests (#18946) 2023-01-12 19:10:16 +03:00
article_approvals_spec.rb Rubocop fixes in spec/requests (#18946) 2023-01-12 19:10:16 +03:00
async_info_spec.rb Async Hamburger Menu Implementation + Caching Optimizations (#18818) 2022-12-20 20:00:08 +02:00
badges_spec.rb Rubocop fixes in spec/requests (#18946) 2023-01-12 19:10:16 +03:00
collections_spec.rb Rubocop fixes in spec/requests (#18946) 2023-01-12 19:10:16 +03:00
comments_create_spec.rb Rubocop fixes in spec/requests (#18946) 2023-01-12 19:10:16 +03:00
comments_destroy_spec.rb Rubocop fixes in spec/requests (#18946) 2023-01-12 19:10:16 +03:00
comments_spec.rb Prevent comments by the staff account from being hidden (#19698) 2023-07-10 11:46:46 +01:00
comments_update_spec.rb Rubocop fixes in spec/requests (#18946) 2023-01-12 19:10:16 +03:00
credits_spec.rb Rubocop fixes in spec/requests (#18946) 2023-01-12 19:10:16 +03:00
dashboard_spec.rb Rubocop fixes in spec/requests (#18946) 2023-01-12 19:10:16 +03:00
devices_spec.rb Rubocop fixes in spec/requests (#18946) 2023-01-12 19:10:16 +03:00
discussion_locks_spec.rb Rubocop fixes in spec/requests (#18946) 2023-01-12 19:10:16 +03:00
display_ad_events_spec.rb Rubocop fixes in spec/requests (#18946) 2023-01-12 19:10:16 +03:00
display_ads_spec.rb Load post_comments billboard asynchronously (#19285) 2023-04-12 18:15:15 +02:00
editor_spec.rb Consistent rendering on preview: comments and articles (#19361) 2023-04-27 14:08:15 +03:00
email_subscriptions_spec.rb Rubocop fixes in spec/requests (#18946) 2023-01-12 19:10:16 +03:00
feedback_messages_spec.rb Rubocop fixes in spec/requests (#18946) 2023-01-12 19:10:16 +03:00
followings_spec.rb Rubocop fixes in spec/requests (#18946) 2023-01-12 19:10:16 +03:00
follows_bulk_show_spec.rb Rubocop fixes in spec/requests (#18946) 2023-01-12 19:10:16 +03:00
follows_bulk_update_spec.rb Rubocop fixes in spec/requests (#18946) 2023-01-12 19:10:16 +03:00
follows_create_spec.rb Routine rubocop fix on /spec (#19217) 2023-03-21 09:55:26 -04:00
follows_show_spec.rb Expands Follows request specs (#19096) 2023-02-10 09:02:38 -05:00
ga_events_spec.rb Rubocop fixes in spec/requests (#18946) 2023-01-12 19:10:16 +03:00
github_repos_spec.rb Rubocop fixes in spec/requests (#18946) 2023-01-12 19:10:16 +03:00
image_uploads_spec.rb Rubocop fixes in spec/requests (#18946) 2023-01-12 19:10:16 +03:00
invitations_spec.rb Rubocop fixes in spec/requests (#18946) 2023-01-12 19:10:16 +03:00
liquid_embeds_spec.rb Rubocop fixes in spec/requests (#18946) 2023-01-12 19:10:16 +03:00
liquid_tags_request_spec.rb Rubocop fixes in spec/requests (#18946) 2023-01-12 19:10:16 +03:00
listings_spec.rb Rubocop fixes in spec/requests (#18946) 2023-01-12 19:10:16 +03:00
moderations_spec.rb Rubocop fixes in spec/requests (#18946) 2023-01-12 19:10:16 +03:00
notification_counts_spec.rb Rubocop fixes in spec/requests (#18946) 2023-01-12 19:10:16 +03:00
notification_subscriptions_spec.rb Subscribe to Comment Functionality (#19555) 2023-07-10 17:11:46 +02:00
notifications_spec.rb notify mod on new user articles (#19478) 2023-05-23 10:51:46 -04:00
onboardings_spec.rb Follow-ups for suggested organizations follows during onboarding (#19619) 2023-06-29 11:49:01 +02:00
open_search_spec.rb Rubocop fixes in spec/requests (#18946) 2023-01-12 19:10:16 +03:00
organizations_update_spec.rb Remove Dark and Light Nav Logo Image from Organization (#19309) 2023-05-08 17:01:03 -04:00
page_views_spec.rb Rubocop fixes in spec/requests (#18946) 2023-01-12 19:10:16 +03:00
pages_spec.rb Rubocop fixes in spec/requests (#18946) 2023-01-12 19:10:16 +03:00
poll_skips_spec.rb Rubocop fixes in spec/requests (#18946) 2023-01-12 19:10:16 +03:00
poll_votes_spec.rb Routine rubocop fix on /spec (#19217) 2023-03-21 09:55:26 -04:00
profile_field_groups_request_spec.rb Rubocop fixes in spec/requests (#18946) 2023-01-12 19:10:16 +03:00
profile_pins_spec.rb Rubocop fixes in spec/requests (#18946) 2023-01-12 19:10:16 +03:00
profile_preview_cards_spec.rb Rubocop fixes in spec/requests (#18946) 2023-01-12 19:10:16 +03:00
profiles_request_spec.rb Rubocop fixes in spec/requests (#18946) 2023-01-12 19:10:16 +03:00
rating_votes_spec.rb Rubocop fixes in spec/requests (#18946) 2023-01-12 19:10:16 +03:00
reactions_spec.rb Cleanup multiple reactions feature flag (#19257) 2023-04-07 17:14:10 +02:00
reading_list_items_spec.rb Rubocop fixes in spec/requests (#18946) 2023-01-12 19:10:16 +03:00
registrations_spec.rb Rubocop fixes in spec/requests (#18946) 2023-01-12 19:10:16 +03:00
response_templates_spec.rb Routine rubocop fix on /spec (#19217) 2023-03-21 09:55:26 -04:00
search_spec.rb Rubocop fixes in spec/requests (#18946) 2023-01-12 19:10:16 +03:00
sidebars_spec.rb Rubocop fixes in spec/requests (#18946) 2023-01-12 19:10:16 +03:00
sitemaps_spec.rb Rubocop fixes in spec/requests (#18946) 2023-01-12 19:10:16 +03:00
social_previews_spec.rb Rubocop fixes in spec/requests (#18946) 2023-01-12 19:10:16 +03:00
stories_index_spec.rb Resolves false-positive UnsafeRedirectError (#19297) 2023-04-07 09:17:56 -04:00
stories_show_spec.rb Rubocop fixes in spec/requests (#18946) 2023-01-12 19:10:16 +03:00
stripe_active_cards_spec.rb Rubocop fixes in spec/requests (#18946) 2023-01-12 19:10:16 +03:00
tag_adjustments_spec.rb Rubocop fixes in spec/requests (#18946) 2023-01-12 19:10:16 +03:00
tags_spec.rb Refactoring onboarding (#19525) 2023-05-25 10:03:12 +02:00
universal_links_spec.rb Routine rubocop fix on /spec (#19217) 2023-03-21 09:55:26 -04:00
user_blocks_spec.rb Rubocop fixes in spec/requests (#18946) 2023-01-12 19:10:16 +03:00
user_subscriptions_spec.rb Rubocop fixes in spec/requests (#18946) 2023-01-12 19:10:16 +03:00
video_states_update_spec.rb Rubocop fixes in spec/requests (#18946) 2023-01-12 19:10:16 +03:00
videos_spec.rb Rubocop fixes in spec/requests (#18946) 2023-01-12 19:10:16 +03:00