Rubocop fixes in spec/requests (#18946)

* Rubocop fixes in spec/requests

* Fixed spec/requests/api/v0/articles_spec.rb

Co-authored-by: Ridhwana <Ridhwana.Khan16@gmail.com>

Co-authored-by: Ridhwana <Ridhwana.Khan16@gmail.com>

spec/requests/admin/articles_spec.rb

@@ -1,7 +1,7 @@
 require "rails_helper"
 require "requests/shared_examples/internal_policy_dependant_request"
 
-RSpec.describe "/admin/content_manager/articles", type: :request do
+RSpec.describe "/admin/content_manager/articles" do
   let(:super_admin) { create(:user, :super_admin) }
   let(:article) { create(:article) }
 

spec/requests/admin/badge_achievements_spec.rb

@@ -1,7 +1,7 @@
 require "rails_helper"
 require "requests/shared_examples/internal_policy_dependant_request"
 
-RSpec.describe "/admin/content_manager/badge_achievements", type: :request do
+RSpec.describe "/admin/content_manager/badge_achievements" do
   let(:admin) { create(:user, :super_admin) }
   let!(:badge) { create(:badge, title: "Not 'Hello, world!'") }
   let(:params) do

spec/requests/admin/badges_spec.rb

@@ -1,7 +1,7 @@
 require "rails_helper"
 require "requests/shared_examples/internal_policy_dependant_request"
 
-RSpec.describe "/admin/content_manager/badge_achievements", type: :request do
+RSpec.describe "/admin/content_manager/badge_achievements" do
   let(:admin) { create(:user, :super_admin) }
   let!(:badge) { create(:badge, title: "Not 'Hello, world!'") }
   let(:params) do

spec/requests/admin/broadcasts_spec.rb

@@ -1,7 +1,7 @@
 require "rails_helper"
 require "requests/shared_examples/internal_policy_dependant_request"
 
-RSpec.describe "/admin/advanced/broadcasts", type: :request do
+RSpec.describe "/admin/advanced/broadcasts" do
   let(:get_resource) { get admin_broadcasts_path }
   let(:params) { { title: "Hello!", processed_html: "<p>Hello!</p>", type_of: "Welcome", active: true } }
   let(:post_resource) { post admin_broadcasts_path, params: params }

spec/requests/admin/comments_spec.rb

@@ -1,7 +1,7 @@
 require "rails_helper"
 require "requests/shared_examples/internal_policy_dependant_request"
 
-RSpec.describe "/admin/content_manager/comments", type: :request do
+RSpec.describe "/admin/content_manager/comments" do
   it_behaves_like "an InternalPolicy dependant request", Comment do
     let(:request) { get admin_comments_path }
   end

spec/requests/admin/configs_spec.rb

@@ -1,6 +1,6 @@
 require "rails_helper"
 
-RSpec.describe "/admin/customization/config", type: :request do
+RSpec.describe "/admin/customization/config" do
   let(:user) { create(:user) }
   let(:admin) { create(:user, :admin) }
   let(:super_admin) { create(:user, :super_admin) }

spec/requests/admin/consumer_apps_spec.rb

@@ -1,7 +1,7 @@
 require "rails_helper"
 require "requests/shared_examples/internal_policy_dependant_request"
 
-RSpec.describe "Admin - Consumer Apps", type: :request do
+RSpec.describe "Admin - Consumer Apps" do
   let(:get_resource) { get admin_consumer_apps_path }
   let(:params) do
     {

spec/requests/admin/creator_settings_spec.rb

@@ -1,6 +1,6 @@
 require "rails_helper"
 
-RSpec.describe "/creator_settings/new", type: :request do
+RSpec.describe "/creator_settings/new" do
   let!(:current_user) { create(:user, :creator) }
   let!(:non_admin_user) { create(:user) }
   let(:params) do

spec/requests/admin/data_update_scripts_spec.rb

@@ -1,6 +1,6 @@
 require "rails_helper"
 
-RSpec.describe "/admin/advanced/data_update_scripts", type: :request do
+RSpec.describe "/admin/advanced/data_update_scripts" do
   let(:get_resource) { get admin_data_update_scripts_path }
 
   context "when the user is not an tech admin" do

spec/requests/admin/display_ads_spec.rb

@@ -1,7 +1,7 @@
 require "rails_helper"
 require "requests/shared_examples/internal_policy_dependant_request"
 
-RSpec.describe "/admin/customization/display_ads", type: :request do
+RSpec.describe "/admin/customization/display_ads" do
   let(:get_resource) { get admin_display_ads_path }
   let(:org) { create(:organization) }
   let(:params) do

spec/requests/admin/extensions_spec.rb

@@ -1,6 +1,6 @@
 require "rails_helper"
 
-RSpec.describe "/admin/advanced/extensions", type: :request do
+RSpec.describe "/admin/advanced/extensions" do
   let(:admin) { create(:user, :super_admin) }
 
   before do

spec/requests/admin/feed_playground_spec.rb

@@ -1,6 +1,6 @@
 require "rails_helper"
 
-RSpec.describe "/admin/advanced/tools/feed_playground", type: :request do
+RSpec.describe "/admin/advanced/tools/feed_playground" do
   describe "GET /admin/advanced/tools/feed_playground" do
     context "when the user is not an admin" do
       let(:user) { create(:user) }

spec/requests/admin/feedback_messages_spec.rb

@@ -1,6 +1,6 @@
 require "rails_helper"
 
-RSpec.describe "/admin/moderation/reports", type: :request do
+RSpec.describe "/admin/moderation/reports" do
   let(:feedback_message)  { create(:feedback_message, :abuse_report) }
   let(:user)              { create(:user) }
   let(:trusted_user)      { create(:user, :trusted) }

spec/requests/admin/gdpr_delete_requests_spec.rb

@@ -1,6 +1,6 @@
 require "rails_helper"
 
-RSpec.describe "/admin/member_manager/gdpr_delete_requests", type: :request do
+RSpec.describe "/admin/member_manager/gdpr_delete_requests" do
   let(:admin) { create(:user, :super_admin) }
 
   before do

spec/requests/admin/html_variants_spec.rb

@@ -1,7 +1,7 @@
 require "rails_helper"
 require "requests/shared_examples/internal_policy_dependant_request"
 
-RSpec.describe "/admin/customization/html_variants", type: :request do
+RSpec.describe "/admin/customization/html_variants" do
   let(:get_resource) { get admin_html_variants_path }
   let(:params) do
     { name: "Banner", html: "<h1>Hello HTML Variants!</h1>", group: "campaign",

spec/requests/admin/invitations_spec.rb

@@ -1,6 +1,6 @@
 require "rails_helper"
 
-RSpec.describe "/admin/member_manager/invitations", type: :request do
+RSpec.describe "/admin/member_manager/invitations" do
   let(:user) { create(:user) }
   let(:admin) { create(:user, :super_admin) }
 

spec/requests/admin/listings_categories_spec.rb

@@ -1,7 +1,7 @@
 require "rails_helper"
 require "requests/shared_examples/internal_policy_dependant_request"
 
-RSpec.describe "/admin/app/listings/categories", type: :request do
+RSpec.describe "/admin/app/listings/categories" do
   let(:get_resource) { get admin_listing_categories_path }
   let(:params) do
     { name: "Computer stuff", cost: 22, rules: "Things computers do",

spec/requests/admin/listings_spec.rb

@@ -1,6 +1,6 @@
 require "rails_helper"
 
-RSpec.describe "/admin/apps/listings", type: :request do
+RSpec.describe "/admin/apps/listings" do
   let(:admin) { create(:user, :super_admin) }
   let!(:listing) { create(:listing, user_id: admin.id) }
 

spec/requests/admin/moderator_actions_spec.rb

@@ -1,6 +1,6 @@
 require "rails_helper"
 
-RSpec.describe "/admin/moderation/moderator_reactions", type: :request do
+RSpec.describe "/admin/moderation/moderator_reactions" do
   context "when the user is not an admin" do
     let(:user) { create(:user) }
 

spec/requests/admin/moderator_logs_spec.rb

@@ -1,6 +1,6 @@
 require "rails_helper"
 
-RSpec.describe "/admin/content_manager/tags", type: :request do
+RSpec.describe "/admin/content_manager/tags" do
   let(:super_admin) { create(:user, :super_admin) }
   let(:tag_moderator) { build_stubbed(:user) }
   let!(:tag) { create(:tag) }

spec/requests/admin/mods_spec.rb

@@ -1,6 +1,6 @@
 require "rails_helper"
 
-RSpec.describe "/admin/moderation/mods", type: :request do
+RSpec.describe "/admin/moderation/mods" do
   let!(:admin) { create(:user, :admin) }
   let!(:regular_user) { create(:user) }
   let!(:moderator) { create(:user, :trusted) }

spec/requests/admin/navigation_link_spec.rb

@@ -1,6 +1,6 @@
 require "rails_helper"
 
-RSpec.describe "NavigationLinks", type: :request do
+RSpec.describe "NavigationLinks" do
   let(:admin) { create(:user, :super_admin) }
 
   before do

spec/requests/admin/nested_sidebar_spec.rb

@@ -1,6 +1,6 @@
 require "rails_helper"
 
-RSpec.describe "admin sidebar", type: :request do
+RSpec.describe "admin sidebar" do
   let(:super_admin) { create(:user, :super_admin) }
 
   before do

spec/requests/admin/organization_memberships_spec.rb

@@ -1,6 +1,6 @@
 require "rails_helper"
 
-RSpec.describe "/admin/organization_memberships", type: :request do
+RSpec.describe "/admin/organization_memberships" do
   let(:admin) { create(:user, :super_admin) }
   let(:user) { create(:user) }
   let(:organization) { create(:organization) }

spec/requests/admin/organizations_spec.rb

@@ -1,11 +1,11 @@
 require "rails_helper"
 
-RSpec.describe "/admin/content_manager/organizations", type: :request do
+RSpec.describe "/admin/content_manager/organizations" do
   let(:admin) { create(:user, :super_admin) }
   let(:organization) { Organization.first }
 
   before do
-    create_list :organization, 5
+    create_list(:organization, 5)
     sign_in(admin)
   end
 

spec/requests/admin/overview_spec.rb

@@ -1,6 +1,6 @@
 require "rails_helper"
 
-RSpec.describe "/admin", type: :request do
+RSpec.describe "/admin" do
   let(:super_admin) { create(:user, :super_admin) }
 
   before do
@@ -38,9 +38,12 @@ RSpec.describe "/admin", type: :request do
 
     it { is_expected.to include("Analytics and trends") }
     it { is_expected.to include("Yesterday") }
-    xit { is_expected.to include("Apr 23") }
 
-    xit "displays correct number of posts from past week" do
+    it "includes date", skip: "timezone-sensitive spec" do
+      expect(body).to include("Apr 23")
+    end
+
+    it "displays correct number of posts from past week", skip: "timezone-sensitive spec" do
       create(:article, published_at: Time.current)
       create(:article, published_at: 1.day.ago)
       create(:article, published_at: 7.days.ago)

spec/requests/admin/pages_spec.rb

@@ -1,7 +1,7 @@
 require "rails_helper"
 require "requests/shared_examples/internal_policy_dependant_request"
 
-RSpec.describe "/admin/customization/pages", type: :request do
+RSpec.describe "/admin/customization/pages" do
   it_behaves_like "an InternalPolicy dependant request", Page do
     let(:request) { get admin_pages_path }
   end

spec/requests/admin/permissions_spec.rb

@@ -1,6 +1,6 @@
 require "rails_helper"
 
-RSpec.describe "/admin/permissions", type: :request do
+RSpec.describe "/admin/permissions" do
   context "when the user is not an admin" do
     let(:user) { create(:user) }
 

spec/requests/admin/podcasts_spec.rb

@@ -1,6 +1,6 @@
 require "rails_helper"
 
-RSpec.describe "/admin/content_manager/podcasts", type: :request do
+RSpec.describe "/admin/content_manager/podcasts" do
   let(:admin) { create(:user, :super_admin) }
   let(:podcast) { create(:podcast, published: false) }
   let(:user) { create(:user) }

spec/requests/admin/privileged_reactions_spec.rb

@@ -1,6 +1,6 @@
 require "rails_helper"
 
-RSpec.describe "/admin/moderations/privileged_reactions", type: :request do
+RSpec.describe "/admin/moderations/privileged_reactions" do
   context "when the user is not an admin" do
     let(:user) { create(:user) }
 

spec/requests/admin/profile_field_groups_spec.rb

@@ -1,6 +1,6 @@
 require "rails_helper"
 
-RSpec.describe "/admin/customization/profile_field_groups", type: :request do
+RSpec.describe "/admin/customization/profile_field_groups" do
   let(:admin) { create(:user, :super_admin) }
 
   before do

spec/requests/admin/profile_fields_spec.rb

@@ -1,6 +1,6 @@
 require "rails_helper"
 
-RSpec.describe "/admin/customization/profile_fields", type: :request do
+RSpec.describe "/admin/customization/profile_fields" do
   let(:admin) { create(:user, :super_admin) }
 
   before do

spec/requests/admin/reactions_spec.rb

@@ -1,6 +1,6 @@
 require "rails_helper"
 
-RSpec.describe "/admin/reactions", type: :request do
+RSpec.describe "/admin/reactions" do
   let(:user)             { create(:user) }
   let(:article)          { create(:article, user_id: user.id) }
   let(:admin)            { create(:user, :super_admin) }

spec/requests/admin/response_templates_spec.rb

@@ -1,6 +1,6 @@
 require "rails_helper"
 
-RSpec.describe "/admin/advanced/response_templates", type: :request do
+RSpec.describe "/admin/advanced/response_templates" do
   let(:admin) { create(:user, :admin) }
 
   before { sign_in admin }

spec/requests/admin/tags/moderators_spec.rb

@@ -1,6 +1,6 @@
 require "rails_helper"
 
-RSpec.describe "/admin/content_manager/tags/:id/moderator", type: :request do
+RSpec.describe "/admin/content_manager/tags/:id/moderator" do
   let(:super_admin) { create(:user, :super_admin) }
   let(:user)        { create(:user) }
   let(:tag)         { create(:tag) }

spec/requests/admin/tags_spec.rb

@@ -1,6 +1,6 @@
 require "rails_helper"
 
-RSpec.describe "/admin/content_manager/tags", type: :request do
+RSpec.describe "/admin/content_manager/tags" do
   let(:super_admin) { create(:user, :super_admin) }
   let(:tag)         { create(:tag) }
   let(:badge)       { create(:badge) }

spec/requests/admin/tools_spec.rb

@@ -1,6 +1,6 @@
 require "rails_helper"
 
-RSpec.describe "/admin/advanced/tools", type: :request do
+RSpec.describe "/admin/advanced/tools" do
   context "when the user is not an admin" do
     let(:user) { create(:user) }
 

spec/requests/admin/users/users_export_spec.rb

@@ -1,6 +1,6 @@
 require "rails_helper"
 
-RSpec.describe "/admin/users/export", type: :request do
+RSpec.describe "/admin/users/export" do
   let(:admin) do
     create(:user, :super_admin,
            name: "Admin1", username: "admin1", email: "admin1@gmail.com",

spec/requests/admin/users_manage_spec.rb

@@ -1,6 +1,6 @@
 require "rails_helper"
 
-RSpec.describe "Admin::Users", type: :request do
+RSpec.describe "Admin::Users" do
   let!(:user) { create(:user, twitter_username: nil, old_username: "username") }
   let!(:user2) { create(:user, twitter_username: "Twitter") }
   let(:user3) { create(:user) }

spec/requests/admin/users_spec.rb

@@ -1,6 +1,6 @@
 require "rails_helper"
 
-RSpec.describe "/admin/member_manager/users", type: :request do
+RSpec.describe "/admin/member_manager/users" do
   let!(:user) do
     omniauth_mock_github_payload
     create(:user, :with_identity, identities: ["github"])

spec/requests/admin/welcome_spec.rb

@@ -1,6 +1,6 @@
 require "rails_helper"
 
-RSpec.describe "/admin/apps/welcome", type: :request do
+RSpec.describe "/admin/apps/welcome" do
   context "when the user is not an admin" do
     let(:user) { create(:user) }
 

spec/requests/api/v0/admin/users_spec.rb

@@ -1,6 +1,6 @@
 require "rails_helper"
 
-RSpec.describe "/api/admin/users", type: :request do
+RSpec.describe "/api/admin/users" do
   let(:params) { { email: "test@example.com" } }
 
   context "when unauthorized" do

spec/requests/api/v0/analytics_spec.rb

@@ -1,6 +1,6 @@
 require "rails_helper"
 
-RSpec.describe "Api::V0::Analytics", type: :request do
+RSpec.describe "Api::V0::Analytics" do
   describe "GET /api/analytics/totals" do
     include_examples "GET /api/analytics/:endpoint authorization examples", "totals"
   end

spec/requests/api/v0/api_controller_spec.rb

@@ -9,7 +9,7 @@ module Api
   end
 end
 
-RSpec.describe "Api::V0::ApiController", type: :request do
+RSpec.describe "Api::V0::ApiController" do
   let(:path) { "/api/tests" }
 
   before do

spec/requests/api/v0/articles_spec.rb

@@ -1,6 +1,6 @@
 require "rails_helper"
 
-RSpec.describe "Api::V0::Articles", type: :request do
+RSpec.describe "Api::V0::Articles" do
   let(:organization) { create(:organization) } # not used by every spec but lower times overall
   let(:tag) { create(:tag, name: "discuss") }
   let(:article) { create(:article, featured: true, tags: "discuss") }
@@ -39,13 +39,13 @@ RSpec.describe "Api::V0::Articles", type: :request do
     it "returns correct tag list" do
       get api_articles_path
 
-      expect(response.parsed_body.first["tag_list"]).to be_a_kind_of Array
+      expect(response.parsed_body.first["tag_list"]).to be_a Array
     end
 
     it "returns correct tags" do
       get api_articles_path
 
-      expect(response.parsed_body.first["tags"]).to be_a_kind_of String
+      expect(response.parsed_body.first["tags"]).to be_a String
     end
 
     context "without params" do
@@ -353,13 +353,13 @@ RSpec.describe "Api::V0::Articles", type: :request do
     it "returns correct tag list" do
       get api_article_path(article.id)
 
-      expect(response.parsed_body["tag_list"]).to be_a_kind_of String
+      expect(response.parsed_body["tag_list"]).to be_a String
     end
 
     it "returns correct tags" do
       get api_article_path(article.id)
 
-      expect(response.parsed_body["tags"]).to be_a_kind_of Array
+      expect(response.parsed_body["tags"]).to be_a Array
     end
 
     it "returns proper article" do
@@ -546,7 +546,7 @@ RSpec.describe "Api::V0::Articles", type: :request do
           newer = create(:article, published: false, published_at: nil, user: user)
         end
         get "/api/articles/me/unpublished", headers: headers
-        expected_order = response.parsed_body.map { |resp| resp["id"] }
+        expected_order = response.parsed_body.map.pluck("id")
         expect(expected_order).to eq([newer.id, older.id])
       end
 
@@ -554,7 +554,7 @@ RSpec.describe "Api::V0::Articles", type: :request do
         create(:article, user: user)
         create(:article, published: false, published_at: nil, user: user)
         get "/api/articles/me/all", headers: headers
-        expected_order = response.parsed_body.map { |resp| resp["published"] }
+        expected_order = response.parsed_body.pluck("published")
         expect(expected_order).to eq([false, true])
       end
 

spec/requests/api/v0/comments_spec.rb

@@ -1,6 +1,6 @@
 require "rails_helper"
 
-RSpec.describe "Api::V0::Comments", type: :request do
+RSpec.describe "Api::V0::Comments" do
   let(:article) { create(:article) }
   let!(:root_comment) { create(:comment, commentable: article) }
   let!(:child_comment) do
@@ -53,7 +53,7 @@ RSpec.describe "Api::V0::Comments", type: :request do
       get api_comments_path(a_id: article.id)
 
       expected_ids = article.comments.roots.map(&:id_code_generated)
-      response_ids = response.parsed_body.map { |cm| cm["id_code"] }
+      response_ids = response.parsed_body.pluck("id_code")
       expect(response_ids).to match_array(expected_ids)
     end
 

spec/requests/api/v0/feature_flags_spec.rb

@@ -1,6 +1,6 @@
 require "rails_helper"
 
-RSpec.describe "Api::V0::FeatureFlagsController", type: :request do
+RSpec.describe "Api::V0::FeatureFlagsController" do
   let(:flag) { "test_flag" }
   let(:params) { { flag: flag } }
 

spec/requests/api/v0/followers_spec.rb

@@ -1,6 +1,6 @@
 require "rails_helper"
 
-RSpec.describe "Api::V0::FollowersController", type: :request do
+RSpec.describe "Api::V0::FollowersController" do
   let(:user) { create(:user) }
   let(:api_secret) { create(:api_secret, user: user) }
   let(:headers) { { "api-key" => api_secret.secret } }
@@ -65,7 +65,7 @@ RSpec.describe "Api::V0::FollowersController", type: :request do
         get api_followers_users_path, headers: headers
 
         follows = user.followings.order(id: :desc).last(2).map(&:id)
-        result = response.parsed_body.map { |f| f["id"] }
+        result = response.parsed_body.pluck("id")
         expect(result).to eq(follows)
       end
 
@@ -74,7 +74,7 @@ RSpec.describe "Api::V0::FollowersController", type: :request do
 
         follows = user.followings.order(id: :asc).last(2).map(&:id)
         get api_followers_users_path, headers: headers, params: { sort: "created_at" }
-        result = response.parsed_body.map { |f| f["id"] }
+        result = response.parsed_body.pluck("id")
         expect(result).to eq(follows)
       end
     end

spec/requests/api/v0/follows_spec.rb

@@ -1,6 +1,6 @@
 require "rails_helper"
 
-RSpec.describe "Api::V0::FollowsController", type: :request do
+RSpec.describe "Api::V0::FollowsController" do
   describe "POST /api/follows" do
     it "returns unauthorized if user is not signed in" do
       post "/api/follows", params: { users: [] }

spec/requests/api/v0/health_checks_spec.rb

@@ -1,6 +1,6 @@
 require "rails_helper"
 
-RSpec.describe "HealthCheck", type: :request do
+RSpec.describe "HealthCheck" do
   let(:token) { "secret" }
   let(:headers) { { "health-check-token" => token } }
 

spec/requests/api/v0/instances_spec.rb

@@ -1,6 +1,6 @@
 require "rails_helper"
 
-RSpec.describe "Api::V0::Instances", type: :request do
+RSpec.describe "Api::V0::Instances" do
   describe "GET /api/instance" do
     it "returns the correct attributes", :aggregate_failures do
       create(:user)

spec/requests/api/v0/listings_spec.rb

@@ -1,6 +1,6 @@
 require "rails_helper"
 
-RSpec.describe "Api::V0::Listings", type: :request do
+RSpec.describe "Api::V0::Listings" do
   let(:cfp_category) do
     create(:listing_category, :cfp)
   end

spec/requests/api/v0/organizations_spec.rb

@@ -1,6 +1,6 @@
 require "rails_helper"
 
-RSpec.describe "Api::V0::Organizations", type: :request do
+RSpec.describe "Api::V0::Organizations" do
   describe "GET /api/organizations/:username" do
     let(:organization) { create(:organization) }
 

spec/requests/api/v0/podcasts_episodes_spec.rb

@@ -1,6 +1,6 @@
 require "rails_helper"
 
-RSpec.describe "Api::V0::PodcastEpisodes", type: :request do
+RSpec.describe "Api::V0::PodcastEpisodes" do
   let(:podcast) { create(:podcast) }
 
   describe "GET /api/podcast_episodes" do
@@ -23,7 +23,7 @@ RSpec.describe "Api::V0::PodcastEpisodes", type: :request do
 
       get api_podcast_episodes_path
 
-      expect(response.parsed_body.map { |e| e["id"] }).not_to include(pe.id.to_s)
+      expect(response.parsed_body.pluck("id")).not_to include(pe.id.to_s)
     end
 
     it "returns correct attributes for an episode", :aggregate_failures do
@@ -58,7 +58,7 @@ RSpec.describe "Api::V0::PodcastEpisodes", type: :request do
       pe2 = create(:podcast_episode, published_at: 1.day.from_now, podcast: podcast)
 
       get api_podcast_episodes_path
-      expect(response.parsed_body.map { |pe| pe["id"] }).to eq([pe2.id, pe1.id])
+      expect(response.parsed_body.pluck("id")).to eq([pe2.id, pe1.id])
     end
 
     it "supports pagination" do
@@ -97,7 +97,7 @@ RSpec.describe "Api::V0::PodcastEpisodes", type: :request do
         create(:podcast_episode, podcast: create(:podcast))
 
         get api_podcast_episodes_path(username: podcast.slug)
-        expect(response.parsed_body.map { |pe| pe["id"] }).to eq([pe1.id])
+        expect(response.parsed_body.pluck("id")).to eq([pe1.id])
       end
 
       it "returns not found if the episode belongs to an unpublished podcast" do

spec/requests/api/v0/profile_images_spec.rb

@@ -1,6 +1,6 @@
 require "rails_helper"
 
-RSpec.describe "Api::V0::ProfileImages", type: :request do
+RSpec.describe "Api::V0::ProfileImages" do
   describe "GET /api/profile_images/:username" do
     it "returns 404 if the username is not taken" do
       get api_profile_image_path("invalid-username")

spec/requests/api/v0/readinglist_spec.rb

@@ -1,6 +1,6 @@
 require "rails_helper"
 
-RSpec.describe "Api::V0::ReadingList", type: :request do
+RSpec.describe "Api::V0::ReadingList" do
   let(:api_secret) { create(:api_secret, user: user) }
   let(:headers) { { "api-key" => api_secret.secret } }
 

spec/requests/api/v0/tags_spec.rb

@@ -1,6 +1,6 @@
 require "rails_helper"
 
-RSpec.describe "Api::V0::Tags", type: :request do
+RSpec.describe "Api::V0::Tags" do
   describe "GET /api/tags" do
     it "returns tags" do
       create(:tag, taggings_count: 10)
@@ -30,7 +30,7 @@ RSpec.describe "Api::V0::Tags", type: :request do
       get api_tags_path
 
       expected_result = [other_tag.id, tag.id]
-      expect(response.parsed_body.map { |t| t["id"] }).to eq(expected_result)
+      expect(response.parsed_body.pluck("id")).to eq(expected_result)
     end
 
     it "supports pagination" do

spec/requests/api/v0/users_spec.rb

@@ -1,6 +1,6 @@
 require "rails_helper"
 
-RSpec.describe "Api::V0::Users", type: :request do
+RSpec.describe "Api::V0::Users" do
   describe "GET /api/users/:id" do
     let!(:user) do
       create(:user,

spec/requests/api/v0/videos_spec.rb

@@ -1,6 +1,6 @@
 require "rails_helper"
 
-RSpec.describe "Api::V0::Videos", type: :request do
+RSpec.describe "Api::V0::Videos" do
   let(:user) { create(:user, created_at: 1.month.ago) }
 
   def create_article(article_params = {})
@@ -69,7 +69,7 @@ RSpec.describe "Api::V0::Videos", type: :request do
       get api_videos_path
 
       expected_result = [video_article.id, other_video_article.id]
-      expect(response.parsed_body.map { |a| a["id"] }).to eq(expected_result)
+      expect(response.parsed_body.pluck("id")).to eq(expected_result)
     end
 
     it "supports pagination" do

spec/requests/api/v1/admin/users_spec.rb

@@ -1,6 +1,6 @@
 require "rails_helper"
 
-RSpec.describe "/api/admin/users", type: :request do
+RSpec.describe "/api/admin/users" do
   let(:params) { { email: "test@example.com" } }
   let(:v1_headers) { { "Accept" => "application/vnd.forem.api-v1+json" } }
 

spec/requests/api/v1/analytics_spec.rb

@@ -1,6 +1,6 @@
 require "rails_helper"
 
-RSpec.describe "Api::V1::Analytics", type: :request do
+RSpec.describe "Api::V1::Analytics" do
   let(:api_secret) { create(:api_secret) }
   let(:headers) { { "Accept" => "application/vnd.forem.api-v1+json", "api-key" => api_secret.secret } }
 

spec/requests/api/v1/articles_spec.rb

@@ -1,6 +1,6 @@
 require "rails_helper"
 
-RSpec.describe "Api::V1::Articles", type: :request do
+RSpec.describe "Api::V1::Articles" do
   let(:organization) { create(:organization) } # not used by every spec but lower times overall
   let(:tag) { create(:tag, name: "discuss") }
   let(:article) { create(:article, featured: true, tags: "discuss") }
@@ -43,13 +43,13 @@ RSpec.describe "Api::V1::Articles", type: :request do
     it "returns correct tag list" do
       get api_articles_path, headers: headers
 
-      expect(response.parsed_body.first["tag_list"]).to be_a_kind_of Array
+      expect(response.parsed_body.first["tag_list"]).to be_a Array
     end
 
     it "returns correct tags" do
       get api_articles_path, headers: headers
 
-      expect(response.parsed_body.first["tags"]).to be_a_kind_of String
+      expect(response.parsed_body.first["tags"]).to be_a String
     end
 
     context "without params" do
@@ -357,13 +357,13 @@ RSpec.describe "Api::V1::Articles", type: :request do
     it "returns correct tag list" do
       get api_article_path(article.id), headers: headers
 
-      expect(response.parsed_body["tag_list"]).to be_a_kind_of String
+      expect(response.parsed_body["tag_list"]).to be_a String
     end
 
     it "returns correct tags" do
       get api_article_path(article.id), headers: headers
 
-      expect(response.parsed_body["tags"]).to be_a_kind_of Array
+      expect(response.parsed_body["tags"]).to be_a Array
     end
 
     it "returns proper article" do
@@ -545,7 +545,7 @@ RSpec.describe "Api::V1::Articles", type: :request do
           newer = create(:article, published: false, published_at: nil, user: user)
         end
         get "/api/articles/me/unpublished", headers: auth_headers
-        expected_order = response.parsed_body.map { |resp| resp["id"] }
+        expected_order = response.parsed_body.pluck("id")
         expect(expected_order).to eq([newer.id, older.id])
       end
 
@@ -553,7 +553,7 @@ RSpec.describe "Api::V1::Articles", type: :request do
         create(:article, user: user)
         create(:article, published: false, published_at: nil, user: user)
         get "/api/articles/me/all", headers: auth_headers
-        expected_order = response.parsed_body.map { |resp| resp["published"] }
+        expected_order = response.parsed_body.pluck("published")
         expect(expected_order).to eq([false, true])
       end
 

spec/requests/api/v1/comments_spec.rb

@@ -1,6 +1,6 @@
 require "rails_helper"
 
-RSpec.describe "Api::V1::Comments", type: :request do
+RSpec.describe "Api::V1::Comments" do
   let(:headers) { { "Accept" => "application/vnd.forem.api-v1+json" } }
   let(:article) { create(:article) }
   let!(:root_comment) { create(:comment, commentable: article) }
@@ -54,7 +54,7 @@ RSpec.describe "Api::V1::Comments", type: :request do
       get api_comments_path(a_id: article.id), headers: headers
 
       expected_ids = article.comments.roots.map(&:id_code_generated)
-      response_ids = response.parsed_body.map { |cm| cm["id_code"] }
+      response_ids = response.parsed_body.pluck("id_code")
       expect(response_ids).to match_array(expected_ids)
     end
 

spec/requests/api/v1/docs/reactions_spec.rb

@@ -4,11 +4,11 @@ require "swagger_helper"
 # rubocop:disable RSpec/EmptyExampleGroup
 # rubocop:disable RSpec/VariableName
 
-RSpec.describe "api/v1/reactions", type: :request do
+RSpec.describe "api/v1/reactions" do
   let(:Accept) { "application/vnd.forem.api-v1+json" }
   let(:api_secret) { create(:api_secret) }
   let(:category) { "like" }
-  let(:reactable) { create :article }
+  let(:reactable) { create(:article) }
   let(:reaction) { reactable.reactions.create user: user, category: "like" }
   let(:result) { ReactionHandler::Result.new reaction: reaction }
   let(:user) { api_secret.user }

spec/requests/api/v1/feature_flags_spec.rb

@@ -1,6 +1,6 @@
 require "rails_helper"
 
-RSpec.describe "Api::V1::FeatureFlagsController", type: :request do
+RSpec.describe "Api::V1::FeatureFlagsController" do
   let(:flag) { "test_flag" }
   let(:params) { { flag: flag } }
   let(:headers) { { "Accept" => "application/vnd.forem.api-v1+json" } }

spec/requests/api/v1/followers_spec.rb

@@ -1,6 +1,6 @@
 require "rails_helper"
 
-RSpec.describe "Api::V1::FollowersController", type: :request do
+RSpec.describe "Api::V1::FollowersController" do
   let(:user) { create(:user) }
   let(:api_secret) { create(:api_secret, user: user) }
   let(:headers) { { "api-key" => api_secret.secret, "Accept" => "application/vnd.forem.api-v1+json" } }
@@ -65,7 +65,7 @@ RSpec.describe "Api::V1::FollowersController", type: :request do
         get api_followers_users_path, headers: headers
 
         follows = user.followings.order(id: :desc).last(2).map(&:id)
-        result = response.parsed_body.map { |f| f["id"] }
+        result = response.parsed_body.pluck("id")
         expect(result).to eq(follows)
       end
 
@@ -74,7 +74,7 @@ RSpec.describe "Api::V1::FollowersController", type: :request do
 
         follows = user.followings.order(id: :asc).last(2).map(&:id)
         get api_followers_users_path, headers: headers, params: { sort: "created_at" }
-        result = response.parsed_body.map { |f| f["id"] }
+        result = response.parsed_body.pluck("id")
         expect(result).to eq(follows)
       end
     end

spec/requests/api/v1/follows_spec.rb

@@ -1,6 +1,6 @@
 require "rails_helper"
 
-RSpec.describe "Api::V1::FollowsController", type: :request do
+RSpec.describe "Api::V1::FollowsController" do
   let(:headers) { { "Accept" => "application/vnd.forem.api-v1+json" } }
 
   describe "POST /api/follows" do

spec/requests/api/v1/health_checks_spec.rb

@@ -1,6 +1,6 @@
 require "rails_helper"
 
-RSpec.describe "HealthCheck", type: :request do
+RSpec.describe "HealthCheck" do
   let(:token) { "secret" }
   let(:headers) { { "health-check-token" => token, "Accept" => "application/vnd.forem.api-v1+json" } }
 

spec/requests/api/v1/instances_spec.rb

@@ -1,6 +1,6 @@
 require "rails_helper"
 
-RSpec.describe "Api::V1::Instances", type: :request do
+RSpec.describe "Api::V1::Instances" do
   let(:headers) { { "Accept" => "application/vnd.forem.api-v1+json" } }
 
   describe "GET /api/instance" do

spec/requests/api/v1/listings_spec.rb

@@ -1,6 +1,6 @@
 require "rails_helper"
 
-RSpec.describe "Api::V1::Listings", type: :request do
+RSpec.describe "Api::V1::Listings" do
   let(:cfp_category) do
     create(:listing_category, :cfp)
   end

spec/requests/api/v1/organizations_spec.rb

@@ -1,6 +1,6 @@
 require "rails_helper"
 
-RSpec.describe "Api::V1::Organizations", type: :request do
+RSpec.describe "Api::V1::Organizations" do
   let(:headers) { { "content-type" => "application/json", "Accept" => "application/vnd.forem.api-v1+json" } }
 
   describe "GET /api/organizations/:username" do

spec/requests/api/v1/podcasts_episodes_spec.rb

@@ -1,6 +1,6 @@
 require "rails_helper"
 
-RSpec.describe "Api::V1::PodcastEpisodes", type: :request do
+RSpec.describe "Api::V1::PodcastEpisodes" do
   let(:podcast) { create(:podcast) }
   let(:headers) { { "Accept" => "application/vnd.forem.api-v1+json" } }
 
@@ -24,7 +24,7 @@ RSpec.describe "Api::V1::PodcastEpisodes", type: :request do
 
       get api_podcast_episodes_path, headers: headers
 
-      expect(response.parsed_body.map { |e| e["id"] }).not_to include(pe.id.to_s)
+      expect(response.parsed_body.pluck("id")).not_to include(pe.id.to_s)
     end
 
     it "returns correct attributes for an episode", :aggregate_failures do
@@ -59,7 +59,7 @@ RSpec.describe "Api::V1::PodcastEpisodes", type: :request do
       pe2 = create(:podcast_episode, published_at: 1.day.from_now, podcast: podcast)
 
       get api_podcast_episodes_path, headers: headers
-      expect(response.parsed_body.map { |pe| pe["id"] }).to eq([pe2.id, pe1.id])
+      expect(response.parsed_body.pluck("id")).to eq([pe2.id, pe1.id])
     end
 
     it "supports pagination" do
@@ -98,7 +98,7 @@ RSpec.describe "Api::V1::PodcastEpisodes", type: :request do
         create(:podcast_episode, podcast: create(:podcast))
 
         get api_podcast_episodes_path(username: podcast.slug), headers: headers
-        expect(response.parsed_body.map { |pe| pe["id"] }).to eq([pe1.id])
+        expect(response.parsed_body.pluck("id")).to eq([pe1.id])
       end
 
       it "returns not found if the episode belongs to an unpublished podcast" do

spec/requests/api/v1/profile_images_spec.rb

@@ -1,6 +1,6 @@
 require "rails_helper"
 
-RSpec.describe "Api::V1::ProfileImages", type: :request do
+RSpec.describe "Api::V1::ProfileImages" do
   let(:headers) { { "content-type" => "application/json", "Accept" => "application/vnd.forem.api-v1+json" } }
 
   describe "GET /api/profile_images/:username" do

spec/requests/api/v1/reactions_spec.rb

@@ -1,6 +1,6 @@
 require "rails_helper"
 
-RSpec.describe "Api::V1::Reactions", type: :request do
+RSpec.describe "Api::V1::Reactions" do
   let!(:v1_headers) { { "content-type" => "application/json", "Accept" => "application/vnd.forem.api-v1+json" } }
   let(:params) do
     {

spec/requests/api/v1/readinglist_spec.rb

@@ -1,6 +1,6 @@
 require "rails_helper"
 
-RSpec.describe "Api::V1::ReadingList", type: :request do
+RSpec.describe "Api::V1::ReadingList" do
   let(:user) { create(:user) }
   let(:user2) { create(:user) }
   let(:api_secret) { create(:api_secret, user: user) }

spec/requests/api/v1/tags_spec.rb

@@ -1,6 +1,6 @@
 require "rails_helper"
 
-RSpec.describe "Api::V1::Tags", type: :request do
+RSpec.describe "Api::V1::Tags" do
   describe "GET /api/tags" do
     let(:headers) { { "Accept" => "application/vnd.forem.api-v1+json" } }
 
@@ -34,7 +34,7 @@ RSpec.describe "Api::V1::Tags", type: :request do
       get api_tags_path, headers: headers
 
       expected_result = [other_tag.id, tag.id]
-      expect(response.parsed_body.map { |t| t["id"] }).to eq(expected_result)
+      expect(response.parsed_body.pluck("id")).to eq(expected_result)
     end
 
     it "supports pagination" do

spec/requests/api/v1/users_spec.rb

@@ -1,6 +1,6 @@
 require "rails_helper"
 
-RSpec.describe "Api::V1::Users", type: :request do
+RSpec.describe "Api::V1::Users" do
   let(:api_secret) { create(:api_secret) }
   let(:headers) { { "Accept" => "application/vnd.forem.api-v1+json" } }
   let(:auth_headers) { headers.merge({ "api-key" => api_secret.secret }) }

spec/requests/api/v1/videos_spec.rb

@@ -1,6 +1,6 @@
 require "rails_helper"
 
-RSpec.describe "Api::V1::Videos", type: :request do
+RSpec.describe "Api::V1::Videos" do
   let(:user) { create(:user, created_at: 1.month.ago) }
   let(:api_secret) { create(:api_secret, user: user) }
   let(:headers) { { "Accept" => "application/vnd.forem.api-v1+json" } }
@@ -71,7 +71,7 @@ RSpec.describe "Api::V1::Videos", type: :request do
       get api_videos_path, headers: headers
 
       expected_result = [video_article.id, other_video_article.id]
-      expect(response.parsed_body.map { |a| a["id"] }).to eq(expected_result)
+      expect(response.parsed_body.pluck("id")).to eq(expected_result)
     end
 
     it "supports pagination" do

spec/requests/api_secrets_create_spec.rb

@@ -1,6 +1,6 @@
 require "rails_helper"
 
-RSpec.describe "ApiSecretsCreate", type: :request do
+RSpec.describe "ApiSecretsCreate" do
   let(:user) { create(:user) }
 
   before { sign_in user }

spec/requests/api_secrets_destroy_spec.rb

@@ -1,6 +1,6 @@
 require "rails_helper"
 
-RSpec.describe "ApiSecretsDestroy", type: :request do
+RSpec.describe "ApiSecretsDestroy" do
   let(:api_secret) { create(:api_secret) }
   let(:user) { api_secret.user }
 

spec/requests/article_approvals_spec.rb

@@ -1,6 +1,6 @@
 require "rails_helper"
 
-RSpec.describe "ArticleApprovals", type: :request do
+RSpec.describe "ArticleApprovals" do
   describe "POST article_approvals" do
     let(:tag)            { create(:tag, requires_approval: true) }
     let(:user)           { create(:user) }

spec/requests/articles/articles_admin_feature_spec.rb

@@ -1,6 +1,6 @@
 require "rails_helper"
 
-RSpec.describe "ArticlesAdminFeature", type: :request do
+RSpec.describe "ArticlesAdminFeature" do
   let(:user) { create(:user) }
   let(:article) { create(:article, user_id: user.id) }
   let(:super_admin) { create(:user, :super_admin) }

spec/requests/articles/articles_admin_unpublish_spec.rb

@@ -1,6 +1,6 @@
 require "rails_helper"
 
-RSpec.describe "ArticlesAdminUnpublish", type: :request do
+RSpec.describe "ArticlesAdminUnpublish" do
   let(:user) { create(:user) }
   let(:article) { create(:article, user_id: user.id) }
   let(:super_admin) { create(:user, :super_admin) }

spec/requests/articles/articles_create_spec.rb

@@ -1,6 +1,6 @@
 require "rails_helper"
 
-RSpec.describe "ArticlesCreate", type: :request do
+RSpec.describe "ArticlesCreate" do
   let(:user) { create(:user, :org_member) }
   let(:template) { file_fixture("article_published.txt").read }
   let(:new_title) { "NEW TITLE #{rand(100)}" }

spec/requests/articles/articles_destroy_spec.rb

@@ -1,6 +1,6 @@
 require "rails_helper"
 
-RSpec.describe "ArticlesDestroy", type: :request do
+RSpec.describe "ArticlesDestroy" do
   let(:user) { create(:user, :org_admin) }
   let(:article) { create(:article, user_id: user.id) }
 

spec/requests/articles/articles_feed_spec.rb

@@ -1,6 +1,6 @@
 require "rails_helper"
 
-RSpec.describe "ArticlesFeed", type: :request do
+RSpec.describe "ArticlesFeed" do
   let!(:article) { create(:article) }
 
   it "returns an rss feed with published articles" do

spec/requests/articles/articles_show_spec.rb

@@ -1,6 +1,6 @@
 require "rails_helper"
 
-RSpec.describe "ArticlesShow", type: :request do
+RSpec.describe "ArticlesShow" do
   let(:user) { create(:user) }
   let(:article) { create(:article, user: user, published: true, organization: organization) }
   let(:organization) { create(:organization) }

spec/requests/articles/articles_spec.rb

@@ -1,6 +1,6 @@
 require "rails_helper"
 
-RSpec.describe "Articles", type: :request do
+RSpec.describe "Articles" do
   let(:user) { create(:user) }
   let(:tag)  { build_stubbed(:tag) }
 

spec/requests/articles/articles_update_spec.rb

@@ -1,6 +1,6 @@
 require "rails_helper"
 
-RSpec.describe "ArticlesUpdate", type: :request do
+RSpec.describe "ArticlesUpdate" do
   let(:organization) { create(:organization) }
   let(:organization2) { create(:organization) }
   let(:user) { create(:user, :org_admin) }

spec/requests/articles/org_redirect_spec.rb

@@ -1,7 +1,7 @@
 require "rails_helper"
 
 # Regression spec for https://github.com/forem/forem/issues/12444
-RSpec.describe "", type: :request do
+RSpec.describe "" do
   it "does not infinitely redirect", :aggregate_failures do
     organization = create(:organization, username: "test")
     organization.update(username: "not_test")

spec/requests/articles/video_player_show_spec.rb

@@ -1,6 +1,6 @@
 require "rails_helper"
 
-RSpec.describe "VideoPlayerShow", type: :request do
+RSpec.describe "VideoPlayerShow" do
   let(:user) { create(:user) }
   let(:video_article) { create(:article, user: user) }
 

spec/requests/badges_spec.rb

@@ -1,6 +1,6 @@
 require "rails_helper"
 
-RSpec.describe "Badges", type: :request do
+RSpec.describe "Badges" do
   let(:user) { create(:user) }
 
   describe "GET /badges" do

spec/requests/collections_spec.rb

@@ -1,6 +1,6 @@
 require "rails_helper"
 
-RSpec.describe "Collections", type: :request do
+RSpec.describe "Collections" do
   let(:user) { create(:user) }
   let(:collection) { create(:collection, :with_articles, user: user) }
 

spec/requests/comments_create_spec.rb

@@ -1,6 +1,6 @@
 require "rails_helper"
 
-RSpec.describe "CommentsCreate", type: :request do
+RSpec.describe "CommentsCreate" do
   let(:user) { create(:user) }
   let(:blocker) { create(:user) }
   let(:article) { create(:article, user_id: user.id) }

spec/requests/comments_destroy_spec.rb

@@ -1,6 +1,6 @@
 require "rails_helper"
 
-RSpec.describe "CommentsDestroy", type: :request do
+RSpec.describe "CommentsDestroy" do
   let(:user) { create(:user) }
   let(:article) { create(:article, user_id: user.id) }
 

spec/requests/comments_spec.rb

@@ -1,7 +1,7 @@
 require "rails_helper"
 require "requests/shared_examples/comment_hide_or_unhide_request"
 
-RSpec.describe "Comments", type: :request do
+RSpec.describe "Comments" do
   let(:user) { create(:user) }
   let(:article) { create(:article, user: user) }
   let(:podcast) { create(:podcast) }
@@ -162,7 +162,7 @@ RSpec.describe "Comments", type: :request do
     end
 
     context "when the comment is for a podcast's episode" do
-      it "works" do
+      it "is successful" do
         podcast_comment = create(:comment, commentable: podcast_episode, user: user)
 
         get podcast_comment.path

spec/requests/comments_update_spec.rb

@@ -1,6 +1,6 @@
 require "rails_helper"
 
-RSpec.describe "CommentsUpdate", type: :request do
+RSpec.describe "CommentsUpdate" do
   let(:user) { create(:user) }
   let(:article) { create(:article, user_id: user.id) }
   let(:comment) { create(:comment, user_id: user.id, commentable: article) }

spec/requests/credits_spec.rb

@@ -1,6 +1,6 @@
 require "rails_helper"
 
-RSpec.describe "Credits", type: :request do
+RSpec.describe "Credits" do
   describe "GET /credits" do
     let(:user) { create(:user) }
     let(:org_member) { create(:user, :org_member) }

spec/requests/dashboard_spec.rb

@@ -1,6 +1,6 @@
 require "rails_helper"
 
-RSpec.describe "Dashboards", type: :request do
+RSpec.describe "Dashboards" do
   let(:user)          { create(:user) }
   let(:second_user)   { create(:user) }
   let(:super_admin)   { create(:user, :super_admin) }
@@ -327,7 +327,7 @@ RSpec.describe "Dashboards", type: :request do
 
     context "when user is an org admin" do
       it "shows page properly" do
-        org = create :organization
+        org = create(:organization)
         create(:organization_membership, user: user, organization: org, type_of_user: "admin")
 
         sign_in user
@@ -338,7 +338,7 @@ RSpec.describe "Dashboards", type: :request do
 
     context "when user is an org member" do
       it "shows page properly" do
-        org = create :organization
+        org = create(:organization)
         create(:organization_membership, user: user, organization: org)
 
         sign_in user

spec/requests/devices_spec.rb

@@ -1,6 +1,6 @@
 require "rails_helper"
 
-RSpec.describe "Devices", type: :request do
+RSpec.describe "Devices" do
   let(:user) { create(:user) }
   let(:consumer_app) { create(:consumer_app) }