docbrown/spec
Lawrence 0c93bde6c2
Subscribe to Comment Functionality (#19555)
* Move save over and add button labels

* comment notification design and functionality

* controller error handling

* add ternery operator for background class

* minor cleanup

* add proper styling toggles

* tests and mobile spec

* add for all buttons

* add article as a param

* comment is not required on article preview

* update policy spec

* add test for coverage

* add proper button titles

* use the last user comment as comment id

* add better error handling and remove multiple fetch calls in js

* copy change to threads

* update copy, fix multiple fetch calls, add observer for loading more notifications

* update spec

* add rspecs

* more test specs

* fix test specs

* subscribe button text tests

* add export

* optimistically update ui function tests

* button initialize test

* check for comment ancestry

* add feature flag block

* some cleanup

* update logic and specs

* oops

* rubocop issues

* change config names

* change config names

* fix spec

* add one more conditional

* check for comments

* service-object the toggler

* separate routes

* continual refactoring

* refine spec tests

* clean up policy

* Adjust js and view files to match be params

* some service object refactoring

* separate endpoints on client-side

* broken spec

* service specs

* policy spec fixes

* remove action param

* remove action param from spec

* minor updates

* trigger build

* update to post

* Services don't need permitted params

* Notifications continue to be a mess, decorator specs to follow

* Not toggling now

* This doesn't really belong here

* Fix tests after moving

* Streamline front-end

* There could be errors?

* polymorphic_name is a class thing

* ☠️ json_data in notification views

* Use feature_flag helper to get current_user

* Cannot derive current subscription status from notification, only from subscription

* Default is subscribe to all article comments

* Sync up matching unsubscribe, make subscribe idempotent-ish

* Temporarily comment-out button jest tests to see if I can unstick CI

* Stop trying to detect potential subscribe-to-comment

* Stop trying to detect potential subscribe-to-comment

* Minor spec refactoring

* Add specs for article notification decoration

* NotificationDecorator specs are rather long

* Rubocop likes it?

* Minor spec refactoring

* Doesn't need to stay pending

* Add spec for subscription finder

* Expand Subscribe service specs

* YAGNI, but I don't like hard-coded config

* Refactor Unsubscribe service specs

* nobody expects the infinite scroll

* This *might* work, except for feature flag

* Ancestry can be quite deep actually

* Rubocop

* Update subscribe button for subscribe-to-thread

* Jest tests are just tests

* hasAttribute != getAttribute

* Test knows **nothing** about window size

* Tests have been lying about mobileLabel this whole time

* Make payload/endpoint testable

* Is Jest actually happy???

* Still cleaning up jest/eslint

* Temporarily comment-out cypress tests pending feature flag

* Thanks, Rubocop, what would we do without you

* Preserve round-trip for 'top-level' and 'only-author' subscriptions

* Update specs

* Move save button icon

* Update test with better config param

* Try feature flag specific to cypress env

* Tell cypress to wait for (un)subscribing to work

---------

Co-authored-by: Lawrence S <lawrence@forem.com>
Co-authored-by: Joshua Wehner <joshua@forem.com>
2023-07-10 17:11:46 +02:00
..
controllers/concerns Fix connect account bug from settings (#18824) 2022-12-09 09:58:04 -06:00
decorators Subscribe to Comment Functionality (#19555) 2023-07-10 17:11:46 +02:00
factories Add has_many associations to User model (#19625) 2023-06-23 14:58:55 -04:00
fixtures Frontend for multiple reactions (v1) (#18808) 2023-01-23 16:00:50 +01:00
forms Refactor CreatorSettingsForm & spec (#19011) 2023-01-27 08:39:07 -05:00
generator Routine rubocop fix on /spec (#19217) 2023-03-21 09:55:26 -04:00
helpers Round Robin notifications design refresh (#19420) 2023-05-04 18:13:14 +01:00
initializers Add forgot_password_throttle (#19175) 2023-02-27 09:25:29 -05:00
lib Subscribe to Comment Functionality (#19555) 2023-07-10 17:11:46 +02:00
liquid_tags Change feed billboard font size to fs-base and link embed adjustments (#19697) 2023-07-07 09:13:11 -04:00
mailers Update Subject Line for Tag Mod Email (#19349) 2023-04-18 16:21:06 -05:00
models Subscribe to Comment Functionality (#19555) 2023-07-10 17:11:46 +02:00
policies Subscribe to Comment Functionality (#19555) 2023-07-10 17:11:46 +02:00
queries Refactor the home feed + add user tag filtering on in-feed billboards (#19600) 2023-07-06 16:47:08 +02:00
refinements Update data exporter to handle admin send (#10274) 2020-10-26 18:00:56 -04:00
requests Subscribe to Comment Functionality (#19555) 2023-07-10 17:11:46 +02:00
routing Routine rubocop fix on /spec (#19217) 2023-03-21 09:55:26 -04:00
sanitizers Don't sanitize anchor elements with no href (#16667) 2022-02-22 11:27:38 -06:00
serializers Remove deprecated Organization's columns (#19396) 2023-06-26 10:36:33 -04:00
services Subscribe to Comment Functionality (#19555) 2023-07-10 17:11:46 +02:00
support Prevent comments by the staff account from being hidden (#19698) 2023-07-10 11:46:46 +01:00
system Fixe deprecation message in specs (#19694) 2023-07-07 15:39:09 -04:00
tasks Change rake spec setup (#19012) 2023-01-30 10:51:38 -05:00
uploaders Remove Remaining logo_svg Code (#16291) 2022-02-22 12:05:16 -07:00
validators Unique cross-model-slug check is likely misconfigured (#19263) 2023-04-07 17:04:45 +02:00
view_objects Routine rubocop fix on /spec (#19217) 2023-03-21 09:55:26 -04:00
views Rename Admin::DisplayAds controller to Billboards (#19687) 2023-07-07 08:11:35 -04:00
workers notify mod on new user articles (#19478) 2023-05-23 10:51:46 -04:00
i18n_spec.rb Show missing translation keys when test fails (#16637) 2022-02-17 16:21:29 -06:00
rails_helper.rb Upgrade ruby 3.0.6 (#19651) 2023-07-06 16:42:20 -04:00
spec_helper.rb Add Codecov (#18580) 2022-10-18 10:08:23 -04:00
swagger_helper.rb Add ability to assign arbitrary segment ID to /display_ads API (#19529) 2023-05-31 18:11:35 +02:00