Commit graph

9686 commits

Author SHA1 Message Date
Nikhil Taneja
ff008e4702
#12643 Add eslint rule for formatting redundant curly braces in jsx (#14592) 2021-08-26 11:15:06 -04:00
Michael Kohl
c16ec1d53d
Remove redundant freeze calls (#14596) 2021-08-26 10:01:08 -04:00
Michael Kohl
7e6f3831d1
Make pry available in tests (#14595) 2021-08-26 15:06:42 +02:00
Daniel Uber
edef262537
update ruby_parser and sexp_processor gems (#14594) 2021-08-25 18:54:36 -05:00
Michael Kohl
521f1d26bc
Upgrade to Ruby 3.0.2 (#12103)
Co-authored-by: rhymes <rhymes@hey.com>
Co-authored-by: Mac Siri <krairit.siri@gmail.com>
2021-08-25 14:26:33 -04:00
Suzanne Aitchison
b75af7b2aa
unify padding of code blocks (#14590) 2021-08-25 17:24:31 +02:00
Michael Kohl
37ae9ccf2e
Fix Users::SuggestRecet#established_user_comment_count (#14589) 2021-08-25 08:40:11 -05:00
Andy Zhao
b34455a9e7
Fix broken links (#14588) 2021-08-24 16:59:56 -04:00
dependabot[bot]
bcab5b6022
Bump flipper-ui from 0.22.0 to 0.22.1 (#14584)
Bumps [flipper-ui](https://github.com/jnunemaker/flipper) from 0.22.0 to 0.22.1.
- [Release notes](https://github.com/jnunemaker/flipper/releases)
- [Changelog](https://github.com/jnunemaker/flipper/blob/master/Changelog.md)
- [Commits](https://github.com/jnunemaker/flipper/compare/v0.22.0...v0.22.1)

---
updated-dependencies:
- dependency-name: flipper-ui
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-08-24 15:34:05 -04:00
dependabot[bot]
8867dc57b2
Bump flipper-active_record from 0.22.0 to 0.22.1 (#14585)
Bumps [flipper-active_record](https://github.com/jnunemaker/flipper) from 0.22.0 to 0.22.1.
- [Release notes](https://github.com/jnunemaker/flipper/releases)
- [Changelog](https://github.com/jnunemaker/flipper/blob/master/Changelog.md)
- [Commits](https://github.com/jnunemaker/flipper/compare/v0.22.0...v0.22.1)

---
updated-dependencies:
- dependency-name: flipper-active_record
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-08-24 12:41:16 -06:00
rhymes
2e664b7cd5
Remove API docs packages ✂️ ✂️ ✂️ (#14580)
* Remove API docs packages @spotlight/spectral and redoc-cli

* Remove yard packages
2021-08-24 18:51:05 +02:00
dependabot[bot]
6af768373e
Bump ws from 6.2.1 to 6.2.2 (#14582)
Bumps [ws](https://github.com/websockets/ws) from 6.2.1 to 6.2.2.
- [Release notes](https://github.com/websockets/ws/releases)
- [Commits](https://github.com/websockets/ws/compare/6.2.1...6.2.2)

---
updated-dependencies:
- dependency-name: ws
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-08-24 09:15:13 -06:00
Suzanne Aitchison
03ee38777e
Revert "Bump webpack-dev-server from 3.11.2 to 4.0.0 (#14572)" (#14581)
This reverts commit 6828fe1dcd.
2021-08-24 09:32:52 -05:00
rhymes
fc01a93326
Admin Member view: add Tools::HeaderComponent to reduce duplication (#14558)
* This does not work

* Revert "This does not work"

This reverts commit b2292e61fb10faa6051b009214e732a9927c7746.

* Tried with a partial, works

* Improved with component
2021-08-24 15:08:48 +02:00
Suzanne Aitchison
e40a49e7f1
Fix error adding and removing tags as mod (#14566)
* fix error adding and removing tags

* fix login modal test

* remove unneeded property

* fix followtag spec
2021-08-24 13:44:21 +01:00
Ridhwana
5827be4ecc
RFC 190: Forem Creator Signup Page (#13875)
* chore: add my name to the chaore so that I can search after cleanup

* feat: update the forem creator signup template and copy over some stuff from the email_resgistration

* feat: update the fields

* feat: make sure that it saves

* feat: add an eye svg to the password input

* feat: update eye and eye-off svg

* feat: update the placeholder for the password field

* reveak and hide the password when clicking on the icon

* eye visiblibility functionality

* feat: display the username

* feat: show the username row when we click edit

* feat: update the interaction design

* chore: remove extra line

* chore: remove unneeded function

* feat: never show the username hint when the user field is not hidden

* feat: ensure that the username works

* chore: update the existing specs

* feat: move to packs

* refactor: manage the visibility with a avariable and not with the password type

* optimize the way we use password visibility

* chore: validate the username field

* chore: update the statement

* feat: add a background

* feat: accessibility changes

* feat: set a max length on the username

* feat: some more accessibility changes

* feat: validate the length of the password

* chore: add some margin to the error box

* feat: by_email shows the error states and we should cater for the Forem Creator

* feat: tackle any errors

* WIP/test: first pass of some integration specs

* feat: update the Cypress tests

* Update app/views/shared/authentication/_forem_creator_signup.html.erb

Co-authored-by: Suzanne Aitchison <suzanne@forem.com>

* Update app/views/shared/authentication/_forem_creator_signup.html.erb

Co-authored-by: Michael Kohl <me@citizen428.net>

* chore: temporarily disable the background on large screens

* chore: remove title

* prevent default

* feat; update the style of the button

* feat: update the tests to use accessibility tags

* feat: update icons

* chore: oops

* little forntend updates

* Update app/views/shared/authentication/_forem_creator_signup.html.erb

Co-authored-by: Suzanne Aitchison <suzanne@forem.com>

* Update cypress/integration/creatorOnboardingFlows/creatorSignup.spec.js

Co-authored-by: Nick Taylor <nick@iamdeveloper.com>

* fea: change the aria label and pressed

* feat: change to just John

* feat: update  cypress tests

* test if this is causing the test to fail

* feat: add some margin

* feat: mostly for Cypress - required is true or false based on whether the field is needed

* refactor: use the password label and skip last test

* Update app/views/shared/authentication/_forem_creator_signup.html.erb

Co-authored-by: Suzanne Aitchison <suzanne@forem.com>

* Update app/views/shared/authentication/_forem_creator_signup.html.erb

Co-authored-by: Suzanne Aitchison <suzanne@forem.com>

* fix: do not toggle  the label (accessibility)

* fix: add a comma

Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
Co-authored-by: Michael Kohl <me@citizen428.net>
Co-authored-by: Paweł Ludwiczak <ludwiczakpawel@gmail.com>
Co-authored-by: Nick Taylor <nick@iamdeveloper.com>
2021-08-24 10:33:26 +02:00
Andy Zhao
3b81172c56
Remove docs from repo ✂✂✂ (#14579)
* Remove docs ✂✂✂✂

* Remove all references to docs and gitdocs

* Update docs.forem.com to developers.forem.com

* Remove .gitdocs_build/

* Update yarn.lock
2021-08-23 17:23:42 -04:00
dependabot[bot]
32cb3b3408
Bump flipper from 0.22.0 to 0.22.1 (#14575)
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-08-23 17:15:55 -04:00
dependabot[bot]
9515553097
Bump imgproxy from 2.0.0 to 2.0.1 (#14571) 2021-08-23 16:51:59 -04:00
dependabot[bot]
6828fe1dcd
Bump webpack-dev-server from 3.11.2 to 4.0.0 (#14572) 2021-08-23 16:50:54 -04:00
dependabot[bot]
d327756b6d
Bump sidekiq from 6.2.1 to 6.2.2 (#14577)
Bumps [sidekiq](https://github.com/mperham/sidekiq) from 6.2.1 to 6.2.2.
- [Release notes](https://github.com/mperham/sidekiq/releases)
- [Changelog](https://github.com/mperham/sidekiq/blob/master/Changes.md)
- [Commits](https://github.com/mperham/sidekiq/compare/v6.2.1...v6.2.2)

---
updated-dependencies:
- dependency-name: sidekiq
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-08-23 13:56:02 -06:00
dependabot[bot]
7e3520bb4b
Bump faker from 2.18.0 to 2.19.0 (#14578)
Bumps [faker](https://github.com/faker-ruby/faker) from 2.18.0 to 2.19.0.
- [Release notes](https://github.com/faker-ruby/faker/releases)
- [Changelog](https://github.com/faker-ruby/faker/blob/master/CHANGELOG.md)
- [Commits](https://github.com/faker-ruby/faker/compare/v2.18.0...v2.19.0)

---
updated-dependencies:
- dependency-name: faker
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-08-23 13:50:10 -06:00
dependabot[bot]
3ca1571ec5
Bump @rails/webpacker from 5.4.0 to 5.4.2 (#14573)
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-08-23 15:18:01 -04:00
dependabot[bot]
3a688f7bd1
Bump autoprefixer from 10.3.1 to 10.3.2 (#14568)
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-08-23 15:17:37 -04:00
dependabot[bot]
cb7272fe7f
Bump eslint-plugin-import from 2.24.0 to 2.24.1 (#14570)
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-08-23 15:17:16 -04:00
dependabot[bot]
eac19feecf
Bump chart.js from 3.5.0 to 3.5.1 (#14574)
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-08-23 15:16:53 -04:00
dependabot[bot]
06e9bec1e4
Bump fog-aws from 3.11.0 to 3.12.0 (#14576)
Bumps [fog-aws](https://github.com/fog/fog-aws) from 3.11.0 to 3.12.0.
- [Release notes](https://github.com/fog/fog-aws/releases)
- [Changelog](https://github.com/fog/fog-aws/blob/master/CHANGELOG.md)
- [Commits](https://github.com/fog/fog-aws/compare/v3.11.0...v3.12.0)

---
updated-dependencies:
- dependency-name: fog-aws
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-08-23 12:39:32 -06:00
dependabot[bot]
c30f06e3d5
Bump cloudinary from 1.20.0 to 1.21.0 (#14569)
Bumps [cloudinary](https://github.com/cloudinary/cloudinary_gem) from 1.20.0 to 1.21.0.
- [Release notes](https://github.com/cloudinary/cloudinary_gem/releases)
- [Changelog](https://github.com/cloudinary/cloudinary_gem/blob/master/CHANGELOG.md)
- [Commits](https://github.com/cloudinary/cloudinary_gem/compare/1.20.0...1.21.0)

---
updated-dependencies:
- dependency-name: cloudinary
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-08-23 12:38:19 -06:00
Khadija Sidhpuri
7e91cfe760
Fix Sponsors Image display in homefeed and sponsors page. (#14494) 2021-08-23 10:05:34 -04:00
Jacob Herrington
6d2cdeaf41
Remove myself from codeowners (#14565)
* Remove myself from codeowners

Hey Forem people 👋

It might be worthwhile to add @forem/oss to cover docs or maybe change line 5 to cover **/*.md

* Add forem/oss as code owner for all Markdown files

Co-authored-by: Michael Kohl <citizen428@forem.com>
2021-08-23 13:16:18 +02:00
Suzanne Aitchison
ee2c3bf1eb
swap position of profile dropdown for users (#14559) 2021-08-23 08:32:25 +01:00
dependabot[bot]
980bcf198e
Bump webpacker from 5.4.0 to 5.4.2 (#14561)
Bumps [webpacker](https://github.com/rails/webpacker) from 5.4.0 to 5.4.2.
- [Release notes](https://github.com/rails/webpacker/releases)
- [Changelog](https://github.com/rails/webpacker/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rails/webpacker/compare/v5.4.0...v5.4.2)

---
updated-dependencies:
- dependency-name: webpacker
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-08-23 09:37:03 +07:00
dependabot[bot]
16087eded6
Bump webdrivers from 4.6.0 to 4.6.1 (#14560)
Bumps [webdrivers](https://github.com/titusfortner/webdrivers) from 4.6.0 to 4.6.1.
- [Release notes](https://github.com/titusfortner/webdrivers/releases)
- [Changelog](https://github.com/titusfortner/webdrivers/blob/master/CHANGELOG.md)
- [Commits](https://github.com/titusfortner/webdrivers/compare/v4.6.0...v4.6.1)

---
updated-dependencies:
- dependency-name: webdrivers
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-08-22 15:23:25 +02:00
Suzanne Aitchison
a095d58df1
fix skip content link flashing on mobile (#14557) 2021-08-20 10:48:35 -06:00
Michael Kohl
08d82e7256
Profile generalization: cleanup (#12947)
* Remove hardcoded instances of education field

* WIP Access display_email_on_profile via User Settings

* Remove unused profile column

* WIP Fix reference to bg_color_hex and text_color_hex

* WIP fix issues revealed by systems specs

* WIP fix issues revealed by services specs

* WIP Fix failing tests

* WIP Fix spec failures

* wip

* Move two attributes from controller to decorator

* Update comment

* Match user settings changes

* More consistently use user.tag_line

Even before the profile changes we sometimes used the user.summary
attribute directly but used the user.tag_line method in other places.

* Remove delegation, rename inline concern

* Drop profile columns from users table

* Remove duplicated work display from header

* Update work profile field handling

* Update DUS + spec

* Delegate more carefully

* Update delegation guard

* Adapt for removed delegation

* Undo accidental schema changes

* Fix seeds

* Remove accidentaly change

* Fix User#processed_website_url

* Update guard clause

* Update profile card content

* Add Organization#profile

* Be more conservative with profile fields

* Spec fixes round 1

* Fix typo

* Update spec

* Limit number of header fields and update card content

* Decorate correct model

* Update factory

* Update schema.rb

* Fix validation

* How bad could this possibly be?

* Pretty bad, nevermind

* Remove obsolete code

* Reset profile fields during test runs

* Move profile fields back to before(:suite)

* Spec fixes

* Remove accidentally re-added files

* More spec fixes

* Specs

* Change User#tag_keywords_for_search

* More spec fixes

* Add comment

* Undo accidental schema changes

* Attempt spec fix

* Remove fix attempt

* Fix e2e test

* Update spec

* Remove guard clause

* Remove hardcoded instances of education field

* WIP Access display_email_on_profile via User Settings

* Remove unused profile column

* WIP fix issues revealed by systems specs

* WIP fix issues revealed by services specs

* WIP Fix failing tests

* WIP Fix spec failures

* wip

* Move two attributes from controller to decorator

* Update comment

* More consistently use user.tag_line

Even before the profile changes we sometimes used the user.summary
attribute directly but used the user.tag_line method in other places.

* Remove education

* Add comment

* WIP

* Clean up mostly_work_with

* WIP

* Update work profile field handling

* More work-related changes

* Remove settings_only from display_area enum

* Remove quickfix from _metadata partial

* Remove special attributes

* Remove leftover spec

* Retrieve location from profile, not user

* Profile.special_attributes no longer exists

* Update specs

* More spec fixes

* Update UsersController

* Update UsersController and spec

* Fix e2e seeds

* Minor cleanup

* More e2e seed fixes

* Fix profile field CSV

* Fix e2e seeds

* Move one more attribute in e2e seeds

* Remove duplicate line

* Clear inputs before typing in them

* Fix formatting issues

* Profiles::Update -> Users::Update

* Remove RegistrationsController#resolve_profile_field_issues

* Fix schema.rb

* More cleanup

* Fix specs

* Fix remaining spec

Co-authored-by: Jacob Herrington <jacobherringtondeveloper@gmail.com>
2021-08-20 16:36:02 +02:00
Suzanne Aitchison
19db4b0287
[15 min fix] Initialize follow button on podcast page (#14556)
* init follow button on podcast page

* add cypress tests

* remove extra podcast seed
2021-08-20 09:15:06 -05:00
dependabot[bot]
a55f57219b
Bump core-js from 3.16.1 to 3.16.2 (#14525) 2021-08-20 07:01:08 -04:00
Aayush Gupta
4280434aed
Make podcast-playback to be controllable via keyboard (#14139)
* Make podcast-playback to be controllable via keyboard

* Add improved state handling for the play/pause controller

* Fix business logic + Improve HTML semantics

* Remove manual tabIndex addition (not required now)

* Refactor redudant event-listener

* Keep aria-pressed label in sync in all cases

* Code refactor

* Add seed data to create a test podcast

* Add a static file and use that as example podcast episode (#1)

Rather than relying at test time on external media, and requiring the
podcast episode import flow to run during e2e testing, just insert a
canned episode that shows.

Confirmed in cypress this does show after visit('/pod') in the
togglePodcastPlayback.spec.js

* Add cypress test

* Move cypress tests

* Update cypress/integration/seededFlows/podcastFlows/togglePodcastPlayback.spec.js

Co-authored-by: Suzanne Aitchison <suzanne@forem.com>

* fix button name in test

Co-authored-by: Daniel Uber <djuber@gmail.com>
Co-authored-by: rhymes <github@rhymes.dev>
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
2021-08-20 12:45:53 +02:00
dependabot[bot]
0479d61d02
Bump listen from 3.6.0 to 3.7.0 (#14552)
Bumps [listen](https://github.com/guard/listen) from 3.6.0 to 3.7.0.
- [Release notes](https://github.com/guard/listen/releases)
- [Commits](https://github.com/guard/listen/compare/v3.6.0...v3.7.0)

---
updated-dependencies:
- dependency-name: listen
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-08-20 12:01:12 +02:00
Suzanne Aitchison
f49a6ce6d5
Revise editor publish logic (#14546)
* revise publish logic

* refactor arguments
2021-08-20 09:04:11 +01:00
dependabot[bot]
0d6cfa7501
Bump rubocop from 1.19.0 to 1.19.1 (#14549)
Bumps [rubocop](https://github.com/rubocop/rubocop) from 1.19.0 to 1.19.1.
- [Release notes](https://github.com/rubocop/rubocop/releases)
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop/rubocop/compare/v1.19.0...v1.19.1)

---
updated-dependencies:
- dependency-name: rubocop
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-08-20 09:53:15 +07:00
Michael Kohl
2b0f2bd0d4
Add bio to onboarding (#14544) 2021-08-20 09:39:01 +07:00
dependabot[bot]
15142a4597
Bump rails from 6.1.4 to 6.1.4.1 (#14550)
Bumps [rails](https://github.com/rails/rails) from 6.1.4 to 6.1.4.1.
- [Release notes](https://github.com/rails/rails/releases)
- [Commits](https://github.com/rails/rails/compare/v6.1.4...v6.1.4.1)

---
updated-dependencies:
- dependency-name: rails
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-08-19 15:47:58 -06:00
Andy Zhao
0dd8ea0866
Look for <html> tags instead of <body> for other emails (#14547) 2021-08-19 16:53:45 -04:00
dependabot[bot]
3021a10b2d
Bump cypress-rails from 0.5.1 to 0.5.2 (#14551)
Bumps [cypress-rails](https://github.com/testdouble/cypress-rails) from 0.5.1 to 0.5.2.
- [Release notes](https://github.com/testdouble/cypress-rails/releases)
- [Changelog](https://github.com/testdouble/cypress-rails/blob/main/CHANGELOG.md)
- [Commits](https://github.com/testdouble/cypress-rails/compare/v0.5.1...v0.5.2)

---
updated-dependencies:
- dependency-name: cypress-rails
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-08-19 14:06:00 -06:00
Daniel Uber
ccbac93ea5
Only print BUILDKITE environment variables when they were present (#14487)
* Only print BUILDKITE environment variables when they were present

This was causing errors running the build_containers.sh script
locally, since only buildkite was passing these (and errors stop the
script, so nothing was built).

* Simplify conditional guards to check only for BUILDKITE variable

https://buildkite.com/docs/pipelines/environment-variables#bk-env-vars-buildkite
describes the simplest "this is buildkite" check, BUILDKITE is always
true when running in buildkite.
2021-08-19 11:42:42 -05:00
Alex
bcd804f44d
Add user count to instance API (#14543)
* Add user count to instance API

* Use estimated_count
2021-08-19 10:55:40 -04:00
Fernando Valverde
5d4475549b
Remove ahoy from Share Post dropdown (#14537) 2021-08-19 08:37:58 -06:00
ludwiczakpawel
49fb50e979
styling of DL DT DD (#14545) 2021-08-19 11:02:07 +02:00
dependabot[bot]
a9dd098154
Bump rubocop-performance from 1.11.4 to 1.11.5 (#14540)
Bumps [rubocop-performance](https://github.com/rubocop/rubocop-performance) from 1.11.4 to 1.11.5.
- [Release notes](https://github.com/rubocop/rubocop-performance/releases)
- [Changelog](https://github.com/rubocop/rubocop-performance/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop/rubocop-performance/compare/v1.11.4...v1.11.5)

---
updated-dependencies:
- dependency-name: rubocop-performance
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-08-19 10:58:38 +02:00