maverick/docbrown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

#12643 Add eslint rule for formatting redundant curly braces in jsx (#14592)

Browse source
This commit is contained in:
Nikhil Taneja 2021-08-26 20:45:06 +05:30 • committed by GitHub
parent c16ec1d53d
commit ff008e4702
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 8 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
app/javascript/.eslintrc.js
View file

@ -56,6 +56,10 @@ module.exports = {
'jsx-a11y/no-onchange': 'off',
'prefer-const': ['error'],
'prefer-destructuring': ['warn', { object: true, array: false }],
'react/jsx-curly-brace-presence': [
'error',
{ props: 'never', children: 'never' },
],
},
overrides: [
{

2
app/javascript/chat/message.jsx
View file

@ -109,7 +109,7 @@ export const Message = ({
<div
id={dropdownContentId}
className={`messagebody__dropdownmenu report__abuse__button hidden`}
className="messagebody__dropdownmenu report__abuse__button hidden"
>
<Button
variant="ghost-danger"

7
app/javascript/utilities/codeFullscreenModeSwitcher.js
View file

@ -1,9 +1,8 @@
let isFullScreenModeCodeOn = false;
let screenScroll = 0;
const fullScreenWindow = document.getElementsByClassName(
'js-fullscreen-code',
)[0];
const body = document.body;
const fullScreenWindow =
document.getElementsByClassName('js-fullscreen-code')[0];
const { body } = document;
function setAfterFullScreenScrollPosition() {
window.scrollTo(0, screenScroll);