From ff008e4702d4f56944a86edea77cc186a4ae26f0 Mon Sep 17 00:00:00 2001
From: Nikhil Taneja <taneja.nikhil03@gmail.com>
Date: Thu, 26 Aug 2021 20:45:06 +0530
Subject: [PATCH] #12643 Add eslint rule for formatting redundant curly braces
 in jsx (#14592)

---
 app/javascript/.eslintrc.js                            | 4 ++++
 app/javascript/chat/message.jsx                        | 2 +-
 app/javascript/utilities/codeFullscreenModeSwitcher.js | 7 +++----
 3 files changed, 8 insertions(+), 5 deletions(-)

diff --git a/app/javascript/.eslintrc.js b/app/javascript/.eslintrc.js
index b5e828790..428288345 100644
--- a/app/javascript/.eslintrc.js
+++ b/app/javascript/.eslintrc.js
@@ -56,6 +56,10 @@ module.exports = {
     'jsx-a11y/no-onchange': 'off',
     'prefer-const': ['error'],
     'prefer-destructuring': ['warn', { object: true, array: false }],
+    'react/jsx-curly-brace-presence': [
+      'error',
+      { props: 'never', children: 'never' },
+    ],
   },
   overrides: [
     {
diff --git a/app/javascript/chat/message.jsx b/app/javascript/chat/message.jsx
index 07dedc595..dc91dcf39 100644
--- a/app/javascript/chat/message.jsx
+++ b/app/javascript/chat/message.jsx
@@ -109,7 +109,7 @@ export const Message = ({
 
       <div
         id={dropdownContentId}
-        className={`messagebody__dropdownmenu report__abuse__button hidden`}
+        className="messagebody__dropdownmenu report__abuse__button hidden"
       >
         <Button
           variant="ghost-danger"
diff --git a/app/javascript/utilities/codeFullscreenModeSwitcher.js b/app/javascript/utilities/codeFullscreenModeSwitcher.js
index 4bcef2742..14d6a3526 100644
--- a/app/javascript/utilities/codeFullscreenModeSwitcher.js
+++ b/app/javascript/utilities/codeFullscreenModeSwitcher.js
@@ -1,9 +1,8 @@
 let isFullScreenModeCodeOn = false;
 let screenScroll = 0;
-const fullScreenWindow = document.getElementsByClassName(
-  'js-fullscreen-code',
-)[0];
-const body = document.body;
+const fullScreenWindow =
+  document.getElementsByClassName('js-fullscreen-code')[0];
+const { body } = document;
 
 function setAfterFullScreenScrollPosition() {
   window.scrollTo(0, screenScroll);