Commit graph

7488 commits

Author SHA1 Message Date
Ben Halpern
f88784cc35
Add configuration for admins to specify compliant email strategies (#20663)
* Add configuration for admins to specify compliant email strategies

* Add keys for test
2024-02-21 08:27:26 -08:00
Daniel M Brasil
406e3fec4d
Rremove de-indexing From Accounts With No Comments (#20660)
* remove de-indexing from accounts that have no comments

* add specs for Article#skip_indexing?
2024-02-21 10:54:02 +00:00
Ben Halpern
d8ed35a94e
Unwrap user before passing to field_test (#20667) 2024-02-20 16:28:52 -08:00
Ben Halpern
44809ce7e7
Add max style for fixed billboard (#20666) 2024-02-20 16:14:59 -08:00
Ben Halpern
223fb9cbfb
Add a/b test for feed style on new users (#20664)
* Add a/b test for feed style on new users

* Add current_user check

* Adjust to not look for current_user right away

* Move field test to the right place
2024-02-20 15:43:28 -08:00
Ben Halpern
17d81b6cb1
[Hotfix] Fix cache key (#20658)
* Fix cache key

* Small style tweak
2024-02-19 19:24:36 -08:00
Ben Halpern
caa7b5a63a
[Hot fix] Fix style bugs with registration page (#20656)
* Fix style bugs with registration page

* Small additonal style tweak

* Final style tweak
2024-02-19 18:48:50 -08:00
Ben Halpern
561bdb278c
Change value of signup in success score (#20647) 2024-02-18 10:30:59 -08:00
Ben Halpern
6ef9a83252
Make mobile runtime banner optional (#20637)
* Remove runtime banner

* Show/hide runtime banner setting

* Update app/views/layouts/application.html.erb

* Update app/views/layouts/application.html.erb

* Update app/views/layouts/application.html.erb
2024-02-16 10:45:41 -08:00
Anna Buianova
d0f3fb6fff
Optimize and test comments cache after score change (#20640)
* Add specs for caching article comments, use cache_key_with_version

* Optimize cache busting for spammer comments, reorganized related specs
2024-02-16 14:53:11 +00:00
Makar
c6cef39694
Persist selectedTag filtering of the reading list (#20601)
* persist selectedTag filtering of the reading list when coming back after reading an article

* bugfix -- could not filter back by all tags in mobile

* e2e tests for persisted filtering

---------

Co-authored-by: Mac Siri <mac@forem.com>
2024-02-16 13:06:21 +00:00
Ben Halpern
097057a8dc
New a/b tests for Feb 14 (#20632) 2024-02-14 15:57:41 -05:00
Ben Halpern
8eb41eef8e
Record billboard signup conversions (#20629)
* Record billboard signup conversions

* Update app/models/billboard_event.rb

* Modify click tracking
2024-02-14 14:18:57 -05:00
Ben Halpern
13c105a6b4
Use new_comment as the intersection object for delayed billboard (#20627) 2024-02-14 11:48:04 -05:00
Ben Halpern
205aee8c78
Add billboard for bottom of page with allowance to delay until after reading is finished. (#20616)
* Add delayed behavior

* Add special behavior to billboards

* Fix order for test

* Test clicking outside element when close event is present

* Update app/javascript/packs/billboardAfterRenderActions.js
2024-02-13 11:56:32 -05:00
Anna Buianova
fb09a75352
Update comment updated_at when changing score (#20622)
* Change comment updated_at when updating comment score

* Rubocop fixes
2024-02-13 13:17:24 +00:00
Mac Siri
248f0f55c0
Allow Slack::Messengers to be disabled (#20609) 2024-02-09 17:20:35 +00:00
Philip How
e2035e0c4a
update first post badge name (#20613) 2024-02-09 12:20:14 -05:00
Anna Buianova
e5064b418f
Hide super low score comments if they are child comments (#20612) 2024-02-09 16:24:13 +00:00
Philip How
0be9914aa0
Fix sending Category to SendGrid (#20597)
* add in header for digest emails

* add test

* try different json encoding

* Update app/mailers/digest_mailer.rb

Co-authored-by: Mac Siri <mac@forem.com>

---------

Co-authored-by: Mac Siri <mac@forem.com>
2024-02-08 18:09:57 +00:00
Ben Halpern
9ba5a5fab0
Add client geo to helper method (#20608) 2024-02-08 12:51:37 -05:00
Ben Halpern
1b083f39a4
Ensure at least 0 score for new badge award (#20605) 2024-02-08 17:00:10 +00:00
Ben Halpern
2f9769a89d
Add new sidebar billboard locations and remove legacy campaign area (#20562)
* Add new sidebar billboard locations

* Remove some specs

* Remove campaign tests

* Adjust tag-allowed billboards

* Fix up targeting functionality

* Fix sidebar third render
2024-02-08 16:55:48 +00:00
Philip How
55f191a5ec
Automated First Post Badge (#20600)
* award first post logic, schedule, and tests

* award first post logic, schedule, and tests
2024-02-08 10:11:40 -05:00
Anna Buianova
07ffb2e3be
Removed spammers from followers list (#20603)
* Remove spam and suspended users from followers list (api and dashboards)

* Fixed the api followers endpoint

* Fixed issue with follower_ids query
2024-02-08 13:57:15 +00:00
Ben Halpern
2d9c87d9d3
Add ability to view specific billboard via params in any context if it is live (#20599)
* Fix AudienceSegmentRefreshAllWorker args issue

* Add ability to view specific billboard via params if it is live

* Fix lingering

* Refactor to clean up
2024-02-07 15:11:22 -05:00
Anna Buianova
b43cb38d40
Remove notifications related to spammer actions (after the role is assigned) (#20593) 2024-02-07 17:36:19 +00:00
Philip How
a900050fdc
Add Sendgrid Category to Digest Emails (#20595)
* add in header for digest emails

* add test
2024-02-06 19:02:10 +00:00
Philip How
5bd5e5e1b6
fix image width in newsletter opt in step (#20590) 2024-02-05 12:38:52 -05:00
Ben Halpern
e26b27c7fa
New a/b test for Feb 5 (and add a variable too a hardcoded value) (#20588)
* Fix AudienceSegmentRefreshAllWorker args issue

* New a/b test for Feb 5 (and add a variable too a hardcoded value)
2024-02-05 15:46:03 +00:00
Anna Buianova
7125a62db0
Changed logic for hiding and displaying low-quality marker for comments based on their score (#20581)
* Specs for revised comments thresholds

* Changed thresholds for low quality comments

* Added specs for comments page

* Fixed /comments and related specs

* Reorganized code for comments trees

* Specs for podcasts episodes comments

* Refactored Comments::Tree

* Refactored Comments::Tree + added specs

* Made build_sort_query private
2024-02-05 09:27:24 -05:00
Ben Halpern
9b93b12f05
Fix AudienceSegmentRefreshAllWorker args issue (#20576)
* Fix AudienceSegmentRefreshAllWorker args issue

* Update test

* Fix

* Fix test

---------

Co-authored-by: Mac Siri <krairit.siri@gmail.com>
2024-01-31 13:48:13 -05:00
Philip How
15bac7afbc
Add safe-navigation for note author (#20571) 2024-01-30 15:18:59 -05:00
Ben Halpern
ee29318126
Add a/b test for which comments to show in feed (#20332)
* Add a/b test for which comments to show in feed

* Adjust figure

* Started at

* Move scope placement around

* Add tests for different comments_variants passed

* Fix typo
2024-01-29 12:18:50 -05:00
Ben Halpern
6d669c8a5c
Add new feed experiment for Jan 26 (#20563)
* Add a/b tests for Jan 26

* Fix feed lever

* Update config/field_test.yml

* Update config/field_test.yml

* Update app/models/articles/feeds.rb
2024-01-26 16:53:26 -05:00
Anna Buianova
58bd07d729
Render 404 when root comment has low score and no children (#20560) 2024-01-26 17:21:18 +00:00
Mac Siri
afa73e06e3
Replace Webpacker with Esbuild (#20470)
* Migrate to esbuild WIP

* Add exclude

* Remove redundant file

* Move file

* Move to javascript_include_tag

* Lint fix

* WIP

* WIP

* Add watch mode to esbuild WIP

* Get jest working

* Remove babel

* Revert "Remove babel"

This reverts commit 6da35260aa19d6f97f586deb66c0ecaf48433b73.

* More WIP

* Got image to load

* WIP

* Resolve audit

* Lint fix

* WIP

* Fix jest spec

* [CI] Remove asset-restore for test build stage

* Production compliant

* Temp disable sourcemap

* Update glob

* Add esbuild helper to stimulus

* Import fragment

* Temp disable coverage to see failing tests

* Fix broken spec

* Address lint

* Set proper es6 target

* Use esbuild for everything

* wait what

* Revert "Set proper es6 target"

This reverts commit 98f5278093421baa8ffe2ca580845b01c1a1eadf.

* Revert "Use esbuild for everything"

This reverts commit 0ac46738f07ffcb6af095ccb1ffa5e439b7fefa3.

* Replace uglifier with terser

* New compiled assets version

* Remvoe honeybadger-io/webpack

* Remove cypress coverage checks for now

* Update jsconfig.json

* Update docker-compose

* Remove public/packs-test from ci cache
2024-01-25 20:29:21 +00:00
Anna Buianova
a4d9b4f0d1
Hide low score comments on user profile (#20556) 2024-01-25 16:06:50 +00:00
Ben Halpern
b763ba8544
Allow pages to have subdirectories (#20549)
* Allow pages to have subdirectories

* Add locale text
2024-01-24 16:09:29 -05:00
Philip How
7149558f34
order flags by users, then comments, then articles (#20462)
Co-authored-by: Anna Buianova <lightallloy@gmail.com>
2024-01-24 10:07:28 -05:00
Philip How
d615fcef56
Add new members filter to mod center (#20542)
* fix jest

* Update safe_params_list.vcl

---------

Co-authored-by: Ben Halpern <bendhalpern@gmail.com>
2024-01-23 16:07:45 -05:00
Anna Buianova
321540ec08
Hide low quality comments from an article page (#20541)
* Hide low-score (< -50) comments for signed in users on article page

* Use low quality threshold

* Show deleted message for low-quality for signed-in users + hide if no children

* Remove irrelevant changes

* Skip view test for low-quality

* Removed irrelevant (yet) tests

* Fixed low score threshold in specs descriptions
2024-01-23 20:33:12 +00:00
Ben Halpern
d86689f63d
Allow pages to render .txt requests (#20547)
* Allow pages to render .txt requests

* Adjust routes
2024-01-22 11:12:22 -05:00
Philip How
b593ecd323
Change 🧐 to 🚩 (#20537)
* inital pass

* icon title

* fix locale issues failing tests
2024-01-22 15:53:25 +00:00
Anna Buianova
947aaef7c1
Return 404 if user is a spammer (#20546) 2024-01-22 15:20:42 +00:00
Ben Halpern
aab0a19011
Allow configuration to conditionally prefer Cloudflare over Cloudinary (#20539)
* Allow configuration to conditionally prefer Cloudflare over Cloudinary

* Update app/services/images/optimizer.rb

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Fix some lints

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2024-01-19 09:45:36 -05:00
Philip How
c11160d2f7
switch class for mod icon in top bar (#20540) 2024-01-19 09:33:54 -05:00
Ben Halpern
66f3ae71b5
Adjust comment notification logic (#20534)
* Adjust comment notification logic

* Update spec/models/comment_spec.rb

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update spec/models/comment_spec.rb

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update spec/models/comment_spec.rb

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2024-01-17 12:22:50 -05:00
Philip How
fb855c97bd
Update badge awarding language (#20516)
* update badge language files

* update admin controller

* fix tests

* no actually fix the tests

* remove 'community' from notification

* fix spec

* fix interpolations
2024-01-17 09:26:19 -05:00
Ben Halpern
16ff57c2ff
Add HTML customization to admin (#20531)
* Add HTML customization to admin

* Update spec/requests/stories_index_spec.rb

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2024-01-17 12:12:22 +00:00