maverick/docbrown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Change value of signup in success score (#20647)

Browse source
This commit is contained in:
Ben Halpern 2024-02-18 10:30:59 -08:00 • committed by GitHub
parent 6ef9a83252
commit 561bdb278c
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
app/controllers/billboard_events_controller.rb
View file

@ -1,6 +1,6 @@
class BillboardEventsController < ApplicationMetalController
include ActionController::Head
SIGNUP_SUCCESS_MODIFIER = 10 # One signup is worth 10 clicks
SIGNUP_SUCCESS_MODIFIER = 25 # One signup is worth 25 clicks
# No policy needed. All views are for all users
def create

4
spec/requests/billboard_events_spec.rb
View file

@ -69,8 +69,8 @@ RSpec.describe "BillboardEvents" do
params: { billboard_event: ad_event_params.merge(category: BillboardEvent::CATEGORY_SIGNUP) },
)
# 13 / 4 = 3.25 because 3 clicks + (1 signup * 10) / 4 impressions
expect(billboard.reload.success_rate).to eq(3.25)
# 28 / 4 = 7 -> because 3 clicks and one signup is 28 (signup worth 25 clicks)
expect(billboard.reload.success_rate).to eq(7)
end
it "assigns event to current user" do