diff --git a/app/controllers/billboard_events_controller.rb b/app/controllers/billboard_events_controller.rb index b6c3ded9c..66d3fb59e 100644 --- a/app/controllers/billboard_events_controller.rb +++ b/app/controllers/billboard_events_controller.rb @@ -1,6 +1,6 @@ class BillboardEventsController < ApplicationMetalController include ActionController::Head - SIGNUP_SUCCESS_MODIFIER = 10 # One signup is worth 10 clicks + SIGNUP_SUCCESS_MODIFIER = 25 # One signup is worth 25 clicks # No policy needed. All views are for all users def create diff --git a/spec/requests/billboard_events_spec.rb b/spec/requests/billboard_events_spec.rb index dced57cdf..0e18c428f 100644 --- a/spec/requests/billboard_events_spec.rb +++ b/spec/requests/billboard_events_spec.rb @@ -69,8 +69,8 @@ RSpec.describe "BillboardEvents" do params: { billboard_event: ad_event_params.merge(category: BillboardEvent::CATEGORY_SIGNUP) }, ) - # 13 / 4 = 3.25 because 3 clicks + (1 signup * 10) / 4 impressions - expect(billboard.reload.success_rate).to eq(3.25) + # 28 / 4 = 7 -> because 3 clicks and one signup is 28 (signup worth 25 clicks) + expect(billboard.reload.success_rate).to eq(7) end it "assigns event to current user" do