maverick/docbrown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Make mobile runtime banner optional (#20637)

Browse source 
* Remove runtime banner

* Show/hide runtime banner setting

* Update app/views/layouts/application.html.erb

* Update app/views/layouts/application.html.erb

* Update app/views/layouts/application.html.erb
This commit is contained in:
Ben Halpern 2024-02-16 10:45:41 -08:00 • committed by GitHub
parent e386a7ec15
commit 6ef9a83252
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 16 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
app/models/settings/user_experience.rb
View file

@ -42,6 +42,9 @@ module Settings
setting :display_in_directory, type: :boolean, default: true
setting :award_tag_minimum_score, type: :integer, default: 100
# Mobile App
setting :show_mobile_app_banner, type: :boolean, default: true
# Head and footer content
setting :head_content, type: :string, default: ""
setting :bottom_of_body_content, type: :string, default: ""

9
app/views/admin/settings/forms/_user_experience.html.erb
View file

@ -115,6 +115,15 @@
</p>
</div>
</div>
<div class="crayons-field crayons-field--checkbox">
<%= f.check_box :show_mobile_app_banner, checked: Settings::UserExperience.show_mobile_app_banner, class: "crayons-checkbox" %>
<div class="mt-0">
<%= admin_config_label :show_mobile_app_banner, model: Settings::UserExperience %>
<p class="crayons-field__description">
Do you want the Forem mobile banner to show on your Forem?
</p>
</div>
</div>
<div class="crayons-field">
<%= admin_config_label :head_content, model: Settings::UserExperience %>
<%= admin_config_description Constants::Settings::UserExperience.details[:head_content][:description] %>

5
app/views/layouts/application.html.erb
View file

@ -18,7 +18,10 @@
<% end %>
<meta name="environment" content="<%= Rails.env %>">
<%= render "layouts/styles", qualifier: "main" %>
<%= javascript_include_tag "base", "application", "baseInitializers", "Search", "runtimeBanner", "baseTracking", defer: true %>
<%= javascript_include_tag "base", "application", "baseInitializers", "Search", "baseTracking", defer: true %>
<% if Settings::UserExperience.show_mobile_app_banner %>
<%= javascript_include_tag "runtimeBanner", defer: true %>
<% end %>
<% if user_signed_in? %>
<%= javascript_include_tag "onboardingRedirectCheck", "contentDisplayPolicy", defer: true %>
<% end %>