From 6ef9a83252efc1ee9ac4fb1dc1eee00f792bfb04 Mon Sep 17 00:00:00 2001 From: Ben Halpern Date: Fri, 16 Feb 2024 10:45:41 -0800 Subject: [PATCH] Make mobile runtime banner optional (#20637) * Remove runtime banner * Show/hide runtime banner setting * Update app/views/layouts/application.html.erb * Update app/views/layouts/application.html.erb * Update app/views/layouts/application.html.erb --- app/models/settings/user_experience.rb | 3 +++ app/views/admin/settings/forms/_user_experience.html.erb | 9 +++++++++ app/views/layouts/application.html.erb | 5 ++++- 3 files changed, 16 insertions(+), 1 deletion(-) diff --git a/app/models/settings/user_experience.rb b/app/models/settings/user_experience.rb index a04a994dc..4949f2fad 100644 --- a/app/models/settings/user_experience.rb +++ b/app/models/settings/user_experience.rb @@ -42,6 +42,9 @@ module Settings setting :display_in_directory, type: :boolean, default: true setting :award_tag_minimum_score, type: :integer, default: 100 + # Mobile App + setting :show_mobile_app_banner, type: :boolean, default: true + # Head and footer content setting :head_content, type: :string, default: "" setting :bottom_of_body_content, type: :string, default: "" diff --git a/app/views/admin/settings/forms/_user_experience.html.erb b/app/views/admin/settings/forms/_user_experience.html.erb index 283e087ef..00ce008c8 100644 --- a/app/views/admin/settings/forms/_user_experience.html.erb +++ b/app/views/admin/settings/forms/_user_experience.html.erb @@ -115,6 +115,15 @@

+
+ <%= f.check_box :show_mobile_app_banner, checked: Settings::UserExperience.show_mobile_app_banner, class: "crayons-checkbox" %> +
+ <%= admin_config_label :show_mobile_app_banner, model: Settings::UserExperience %> +

+ Do you want the Forem mobile banner to show on your Forem? +

+
+
<%= admin_config_label :head_content, model: Settings::UserExperience %> <%= admin_config_description Constants::Settings::UserExperience.details[:head_content][:description] %> diff --git a/app/views/layouts/application.html.erb b/app/views/layouts/application.html.erb index 4f2817989..a60d496ba 100644 --- a/app/views/layouts/application.html.erb +++ b/app/views/layouts/application.html.erb @@ -18,7 +18,10 @@ <% end %> <%= render "layouts/styles", qualifier: "main" %> - <%= javascript_include_tag "base", "application", "baseInitializers", "Search", "runtimeBanner", "baseTracking", defer: true %> + <%= javascript_include_tag "base", "application", "baseInitializers", "Search", "baseTracking", defer: true %> + <% if Settings::UserExperience.show_mobile_app_banner %> + <%= javascript_include_tag "runtimeBanner", defer: true %> + <% end %> <% if user_signed_in? %> <%= javascript_include_tag "onboardingRedirectCheck", "contentDisplayPolicy", defer: true %> <% end %>