Commit graph

6436 commits

Author SHA1 Message Date
jkrsn98
dbdc6ead38
[deploy] API: add created_at datetime to comments (#9829)
* added created_at to comments in api response

* added test to ensure a date is returned for comment

* fix offenses in test

* updated docs to include addition of created_at to comment api response
2020-08-17 20:10:24 -04:00
Fernando Valverde
5342602298
Social Auth generalization refactor (#9837)
* Add gem omniauth-apple

* Integrate omniauth-apple

* Integrate callback

* Add fields

* Add tests, fix bugs and make it all work

* Show only enabled providers for the current user

* Add default profile image for Apple

* Remove localhost patch

* Bring over the changed Apple username if the user changes it

* More specs fixed

* Incorporate feedback from PR

* Fix specs

* Simplify code and fix spec

* Fix Broadcast generators to take into account the new provider

* Fix spec

* Generate a truly unique apple_username

* Fix user specs

* Add omniauth-apple-0.0.2 to vendor cache

* Fix merge conflict and spec

* Update VCR fastly sloan cassette

* Revert "Generate a truly unique apple_username"

This reverts commit 2462875575b0bbd6b3c1d56b25afcd3189671608.

* Fix user specs

* Fix specs

* Fix specs

* Hide Connect Apple button behind a feature flag

* Revert "Hide Connect Apple button behind a feature flag"

This reverts commit 105bde0373389a4eb9b6e948f60734c7e0e99cba.

* Fix line lengths

* Fix spec

* ES tag

* CSRF bypass for Apple callback

* custom user_nickname in Apple provider with small tweaks + omniauth-apple bump

* Fixes username specs

* Makes Apple users default image Users::ProfileImageGenerator

* Fallback to mascot_image_url in test environment to avoid breaking Travis

* Fixes Apple CSRF error + makes default nickname more readable

* Trigger Travis

* Removes CSRF Apple fix from Omniauth callbacks

* Removes Envfile

Co-authored-by: rhymes <rhymesete@gmail.com>
Co-authored-by: rhymes <rhymes@hey.com>
2020-08-17 20:09:44 -04:00
Joe Doss
c408bd859d
Comments out the USER directive due to issues with podman-compose. (#9835)
This post on https://forem.dev/avalerionv/difficulty-installing-forem-on-ubuntu-18-04-tls-4eh6

talks about issues running Forem on Linux. Digging into the issue it seems that
podman-compose does not pass the --userns=keep-id flag correctly to podman so
files and directories mounted as root and not as the user. This causes permission
denied errors.
2020-08-17 19:41:07 -04:00
Molly Struve
acff871235
[deploy] Add Logging Statements to Debug Hypershield Refresh Not Working on Heroku (#9838) 2020-08-17 18:39:19 -05:00
Molly Struve
702cece697
Flaky Spec Fix:Ensure We Find Articles With Tags and Dont Cache Count for Class Method (#9833) 2020-08-17 18:38:26 -05:00
dependabot-preview[bot]
10d4053210
Bump babel-jest from 26.2.2 to 26.3.0 (#9814) 2020-08-17 17:15:09 -04:00
Molly Struve
0646c10bf8
[deploy] Documenation: Update API Article Update Rate Limit Value to 30 (#9832) 2020-08-17 15:17:15 -05:00
dependabot-preview[bot]
ed1af664b5
Bump ibm-openapi-validator from 0.28.1 to 0.29.0 (#9817) 2020-08-17 15:22:21 -04:00
dependabot-preview[bot]
02b9fb322e
Bump @testing-library/jest-dom from 5.11.2 to 5.11.3 (#9821) 2020-08-17 15:21:42 -04:00
dependabot-preview[bot]
9b2dacc52a
Bump jest from 26.2.2 to 26.4.0 (#9820) 2020-08-17 14:39:01 -04:00
Molly Struve
db98a8e224
[deploy] Bug Fix:Remove User Roles From Elasticsearch Returned Data (#9831) 2020-08-17 13:17:53 -05:00
Michael Kohl
1c1ab8b709
Add PUBLIC_CONTROLLERS constant (#9825) 2020-08-17 14:05:25 -04:00
Molly Struve
8d66d3c492
[deploy] Feature:Move Metric Rake Tasks to Sidekiq Cron (#9794) 2020-08-17 11:47:25 -05:00
dependabot-preview[bot]
f536edd24d
Bump twilio-video from 2.7.1 to 2.7.2 (#9822)
Bumps [twilio-video](https://github.com/twilio/twilio-video.js) from 2.7.1 to 2.7.2.
- [Release notes](https://github.com/twilio/twilio-video.js/releases)
- [Changelog](https://github.com/twilio/twilio-video.js/blob/master/CHANGELOG.md)
- [Commits](https://github.com/twilio/twilio-video.js/compare/2.7.1...2.7.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-08-17 18:28:25 +02:00
Molly Struve
d02a4cdc67
[deploy] Bug Fix:Increase look back time for Cron jobs to 120 seconds (#9797) 2020-08-17 11:11:52 -05:00
rhymes
7c82487842
[deploy] Add missing foreign keys to DisplayAdEvent (#9786) 2020-08-17 16:46:40 +02:00
JUNO_OKYO
1b4e5014ae
Add "autofocus" and "required" attributes to the email field (#9790)
* Add autofocus

* Add required
2020-08-17 16:08:05 +02:00
Rafi
76ba4a5609
Changing rails version to 6.0.3 in docs (#9802) 2020-08-17 08:59:09 -05:00
Rafi
788e72ad64
Fixing broken link to dynamic imports (#9803) 2020-08-17 08:55:48 -05:00
dependabot-preview[bot]
791c7cc9bc
[deploy] Bump eslint-plugin-react from 7.20.5 to 7.20.6 (#9818)
Bumps [eslint-plugin-react](https://github.com/yannickcr/eslint-plugin-react) from 7.20.5 to 7.20.6.
- [Release notes](https://github.com/yannickcr/eslint-plugin-react/releases)
- [Changelog](https://github.com/yannickcr/eslint-plugin-react/blob/master/CHANGELOG.md)
- [Commits](https://github.com/yannickcr/eslint-plugin-react/compare/v7.20.5...v7.20.6)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-08-17 07:21:28 -04:00
Rafi
b3d51967c7
Fixing Preact version in docs (#9808) 2020-08-17 07:21:06 -04:00
dependabot-preview[bot]
ace5132a60
Bump honeybadger from 4.7.0 to 4.7.1 (#9810)
* Bump honeybadger from 4.7.0 to 4.7.1

Bumps [honeybadger](https://github.com/honeybadger-io/honeybadger-ruby) from 4.7.0 to 4.7.1.
- [Release notes](https://github.com/honeybadger-io/honeybadger-ruby/releases)
- [Changelog](https://github.com/honeybadger-io/honeybadger-ruby/blob/master/CHANGELOG.md)
- [Commits](https://github.com/honeybadger-io/honeybadger-ruby/compare/v4.7.0...v4.7.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Bump honeybadger from 4.7.0 to 4.7.1 (Update vendor/cache)

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-08-17 07:20:34 -04:00
dependabot-preview[bot]
b42c0bddb3
Bump eslint from 7.6.0 to 7.7.0 (#9819)
Bumps [eslint](https://github.com/eslint/eslint) from 7.6.0 to 7.7.0.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md)
- [Commits](https://github.com/eslint/eslint/compare/v7.6.0...v7.7.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-08-17 07:20:19 -04:00
JUNO_OKYO
3401d101f7
Add button to clear the whiteboard (#9795) 2020-08-17 10:38:53 +02:00
Emma Goto
977e8aec45
Bump storybook to version 6 (#9766)
* Bump storybook to version 6

* Remove storybook addon-docs and revert back to storybook/addon-notes

Co-authored-by: Nick Taylor <nick@dev.to>
2020-08-17 10:34:43 +02:00
dependabot-preview[bot]
4500fe6f22
Bump rouge from 3.21.0 to 3.22.0 (#9816)
* Bump rouge from 3.21.0 to 3.22.0

Bumps [rouge](https://github.com/rouge-ruby/rouge) from 3.21.0 to 3.22.0.
- [Release notes](https://github.com/rouge-ruby/rouge/releases)
- [Changelog](https://github.com/rouge-ruby/rouge/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rouge-ruby/rouge/compare/v3.21.0...v3.22.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Bump rouge from 3.21.0 to 3.22.0 (Update vendor/cache)

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-08-17 08:29:18 +02:00
dependabot-preview[bot]
f7b2e6d055
Bump bootsnap from 1.4.7 to 1.4.8 (#9815)
* Bump bootsnap from 1.4.7 to 1.4.8

Bumps [bootsnap](https://github.com/Shopify/bootsnap) from 1.4.7 to 1.4.8.
- [Release notes](https://github.com/Shopify/bootsnap/releases)
- [Changelog](https://github.com/Shopify/bootsnap/blob/master/CHANGELOG.md)
- [Commits](https://github.com/Shopify/bootsnap/compare/v1.4.7...v1.4.8)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Bump bootsnap from 1.4.7 to 1.4.8 (Update vendor/cache)

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-08-17 08:28:45 +02:00
dependabot-preview[bot]
097fde92a5
Bump rubocop from 0.89.0 to 0.89.1 (#9812)
* Bump rubocop from 0.89.0 to 0.89.1

Bumps [rubocop](https://github.com/rubocop-hq/rubocop) from 0.89.0 to 0.89.1.
- [Release notes](https://github.com/rubocop-hq/rubocop/releases)
- [Changelog](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop-hq/rubocop/compare/v0.89.0...v0.89.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Bump rubocop from 0.89.0 to 0.89.1 (Update vendor/cache)

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-08-17 08:28:04 +02:00
dependabot-preview[bot]
0b12d731c9
Bump aws-sdk-lambda from 1.46.0 to 1.48.0 (#9811)
* Bump aws-sdk-lambda from 1.46.0 to 1.48.0

Bumps [aws-sdk-lambda](https://github.com/aws/aws-sdk-ruby) from 1.46.0 to 1.48.0.
- [Release notes](https://github.com/aws/aws-sdk-ruby/releases)
- [Changelog](https://github.com/aws/aws-sdk-ruby/blob/master/gems/aws-sdk-lambda/CHANGELOG.md)
- [Commits](https://github.com/aws/aws-sdk-ruby/compare/v1.46.0...v1.48.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Bump aws-sdk-lambda from 1.46.0 to 1.48.0 (Update vendor/cache)

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-08-17 08:27:43 +02:00
dependabot-preview[bot]
1f7ba32967
Bump store_attribute from 0.5.3 to 0.7.1 (#9813)
* Bump store_attribute from 0.5.3 to 0.7.1

Bumps [store_attribute](https://github.com/palkan/store_attribute) from 0.5.3 to 0.7.1.
- [Release notes](https://github.com/palkan/store_attribute/releases)
- [Changelog](https://github.com/palkan/store_attribute/blob/master/CHANGELOG.md)
- [Commits](https://github.com/palkan/store_attribute/compare/v0.5.3...v0.7.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Bump store_attribute from 0.5.3 to 0.7.1 (Update vendor/cache)

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-08-17 10:22:53 +07:00
Michael Kohl
2b3242087c
[deploy] Start using profile model (#9724)
* Persist attribute_name for profile fields

* Update fields

* Add temporary Rake task for creating profile fields

* Update specs

* Fix problems after splitting branch
2020-08-17 09:57:50 +07:00
Andy Zhao
adc347580f
[deploy] Add error handling for comment mod page reactions (#9806)
* Add error handling for comment mod page reactions

* Use alert instead of snackbar
2020-08-15 12:19:57 -04:00
Andy Zhao
07a711a1cc
Add missing .dataset (#9805) 2020-08-15 11:51:44 -04:00
Mac Siri
09dd4fd750
[deploy] Add missing .call (#9791) 2020-08-14 15:59:25 -04:00
Molly Struve
05abf3839c
[deploy] Feature:Use Sidekiq to Run Scheduled Jobs (#9789) 2020-08-14 14:44:31 -05:00
Molly Struve
0a64ac067b
[deploy] Remove ENVied Gem, Use dotenv Take 2 (#9767) 2020-08-14 12:20:47 -05:00
Lisa Sy
df8ac96524
Update styling of authentication feed card for logged out users (#9762) [deploy]
* Update styling of authentication feed card for logged out users

* Update app/views/stories/_sign_in_invitation.html.erb

Co-authored-by: Fernando Valverde <fernando@visualcosita.com>

* Update test

* Update app/assets/stylesheets/signin.scss

Co-authored-by: ludwiczakpawel <ludwiczakpawel@gmail.com>

Co-authored-by: Fernando Valverde <fernando@visualcosita.com>
Co-authored-by: ludwiczakpawel <ludwiczakpawel@gmail.com>
2020-08-14 07:40:18 -07:00
Mac Siri
a081810946
[deploy] Migrate ImageResizer to Images::Optimizer (#9720) 2020-08-14 09:44:30 -04:00
rhymes
0f6baaf4ba
[deploy] Remove orphaned DisplayAdEvent rows (#9765)
* Remove orphaned DisplayAdEvent rows

* Add dependent in the has_many relationship between ads and ad events
2020-08-14 09:29:08 -04:00
Ben Greenberg
e9c513fb3f
Fix broken urls with IDNs in Cloudinary helper (#9391) 2020-08-13 17:46:31 -04:00
Molly Struve
344066bcfe
[deploy] Comment out flaky Blackbox Spec (#9778) 2020-08-13 16:37:36 -05:00
Vaidehi Joshi
63816035bb
Add X-Accel-Expires header to support Nginx caching (#9655) [deploy]
* Replace  in Cache-Control header to support Nginx caching

* Add 'X-Accel-Expires' header for Nginx caching

* Remove max-age directive from remaining specs

* Update caching header specs to test against x-accel-expires header
2020-08-13 14:24:50 -07:00
Alex
3b2c034da6
Generalize liquid tag docs (#9771)
* Generalize liquid tag docs

* Use app_url
2020-08-13 16:52:05 -04:00
Julianna Tetreault
f02c60fa8e
Use .errors_as_sentece in Admin::Badges::Controller (#9772) [deploy] 2020-08-13 14:50:35 -06:00
Andy Zhao
2e5eeeb2a4
[deploy] Remove flash message from article show page (#9768) 2020-08-13 12:50:39 -04:00
rhymes
8b60a18735
Account deletion email: serialize only user's details (#9752)
* Account deletion email: serialize only user's details

* Fix specs and mailer preview
2020-08-13 18:31:56 +02:00
Julianna Tetreault
c18b0f1ba1
Manage Badges in /admin/badges (#9721) [deploy]
* Add CRUD actions for badge management to Internal::Badges::Controller

* Update sytling of badges index view in index.html.erb
  -Uses a table to display all badges
  -Links to the badge edit page from the badge title
  -Displays a badges slug, title, and badge_image
  -Adds an Award Badge button to the index view

* Adds an edit view, edit.html.erb, for badges
  -Gives the ability to edit a badge title and/or slug
  -Adds an Update Badge button to the left of the view
  -Adds a Back to All Badges button to the right of the view
  -Displays the badge image in the edit form

* Adjusts the path names in #award_badges in Internal::Badges::Controller

* Adds CRUD actions to the Internal::Badges::Controller and needed routes

* Add a description field to the edit.html.erb for badge management

* Add #award to Internal::Badges::Controller with matching view and routes
  -Adds an #award method that sets @badge for #award_badges
  -Adds an award.html.erb view for awarding badges
  -Adds an award path for awarding badges
  -Removes unnecessary code from controller, routes, and views

* Adds image upload functionality to the edit view for badges

* Ensure that usernames are downcased when awarding badges
  -Chains downcase to usernames in #award_badges in
   Internal::Badges::Controller

* Move badge-related views from old Internal folder to the correct Admin folder

Change routes and paths from /internal to /admin

* Refactor badge_params in Admin::Badges::Controller

* Add additional tests around awarding and updating badges in /admin/badge_achievements

* Add a create view to /admin/badges
  -Adds new and create actions to Admin::Badges::Controller
  -Adds a create view for creating badges at new.html.erb
  -Adds a Create Badge button to the index view
  -Moves the Award Badges button to the bottom of the index view

* Add a test around creating badges and clean up existing specs in badges_spec.rb

Adjust path in admin_awards_badges_spec.rb to be correct path

* Adjust routes from /badges/award_badges to /badges/badge_achievements/award_badges

Update paths in admin/badge-related specs

* Adjust paths in badges_spec.rb to be admin_badge_achievements_award_badges_path

* Adjust button styling for Award Badge

* Adjust paths back to /admin/badges in badges_spec.rb

* Add clarification around usernames when awarding badges

* Mark test in black_box_spec.rb as pending due to Travis failure

* Change wording used around usernames and @ symbols in award.html.erb
2020-08-13 08:54:51 -06:00
Arit Amana
c1fe6a6488
[deploy] [Moderation] Allow admins to delete comments (#9628)
* Styling of Delete Comment

* Start hooking DELETE action up

* Add new route

* Add new action

* Update comment_policy.rb

* Update specs for comment_policy.rb

* Some more specs

* Update api call

* Building delete functionality

* Still building...

* Complete implementation

* Changes from PR review

* Fix failing spec; rework admin_delete method

* Protect redirect

* Improve admin_delete method

* Protect redirect

* Refactor JS file and admin_delete method

* Fix flash messages issues

* Fix confirm dialog

* Final QA changes
2020-08-13 10:15:48 -04:00
rhymes
d8ec6cb6ef
Upgrade Node JS to latest 12.18 LTS (#9764) 2020-08-13 15:34:18 +02:00
Nick Taylor
ae32687164
Update repository links in PR template (#9760)
* Updated PR template links to https://github.com/forem/forem/...

* Changed DEV to Forem in the wording in the template.
2020-08-12 18:08:56 -04:00