maverick/docbrown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Flaky Spec Fix:Ensure We Find Articles With Tags and Dont Cache Count for Class Method (#9833)

Browse source
This commit is contained in:
Molly Struve 2020-08-17 18:38:26 -05:00 • committed by GitHub
parent 10d4053210
commit 702cece697
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
app/labor/article_suggester.rb
View file

@ -1,7 +1,7 @@
class ArticleSuggester
def initialize(article)
@article = article
@total_articles_count = self.class.memoized_articles_count
@total_articles_count = self.class.articles_count
end
def articles(max: 4)
@ -23,8 +23,8 @@ class ArticleSuggester
end
end
def self.memoized_articles_count
@memoized_articles_count ||= Article.published.estimated_count
def self.articles_count
Article.published.estimated_count
end
private

4
spec/labor/article_suggester_spec.rb
View file

@ -2,13 +2,13 @@ require "rails_helper"
RSpec.describe ArticleSuggester, type: :labor do
it "returns proper number of articles with post with the same tags" do
create_list(:article, 4, featured: true, tags: ["discuss"])
create_list(:article, 4, featured: true, tags: ["discuss"], score: 10)
article = create(:article, featured: true, tags: ["discuss"])
expect(described_class.new(article).articles.size).to eq(4)
end
it "returns proper number of articles with post with different tags" do
create_list(:article, 2, featured: true, tags: ["discuss"])
create_list(:article, 2, featured: true, tags: ["discuss"], score: 10)
create_list(:article, 2, featured: true, tags: ["javascript"])
article = create(:article, featured: true, tags: ["discuss"])
expect(described_class.new(article).articles.size).to eq(4)