From 702cece697aabc6cec4cf124661c7cb21137d09c Mon Sep 17 00:00:00 2001 From: Molly Struve Date: Mon, 17 Aug 2020 18:38:26 -0500 Subject: [PATCH] Flaky Spec Fix:Ensure We Find Articles With Tags and Dont Cache Count for Class Method (#9833) --- app/labor/article_suggester.rb | 6 +++--- spec/labor/article_suggester_spec.rb | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/app/labor/article_suggester.rb b/app/labor/article_suggester.rb index ceb24d536..531d71fe5 100644 --- a/app/labor/article_suggester.rb +++ b/app/labor/article_suggester.rb @@ -1,7 +1,7 @@ class ArticleSuggester def initialize(article) @article = article - @total_articles_count = self.class.memoized_articles_count + @total_articles_count = self.class.articles_count end def articles(max: 4) @@ -23,8 +23,8 @@ class ArticleSuggester end end - def self.memoized_articles_count - @memoized_articles_count ||= Article.published.estimated_count + def self.articles_count + Article.published.estimated_count end private diff --git a/spec/labor/article_suggester_spec.rb b/spec/labor/article_suggester_spec.rb index 5baf9065c..f8a36e75a 100644 --- a/spec/labor/article_suggester_spec.rb +++ b/spec/labor/article_suggester_spec.rb @@ -2,13 +2,13 @@ require "rails_helper" RSpec.describe ArticleSuggester, type: :labor do it "returns proper number of articles with post with the same tags" do - create_list(:article, 4, featured: true, tags: ["discuss"]) + create_list(:article, 4, featured: true, tags: ["discuss"], score: 10) article = create(:article, featured: true, tags: ["discuss"]) expect(described_class.new(article).articles.size).to eq(4) end it "returns proper number of articles with post with different tags" do - create_list(:article, 2, featured: true, tags: ["discuss"]) + create_list(:article, 2, featured: true, tags: ["discuss"], score: 10) create_list(:article, 2, featured: true, tags: ["javascript"]) article = create(:article, featured: true, tags: ["discuss"]) expect(described_class.new(article).articles.size).to eq(4)