Commit graph

12325 commits

Author SHA1 Message Date
Mac Siri
db77be4018
Ignore sitemap_generator and generators (#19010) 2023-01-27 10:31:13 -05:00
Mac Siri
8e76bc046b
Refactor CreatorSettingsForm & spec (#19011) 2023-01-27 08:39:07 -05:00
Joshua Wehner
909fd7f103
Try having sync_reactions_count as a background job (#18991)
* Try having sync_reactable as a background job

* Update test

* Fix flakey test (order should not matter)
2023-01-27 12:58:13 +01:00
Rajat Talesra
bbb8985a51
Fixed bookmark flash issue (#18997)
* Fixed bookmark flash issue

* User nil check
2023-01-27 10:31:03 +05:30
Ridhwana
a37d79f8e5
Refactor display_for method in the display_ad model (#18981)
* feat: sample relevant ads display ads

* Remove jQuery

* Added jquery back to videos

* refactor: pass the relevant paramenters to the newly created service, move the code over to the service, pass through display ads, use the display ads parameter for queries, use instance vars

* refactor: approve and published display ads

* feat: tagged post comment ads

* refactor: display_ads for tagged postcomments

* refactor: authenticated ads

* refactor: sample ads

* fix: oops pass teh parameter)

* refactor: use ... to forward and delegate arguments to the method

* feat: use a filtered_display_ads instance variable in the service instead of passing the relation variable around

* feat: make sure that the instance variable stays upto date

* feta: update the header for comment

* feat: remove the service test for now

* refactor: change the names to make it more readable

* feat: use named parameters

* refactor: we are ordering by success rate just before we sample so why order twice

* chore: remove the reader

* refactor: move into two separate functions

* fix: rename placement_area_ads

* refactor: user_authentication_ads

* Update app/services/display_ads/sample_relevant_ads.rb

Co-authored-by: Joshua Wehner <joshua@forem.com>

* Removed jquery code

* Nit fix

* Revert incorrect code

* Updated jquery code to javascript

* Removed jquery from comments

* refactor: move to query and rename

* chore: move params on diff lines

Co-authored-by: rt4914 <rajattalesra4914@gmail.com>
Co-authored-by: Joshua Wehner <joshua@forem.com>
Co-authored-by: Rajat Talesra <rajat@forem.com>
2023-01-26 19:48:22 +02:00
Ridhwana
9ba3df4453
Round Robin Notification Tweaks (#18995)
* Remove jQuery

* Added jquery back to videos

* feat: increase the available moderator count

* Removed jquery code

* Nit fix

* Revert incorrect code

* Updated jquery code to javascript

* Removed jquery from comments

* feat: updates the last_reacted_at value when saving a creation

* feat: update the query for available moderators

* spec: write a test for the available moderators

* fic: update the reaction spec with current time

* fix: add last_reacted_at to the send_spec

* fix: add last_reacted_at to the user

* chore: move the queries around

* fix: change timecop block

* fix: update the last_reacted_at for the user

* chore: try to fix timecop

* Update app/services/notifications/moderation.rb

Co-authored-by: Mac Siri <mac@forem.com>

* feat: update the tests

Co-authored-by: rt4914 <rajattalesra4914@gmail.com>
Co-authored-by: Rajat Talesra <rajat@forem.com>
Co-authored-by: Mac Siri <mac@forem.com>
2023-01-26 19:31:45 +02:00
Mac Siri
ec3971a387
Create FindsBin spec (#18992) 2023-01-26 10:46:18 -05:00
Rajat Talesra
d4d7d8f409
CSS: Dark mode minor fixes (#19014)
* Dark mode fixes

* Bookmark fix
2023-01-26 15:31:46 +05:30
Fernando Valverde
db821a806f
/comments API docs (#18983)
* file

* Comments API
2023-01-25 12:06:43 -06:00
Joshua Wehner
7f41dae631
Pages API: Read (get index+show) (#18970)
* Pages API pt 1 (read/get/index+show)

* Update spec/requests/api/v1/docs/pages_spec.rb

Co-authored-by: Ridhwana <Ridhwana.Khan16@gmail.com>

* Update spec/requests/api/v1/docs/pages_spec.rb

Co-authored-by: Ridhwana <Ridhwana.Khan16@gmail.com>

* API Key not required for index & show

* API Feature flag has long since been removed

* Page schema

* Fix spec broken by merge

Co-authored-by: Ridhwana <Ridhwana.Khan16@gmail.com>
2023-01-25 17:15:27 +01:00
Anna Buianova
6524406d1d
Fixed redundant article and comment markdown parsing (#18989)
* Fixed redundant article and comment markdown parsing

* Removed useless comments

* Fixed ContentRenderer specs
2023-01-25 13:56:43 +03:00
Rajat Talesra
7c6f269b14
Onboarding dark mode fixees (#18996) 2023-01-25 10:53:59 +05:30
depfu[bot]
99133a6e56
[ruby] Update omniauth-apple: 1.2.2 → 1.3.0 (minor) (#18994)
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
2023-01-24 14:48:16 -05:00
Mac Siri
2218a14fff
Refactor/Improve addTagsToArticle specs (#19006) 2023-01-24 14:48:01 -05:00
Mac Siri
f8469b04fb
Use codecov's automatic flag management (#18927) 2023-01-24 14:47:36 -05:00
Fernando Valverde
8c62f9d6b3
Add the missing API docs for /articles (#18848)
* Progress on more articles API docs

* Some progress

* Broken update article doc spec but some progress

* Fix articles put rswag spec

* Fix spec

* Add missing specs

* Apply PR review feedback
2023-01-24 13:44:29 -06:00
Rajat Talesra
ff790c147e
Removed jQuery usage from admin ( -- now it exists only in views/videos) (#18976)
* Remove jQuery

* Added jquery back to videos

* Removed jquery code

* Nit fix

* Revert incorrect code

* Updated jquery code to javascript

* Removed jquery from comments
2023-01-24 21:03:12 +05:30
Ben Halpern
3aa9aa0b63
Adjust copy in 'trusted' email (#18977)
* Adjust copy in 'trusted' email

* Add trusted email text version
2023-01-24 09:19:35 -05:00
Mac Siri
0a5f1c12f7
Fix broken specs (#18993) 2023-01-23 23:05:42 -05:00
Lawrence
0ac9852663
[API v1 docs] Followed Tags (#18952)
* Followed Tags swag docs

* Update spec/requests/api/v1/docs/followed_tags_spec.rb

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Add to swagger helper

* minor tweaks

* more cleanup

* syntax change

* name change

* User doesn't have to be an admin

* Update spec/requests/api/v1/docs/followed_tags_spec.rb

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update spec/requests/api/v1/docs/followed_tags_spec.rb

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* update v1 json structure

* Update spec/swagger_helper.rb

Co-authored-by: Ridhwana <Ridhwana.Khan16@gmail.com>

* Update spec/requests/api/v1/docs/followed_tags_spec.rb

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* re-generate swagger file

* Update spec/requests/api/v1/docs/followed_tags_spec.rb

Co-authored-by: Ridhwana <Ridhwana.Khan16@gmail.com>

* regenerated swagger file

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Ridhwana <Ridhwana.Khan16@gmail.com>
2023-01-23 13:28:36 -06:00
Joshua Wehner
30c0485507
Frontend for multiple reactions (v1) (#18808)
* Remove extraneous comment (see 9361d2 and 5c18f8)

* Flexible, multiple reaction types

* Fix reaction counts

* Re-use svg for active state for now

* Update yml, update spec

* Possible temp fix for failing tests

* Colorize reaction icon svgs

* Reaction engagement above post title

* Index reactions engagements (for logged-out)

* Maybe readinglist is special

* Try using crayons' dropdown as a drawer?

* readinglist isn't really public now

* feat: update the styles for the reaction drawer

* Grey background highlight, turn off border/shadow

* Read our feature flag docs, saw this was recommended

* Missed fifth emoji: party/tada

* Fix JS test errors

* Update test with tada

* Suppress flashing engagements when no public reactions

* Liberate jump-to-comments from unicorn replacement

* 'Add reaction' on tooltip

* Don't show reaction emoji on index unless it's been used

* rubocop

* Update heart+ total count when toggling

* Do not include 'readinglist' in drawer/public counts

* Fix semi-public readinglist so that icon is badged for current user

* Tweak heart-plus svg

* Style tweak: border on active reaction

* Show reacted icon on drawer trigger for 1.5 sec

* Tweak styles for engagements bar

* Style tweaks for multiple engagements (#index)

* Trying to get size working through crayons/inline_svg

* Sparkle hearts

* Restore unicorn

* Make heart-plus-active work when user has an active reaction

* Try 'hoverdown' a dropdown that activates with hover

* Long touch?

* Tap *outside* the drawer to close

* Mobile reaction drawer is also supposed to be columns

* More reaction count cleanup

* Final emoticons maybe?

* Fix reaction bug when feature disabled

* Remove readinglist from public reaction counts

* Update specs for new reaction categories

* Shuffle makes specs flaky

* Order does not matter

* rubocop

* Update to preserve readinglist analytics

* Shuffle makes specs flaky

* Fix flickering images, remove icon highlight for now

* Don't update total for readinglist

* reactions_by_user_id

* Try renaming this observer function

* Try unid ids for SVGs

* Remove local test file

* Simplistic test for the unique svg transform

* Fix javascript for current SVG

* Signifcant string literals in this case, rubocop

* Use the right expected output

Co-authored-by: Ridhwana <ridhwana.khan16@gmail.com>
2023-01-23 16:00:50 +01:00
Ridhwana
03bee374d2
[API v1 docs] Followers (#18965) 2023-01-20 15:03:39 +02:00
Fernando Valverde
29358453ab
Security fix bump rails, rack & globalid (#18987) 2023-01-20 06:59:37 -06:00
yheuhtozr
ce23832988
I18nize views/pages (#18771) 2023-01-19 17:25:03 -05:00
Mac Siri
14b28a1a9c
Use upload-artifact in CI (#18980) 2023-01-19 07:30:59 -05:00
Fernando Valverde
c24e227f55
Extract Organization#conditionally_update_articles to worker (#18956)
* Extract conditionally_update_articles to worker

* Split to individual articles on workergits

* Fix some failed specs

* Fix another spec
2023-01-18 11:58:57 -06:00
Ridhwana
83afd9f882
Standardize (but also add consistent) headers on the admin (#18936)
* feat: update rubocop to fix some erb_lint errors

* standardize and add headers

* feat: update gemfile

* feat: revert change

* feat: rename gdpr delete requests to gdpr actions

* feat: remove the margin for consistency

* feat: add a skeleton for the api/v1/followers/users spec

* feat: add the operation block

* feat: add two global schema parameters

* feat: add a 'sort' parameter

* feat: add a successful response

* feat: add an unauthorized response

* feat: generate the json

* fix: indentation

* fix: oops remove the spec
2023-01-17 17:07:09 +02:00
depfu[bot]
a44534e2e7
[ruby] Update devise_invitable: 2.0.6 → 2.0.7 (patch) (#18967)
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
2023-01-17 09:07:29 -05:00
Mac Siri
aaf4339b46
Expand CD to include staging (#18966) 2023-01-16 14:20:38 -05:00
Rajat Talesra
4ae1721848
Remove bootstrap library fully with some minor fixes (#18945)
* Minor fixes

* Replaced justify-content-between with justify-content

* Override all heading tags, paragraph tag

* Fixed a tag underline css

* Removed bootstrap library

* Removed duplicate crayons-select class
2023-01-16 20:07:12 +05:30
Mac Siri
3792591507
Expand Badges::AwardYearlyClub to include year 8 (#18959) 2023-01-16 08:51:01 -05:00
Rajat Talesra
ad88837022
Removed double tooltip (#18955) 2023-01-16 11:07:47 +05:30
Mac Siri
68c7308c59
Add Github CD (2nd attempt) (#18960) 2023-01-13 15:51:08 -05:00
Ridhwana
bf88b1e125
[API v1 docs] Profile Images by Username (#18951) 2023-01-13 17:35:47 +02:00
depfu[bot]
1eafdc0a5a
Update cloudinary to version 1.25.0 (#18953)
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
2023-01-12 16:32:30 -05:00
Lawrence
b2a643cfb4
Add CSS for upload button (#18884)
* Add CSS for upload button

* extend current crayon classes
2023-01-12 14:37:44 -06:00
Anna Buianova
7d053471f8
Rubocop fixes in spec/requests (#18946)
* Rubocop fixes in spec/requests

* Fixed spec/requests/api/v0/articles_spec.rb

Co-authored-by: Ridhwana <Ridhwana.Khan16@gmail.com>

Co-authored-by: Ridhwana <Ridhwana.Khan16@gmail.com>
2023-01-12 19:10:16 +03:00
depfu[bot]
700b9fb325
Update strong_migrations to version 1.4.1 (#18954)
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
2023-01-12 08:20:30 -05:00
Ben Halpern
17db5988cd
Feed experiment for 01-11-2023 (#18949)
* Feed experiment for 01-11-2023

* Add winner to yml file
2023-01-11 17:03:29 -05:00
Anna Buianova
1cb759021d
Extract comments rendering (#18904)
* Started using ContentRenderer for comments

* Enabled consistent rendering for comments in specs
2023-01-11 13:24:58 +03:00
Fernando González Tostado
048a718570
fix gists adding width to tds (#18933)
Co-authored-by: Fernando Valverde <fernando@fdo.cr>
2023-01-10 15:01:37 -06:00
Anna Buianova
a2d26df17b
[API V1 docs] Podcast Episodes (#18908)
* Podcast episodes api swagger docs (start)

* Podcast Episodes api swagger docs

* Fixed wording

Co-authored-by: Ridhwana <Ridhwana.Khan16@gmail.com>

* Fixed wording

Co-authored-by: Ridhwana <Ridhwana.Khan16@gmail.com>

* Removed commented code

Co-authored-by: Ridhwana <Ridhwana.Khan16@gmail.com>
2023-01-10 15:01:22 +03:00
depfu[bot]
6e8034eee2
Update all development Bundler dependencies (2023-01-09) (#18934)
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
2023-01-09 16:40:56 -05:00
Ridhwana
53e1321952
Update Rubocop Version to 1.42.0 (#18935)
* feat: update rubocop to fix some erb_lint errors

* feat: update gemfile
2023-01-09 15:02:51 -05:00
Rajat Talesra
838260c105
Quick fix for abuse reports -- bootstrap (#18937) 2023-01-09 21:50:04 +05:30
Aramayis
12e37330c7
Integrate Uffizzi (#18792)
Co-authored-by: Aramayis <>
2023-01-09 10:49:39 -05:00
Rajat Talesra
497f494ef3
Removed nav related classes from feedback tabs (#18924)
* Removed bootstrap from listing_categories, listings, navigation_links

* Removed not-used bootstrap classes from admin/tags

* Removed bootstrap from admin/settings

* Fix collapse glitch in profile-fields

* Feedback partial progress

* Feedback partial progress

* Removed form-control

* Replaced card with crayons-card

* Fixed profile field UI

* Removed collapse hide and show classes

* Removed collapse hide and show classes

* Removed collapse hide and show classes

* Nit height fix

* Nit width fix

* Updated tests

* Removed nav related classes from feedback tabs

* Remove btn-classes from commets too.

* Removed row and col-12 classes

* Removed bootstrap classes from Authentication

* Removed bootstrap classes from Mascot

* Removed bootstrap classes from Onboarding

* Removed bootstrap classes from lock/unlock discussions

* Notes design changes

* Removed bootstrap classes from Organization

* Removed bootstrap classes from Organization

* Remove alert bootstrap class from admin.html.erb

* Fixed tab_pane related code

* Enable click listener on notice

* Enable click listener on notice

* Applied suggested changes

* close bootstrap class removed

* Removed element completely
2023-01-09 20:18:28 +05:30
depfu[bot]
21d24d6be6
Update httparty to version 0.21.0 (#18930)
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
2023-01-09 11:22:57 +01:00
Adarsh Bhadauria
876638194c
Fix search bar disappears on mobile (#18909) 2023-01-09 10:51:40 +02:00
Rajat Talesra
26c72096ba
Remove bootstrap classes : collapse hide show (#18917)
* Removed bootstrap from listing_categories, listings, navigation_links

* Removed not-used bootstrap classes from admin/tags

* Removed bootstrap from admin/settings

* Fix collapse glitch in profile-fields

* Feedback partial progress

* Feedback partial progress

* Removed form-control

* Replaced card with crayons-card

* Fixed profile field UI

* Removed collapse hide and show classes

* Removed collapse hide and show classes

* Removed collapse hide and show classes

* Nit height fix

* Nit width fix

* Updated tests
2023-01-06 21:25:49 +05:30