Commit graph

6478 commits

Author SHA1 Message Date
Arit Amana
d6465750ba
[deploy] [Admin Tooling] Allow admins delete empty Connect Channels (#9873)
* Configure Delete Channel functionality

* Add specs

* Remove unnecessary variable

* Address PR review comments

* Revert optimization of any_admin? method

* Implement @any_admin? properly

* Fix markup to fix the styling

Co-authored-by: rhymes <rhymes@hey.com>
2020-08-20 14:55:48 +02:00
rhymes
99615705ca
[deploy] Add relations and foreign keys between Poll related models (#9854) 2020-08-20 11:14:54 +02:00
Raphael Noriode
30b3592488
[deploy] Listing endorsements: models setup (#9841)
* create listing endorsement model and write test to validate it

* create the classified_listing_endorsements table

* create model associations with seed data and test validations

* modify test and create more seed date for endorsement

* modify the model naming, changed seed data to become radomized and updated the test file

* remove unnecessary function
2020-08-20 11:13:44 +02:00
rhymes
03ed8aedb1
[deploy] Remove orphaned polls related rows (#9855) 2020-08-20 10:40:01 +02:00
Michael Kohl
eff28766fc
[deploy] Migrate profile data (#9750)
* Add temporary Rake task for creating profile fields

* Fix problems after splitting branch

* Add profile migration Rake task

* Add unique index to profiles

* Add migration code to users

* Be smarter about updating profiles

* Update spec

* Update Bullet config

* Fix typo

* Change temporary rake task to data update script

* Re-add profile factory and update spec

* Change private declaration to make CodeClimate happy

* Update comment

* Drop validation in favor of DB default

* Update spec
2020-08-20 11:17:57 +07:00
Michael Kohl
b3e7384e24
[deploy] Automatically refresh profile accessors (#9843)
* Rename method

* Add ProfileFields::Add service

* Add ProfileFields::Remove service

* Use remove_method instead of undef_method

* All hail undef_method
2020-08-19 21:25:59 -04:00
Ben Halpern
e76f6cbbba
Set Stripe dynamically instead of at boot (#9862)
* Set Stripe dynamically instead of at boot

* Add stripe SiteConfig

* Fix capitalization
2020-08-19 21:24:19 -04:00
Molly Struve
adc9c2ab3c
Optimization:Collect More Specific Data From Sidekiq Jobs (#9882) 2020-08-19 21:24:08 -04:00
Molly Struve
f37b2007c8
Flaky Spec Fix:User Comment created_at in Expectation (#9878) 2020-08-19 19:19:06 -05:00
Molly Struve
437a9b2d5f
[deploy] Optimization:Locally Cache any_admin? For User Instance (#9879) 2020-08-19 17:12:34 -05:00
Ben Halpern
986eb87ce8
[deploy] Remove unneeded Analytics update script (#9852)
* Remove unneeded Analytics update script

* Remove constants
2020-08-19 15:57:27 -04:00
Molly Struve
4ac9020112
[deploy] Bug Fix:Run Badge Award Job Twice a Day (#9875) 2020-08-19 14:31:48 -05:00
Ben Halpern
6c71369df5
[deploy] Add community_name to site config (#9864)
* Add community_name to site config

* Fix a spec

* Remove SiteConfig from constants

* Change subjects to method

* Fix subjects method

* Fix linting
2020-08-19 14:54:40 -04:00
Jacob Herrington
1af5e7d9f2
Fix axe warnings on admin/chat_channels (#9871) 2020-08-19 14:54:06 -04:00
Molly Struve
469ce3c533
Refactor:Move Streak Badges to Sidekiq Cron (#9872) 2020-08-19 14:53:03 -04:00
Mac Siri
5eda086e78
Use ApplicationController for liquid render (#9867) 2020-08-19 13:55:39 -04:00
Ben Halpern
83ab44c75b
Allow staff_user_id to be modified (#9869) 2020-08-19 13:33:17 -04:00
rhymes
7e3c4413e7
Rubocop: Fix ListingCategory has_many relation to Listing (#9853)
* Rubocop: Fix ListingCategory has_many relation to Listing

* Trigger Travis correctly
2020-08-19 19:23:49 +02:00
Vaidehi Joshi
1531c182cc
Move .env_sample out of /config directory (#9868)
The `.env` file shouldn't live in the `/config` directory when it is created, but
currently, the `.env_sample` file lives within `/config`. This can be confusing and
cause ENV var issues if someone duplicates `.env_sample` and renames it to `.env`,
because none of their ENV variables will get picked up, since their `.env` file will
mistakenly end up in `/config`.

This change moves `.env_sample` out of `/config`, and updates the documentation/relevant
.yml files accordingly.
2020-08-19 18:18:30 +02:00
Ben Halpern
f452086280
[deploy] Move community_copyright_start_year to SiteConfig (#9863)
* Move community_copyright_start_year to SiteConfig

* Properly translate year to string

* Change year logic

* Add env default to copyright year

* Fix logic

* Fix codeclimage issue

* Add view element

* Add constants in properly and use dynamic date
2020-08-19 10:19:11 -04:00
Ben Halpern
244d632565
Check for heroku url presence before working with it (#9866) 2020-08-19 10:01:15 -04:00
Peter Frank
8ab7636c38
Update suggested tweet copy on manage page (#9865)
Some light adjustments just to the copy on this page.
2020-08-19 09:57:37 -04:00
Molly Struve
960c51fbc0
[deploy] Refactor: Move beloved comment Badge to Sidekiq Cron (#9861) 2020-08-19 09:12:45 -04:00
Mac Siri
d0c64206a3
[deploy] Create optimized_image_tag helper (#9834) 2020-08-19 08:54:16 -04:00
Sarthak Sharma
3649c70872
[deploy] 🐞Bug Fix: Chat doesn't extend to its frame on Firefox iOS [ Fixes #4024 ] (#9801)
* 🐞Bug Fix: Bug_chat_height_issues_in_IOS

* Removing extra margin in sidecar

* 🐞 Fixing the viewport issue

* 🚀 fixing the parent box size problem
2020-08-19 08:15:15 -04:00
Molly Struve
a5553cf296
Warning Fix: Rename Unused application.yml File to Prevent Warnings (#9860) 2020-08-18 16:49:34 -05:00
Jacob Herrington
d3c65fc99d
[deploy] Apply fixes for axe issues in admin interfaces (#9851)
* Apply fixes for axe issues

This commit contains a handful of fixes for possible accessibility
issues flagged by axe.

I'm currently working through the rest of our admin interface and will
break those changes into seperate commits due to the need for cleanup in
some of the more complicated interfaces.

* Fixup: typo in aria-label

* Escape quotes
2020-08-18 15:58:45 -05:00
Molly Struve
b003f45de8
[deploy] Bug Fix:Execute Hypershield Refresh Task (#9858) 2020-08-18 14:35:27 -05:00
Julianna Tetreault
09c3c25bf8
Add Options to "Invalidate" and "Mark as Valid" Vomit Reactions (#9769) [deploy]
* Adds valid status to the feedback_message model and a spec to validate the status

* Adds an unresolve button to resolved vomits in _abuse_reports.html.erb

* Adds functions to update valid status in reaction_controller.js

* Use invalidate in place of unresolve for unconfirming vomit button

* Add option to reopen vomit reactions marked as invalid and invalidate resolved vomits
  - Adds a Reopen button under the invalid tab
  - Adds confirmedStatus JS to reaction_controller.js
  - Adds conditional to _abuse_reports.html.erb
2020-08-18 11:48:23 -06:00
Brunno Souza
5b7db97336
Reduce arguments method buff! at model buffer_update (#9793)
* Reduce arguments method buff! at model buffer_update

* Rename args and remove brackets as suggested

* Remove unnecessary args and improve buffer class

* Change constant name at buffer update and how call them
2020-08-18 19:42:01 +02:00
Lisa Sy
aea5615a8e
Style logged-out authentication modal (#9827)
* WIP Update modal styling

* Update styles of logged out auth modal

Co-authored-by: Ben Halpern <bendhalpern@gmail.com>
2020-08-18 17:38:08 +02:00
rhymes
a86f4c83f2
[deploy] Add relations and foreign keys between HtmlVariant related models (#9846)
* Add inverse has_many relation betwen User and Ahoy::[Event|Visit
]

* Add FKs and proper relations to HtmlVariant models
2020-08-18 11:33:38 -04:00
rhymes
c9e72858b7
Enable pending Style/SingleArgumentDig (#9842) 2020-08-18 10:26:40 -04:00
Sarthak Sharma
048cf874f5
[deploy] 🐞Bug Fix: Room that has been left still shows up in URL [Fixes: #9501] (#9804)
* 🐞Bug Fix: Channel_leave_and_join_redirection

* Update chat.jsx
2020-08-18 09:29:40 -04:00
rhymes
1375bf676e
[deploy] Nullify article_id for HtmlVariantTrials linked to non existing articles (#9845) 2020-08-18 14:51:06 +02:00
rhymes
f5d35c6506
Rubocop: Enable and fix Style/StringConcatenation (#9844) 2020-08-18 14:50:15 +02:00
JUNO_OKYO
475ba98f1f
Populate options from javascript instead of hardcoding (#9796)
* use single quotes instead of double quotes

* Create object

* Populate options from javascript instead of hardcoding

* Update public/offline.html

Co-authored-by: Ben Halpern <bendhalpern@gmail.com>
2020-08-18 14:37:29 +02:00
ludwiczakpawel
877bdba176
Typography fix & Optimization (#9650)
* flare tag line height

* .

* dropdown fix + actions bar fix

* actions bar on mob

* fixing typography and improving font handling

* cleanup

* variables naming

* fonts swapping

* Makes user's default font render as SiteConfig.default_font

* Trigger checks

* Fixes missing user model specs

* Fixes storybook CI error import & logged out user font set with default

* Limits default_font config to serif, sans-serif & open-dyslexic

* Default font description text

Co-authored-by: Fernando Valverde <fdov88@gmail.com>
2020-08-18 08:05:51 -04:00
JUNO_OKYO
320f54f984
Add "required" attribute to the login form (#9792)
* Add required to email field

* Add required to password field
2020-08-18 10:14:11 +02:00
Alex
8f3d7c7d6a
[deploy] Create details liquid tag (#9777)
* Create details liquid tag

- Liquid tag
- View
- Specs
- Documentation

* Add period

* Fix rebase snaffoo

* More cleanup

* Remove duplicate docs

* Add image support
2020-08-17 20:28:00 -04:00
Molly Struve
dec9847589
Revert "Add Logging Statements to Debug Hypershield Refresh Not Working on Heroku (#9838)" (#9839)
This reverts commit acff871235.
2020-08-17 19:22:38 -05:00
Molly Struve
55e7e12e78
[deploy] Refactor:Move Yearly Badge Awarder to Sidekiq Cron (#9836) 2020-08-17 20:19:14 -04:00
jkrsn98
dbdc6ead38
[deploy] API: add created_at datetime to comments (#9829)
* added created_at to comments in api response

* added test to ensure a date is returned for comment

* fix offenses in test

* updated docs to include addition of created_at to comment api response
2020-08-17 20:10:24 -04:00
Fernando Valverde
5342602298
Social Auth generalization refactor (#9837)
* Add gem omniauth-apple

* Integrate omniauth-apple

* Integrate callback

* Add fields

* Add tests, fix bugs and make it all work

* Show only enabled providers for the current user

* Add default profile image for Apple

* Remove localhost patch

* Bring over the changed Apple username if the user changes it

* More specs fixed

* Incorporate feedback from PR

* Fix specs

* Simplify code and fix spec

* Fix Broadcast generators to take into account the new provider

* Fix spec

* Generate a truly unique apple_username

* Fix user specs

* Add omniauth-apple-0.0.2 to vendor cache

* Fix merge conflict and spec

* Update VCR fastly sloan cassette

* Revert "Generate a truly unique apple_username"

This reverts commit 2462875575b0bbd6b3c1d56b25afcd3189671608.

* Fix user specs

* Fix specs

* Fix specs

* Hide Connect Apple button behind a feature flag

* Revert "Hide Connect Apple button behind a feature flag"

This reverts commit 105bde0373389a4eb9b6e948f60734c7e0e99cba.

* Fix line lengths

* Fix spec

* ES tag

* CSRF bypass for Apple callback

* custom user_nickname in Apple provider with small tweaks + omniauth-apple bump

* Fixes username specs

* Makes Apple users default image Users::ProfileImageGenerator

* Fallback to mascot_image_url in test environment to avoid breaking Travis

* Fixes Apple CSRF error + makes default nickname more readable

* Trigger Travis

* Removes CSRF Apple fix from Omniauth callbacks

* Removes Envfile

Co-authored-by: rhymes <rhymesete@gmail.com>
Co-authored-by: rhymes <rhymes@hey.com>
2020-08-17 20:09:44 -04:00
Joe Doss
c408bd859d
Comments out the USER directive due to issues with podman-compose. (#9835)
This post on https://forem.dev/avalerionv/difficulty-installing-forem-on-ubuntu-18-04-tls-4eh6

talks about issues running Forem on Linux. Digging into the issue it seems that
podman-compose does not pass the --userns=keep-id flag correctly to podman so
files and directories mounted as root and not as the user. This causes permission
denied errors.
2020-08-17 19:41:07 -04:00
Molly Struve
acff871235
[deploy] Add Logging Statements to Debug Hypershield Refresh Not Working on Heroku (#9838) 2020-08-17 18:39:19 -05:00
Molly Struve
702cece697
Flaky Spec Fix:Ensure We Find Articles With Tags and Dont Cache Count for Class Method (#9833) 2020-08-17 18:38:26 -05:00
dependabot-preview[bot]
10d4053210
Bump babel-jest from 26.2.2 to 26.3.0 (#9814) 2020-08-17 17:15:09 -04:00
Molly Struve
0646c10bf8
[deploy] Documenation: Update API Article Update Rate Limit Value to 30 (#9832) 2020-08-17 15:17:15 -05:00
dependabot-preview[bot]
ed1af664b5
Bump ibm-openapi-validator from 0.28.1 to 0.29.0 (#9817) 2020-08-17 15:22:21 -04:00