Commit graph

3799 commits

Author SHA1 Message Date
Mac Siri
d5ba407629
Add AlgoliaSearchable to Article (#20892)
* Add AlgoliaSearchable to Article

* Remove comments

* Fix spec
2024-04-26 12:59:13 +00:00
Mac Siri
f64863b729
Fix flaky ahoy spec (#20885)
* Try create account flaky spec

* Revert "Try create account flaky spec"

This reverts commit ad2eb73e04c5b951350c1868e338b8d801fa0d54.

* Try with basic sleep

* Refactor
2024-04-25 16:18:28 -04:00
Mac Siri
1895237c24
Add AlgoliaSearchable to Podcast (#20890)
* Create AlgoliaSearchable::SearchablePodcastEpisode

* Refactor

* Remove pre-mature methods
2024-04-24 15:14:10 +00:00
Mac Siri
755939733d
Add AlgoliaSearchable to Tag (#20888)
* Add AlgoliaSearch::SearchableTag

* Refactor

* Update app/models/concerns/algolia_searchable/searchable_tag.rb
2024-04-24 14:41:58 +00:00
Philip How
3ceb9a178a
Allow some badges to be awarded multiple times (#20876)
* Add migration, update badgeachievements model and admin view to set flag on badges

* Show multiple badges on profile

* update factory

* badge model validation

* safe navigation to badge?

* add null: false to migratrion
2024-04-23 16:33:43 -04:00
Mac Siri
c44a2dcdb0
Add AlgoliaSearchable for Organization (#20883)
* Add algolia for org

* Add test

* Remove redundant path
2024-04-23 19:35:53 +00:00
Ben Halpern
f4c48fc83b
Add new article billboard locations (#20878)
* Initial work

* Add new billboard locations

* Clean up formatting
2024-04-22 13:58:39 -04:00
Mac Siri
d587ba962d
Add AlgoliaSearchable for User (#20869)
* Add AlgoliaSearchable::SearchableUser

* Update spec

* Refactor

* Refactor

* Add more test

* Refactor

* Update seeder to clear Algolia index if it exist

* All Algolia directly in update_score

* Fix broken spec

* Remove new queue

* Account for more user statuses

* Remove unncessary test for now
2024-04-19 14:03:04 +00:00
Mac Siri
74be076907
Add Algoliasearch-rails gem (#20866)
* Add Algoliasearch-rails gem

* Remove comment

* Add specs

* Add cache gem
2024-04-16 13:45:54 +00:00
Ben Halpern
cbae624b5e
Add billboards to digest emails (#20862)
* Initial bb work

* Add billboards to digest

* Clean up tests and formatting

* Clean up tests and formatting
2024-04-15 12:01:00 -04:00
Ben Halpern
9b15329110
Adjust digest rate if recent clicks tracked (#20838)
* Adjust digest rate if recent clicks tracked

* Fix issues

* Fix issues

* Fix issues

* Fiddle with tests

* Fix syntax

* Fiddle with tests

* Fiddle with tests

* Fiddle with tests

* Fiddle with tests

* Fiddle with tests

* Fiddle with tests

* Fiddle with tests

* Remove .env.test symlink (#20839)

* Update the mdx vscode extension (#20840)

* Update @cypress/code-coverage to version 3.12.30 (#20803)

Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
Co-authored-by: Mac Siri <mac@forem.com>

* Update ruby VSCode extensions for debugging (#20816)

The 'rebornix.Ruby' extension is deprecated. I replaced with the
'Shopify.ruby-lsp' extension since VSCode's Ruby docs pointed
users to ruby-lsp, see https://code.visualstudio.com/docs/languages/ruby.

* Update esbuild to version 0.19.12 (#20841)

Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>

* Update eslint to version 8.57.0 (#20853)

Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>

* fix: remove listings option from views/dashboards/_actions_mobile.html.erb (#20849)

Co-authored-by: Mac Siri <mac@forem.com>

* Update eslint-import-resolver-webpack to version 0.13.8 (#20854)

Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>

* add timestamp to users roles table (#20844)

* Update eslint-plugin-import to version 2.29.1 (#20855)

Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>

* Adjust tests to account for clicks

* Adjust tests to account for clicks

---------

Co-authored-by: Mac Siri <mac@forem.com>
Co-authored-by: Meredith <meredith.edwards1771@gmail.com>
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
Co-authored-by: Gabriel Quaresma <j.quaresmasantos_98@hotmail.com>
Co-authored-by: Philip How <philip.j.how@gmail.com>
2024-04-10 10:39:15 -04:00
Mac Siri
03477f298c
Remove .env.test symlink (#20839) 2024-04-05 11:22:12 -04:00
Mac Siri
d84b0a9f66
[CI] Resolves compiled-assets caching issue (#20836) 2024-04-03 15:01:24 -04:00
Philip How
0d873a4554
Show "Resend Confirmation email" option on users profile when email not confirmed (#20831)
* Show reconfirmation option on users profile

* spec
2024-04-03 09:53:53 -04:00
Mac Siri
8c71491d6f
Fix ahoy's tracking spec [skip ci] (#20825) 2024-04-02 13:09:21 -04:00
Ben Halpern
b6fa936e36
Customize ahoy email to track clicks async without redirect (#20809)
* Initial controller creation

* Ahoy custom clicks initial WIP

* Add test for success and failure

* Adjust some tests

* Adjust test

* Adjust tests and some code

* Update app/views/mailers/digest_mailer/digest_email.html.erb

* Remove s/t/u from safe params

* Add simple test

* Update app/controllers/ahoy/custom_email_clicks_controller.rb

Co-authored-by: Mac Siri <mac@forem.com>

* Change to just email clicks

* Email clicks controller test

---------

Co-authored-by: Mac Siri <mac@forem.com>
2024-04-01 15:05:04 -04:00
Anna Buianova
93c2babb89
Specs for adding tag mods (#20815) 2024-03-29 14:05:28 -04:00
Mac Siri
40a834e110
Fix flaky Ahoy::Event spec (#20811) 2024-03-28 14:23:51 -04:00
Anna Buianova
51316c747f
Comments count according to display rules in feed (#20753)
* Move calculating comments score from worker to a service

* Display displayed comments count in feed

* Recalculating displayed comments counts on article show (if needed)

* Rubocop fixes

* Fixed lambda
2024-03-28 12:12:05 +00:00
Philip How
f6161780d9
Add test to mark profile as spam (#20800)
* add test to mark profile as spam

* rubocop

* move test
2024-03-27 17:30:32 +00:00
Anna Buianova
ed1b4045d3
Auto confirm flag reactions when spam role is assigned (#20797)
* Auto confirm flag reactions when spam role is assigned

* Renamed method according to its point

---------

Co-authored-by: Mac Siri <mac@forem.com>
2024-03-27 13:03:41 +00:00
Anna Buianova
7d5650c3f1
Admin access to spam comments by url (#20775)
* Admin access to spam comments by url

* Fixed spec

* Fixed view spec
2024-03-22 08:40:36 -04:00
Anna Buianova
1008f0af7d
Automatically resolve spam reports when the offending user is marked as spam (#20781)
* Start resolving spam reports automatically after assigning spam role

* Specs for resolving spam reports + async resolving
2024-03-21 17:31:43 +00:00
Ben Halpern
3b62ff1945
Finish Digest subject test and start count test (#20773)
* Finish Digest subject test and start count test

* Proper user

* Style tweak
2024-03-19 16:10:41 -04:00
Mac Siri
092ee4a425
Implement PageViewRollup (#20670)
* Refactor

* Create PageViewRollup WIP

* Create PageViewRollupWorker and specs

* Add spec WIP

* Write spec

* Refactor

* Add spec

* Prevent retry

* Update baseline date

* Improve specs

* Update ATTRIBUTES_

* Update spec again
2024-03-18 20:33:12 +00:00
Ben Halpern
a30b86a025
Allow billboards to target specific pages with "fixed bottom" placement (#20748)
* Add page fixed bottom billboard

* Add page fixed bottom billboard

* Fix schema
2024-03-15 14:32:30 -04:00
Anna Buianova
53f311b059
Add tag moderators by username w/o autocomplete (#20767) 2024-03-15 14:15:51 -04:00
Philip How
57c0078bd6
Allow admins to change reputation modifier (#20766)
* Allow admins to change reputation modifier

* locale + rubocop
2024-03-15 10:46:19 -04:00
Anna Buianova
f572275c9d
Admin access for spammers profiles and articles (#20721)
* Allow admins to visit spammers profiles and articles pages

* Added spam label to user profile and articles

* Unset cache control headers when providing admin access to spam content

* Removed unused comment
2024-03-12 13:25:59 -04:00
Ben Halpern
0d4f7c7e19
Add new simple a/b test for Digest subject and adjust config and design details (#20754)
* Adjust Digest Email design and configuration

* Adjust some tests

* Update tests

* More adjustments to markup and tests

* More adjustments to markup and tests

* Digest email feature flag

* Test title variants
2024-03-11 13:02:19 -04:00
Kim Emmanuel
04fb62a6f5
ignore code blocks when checking markdown for XSS (#20641)
Code blocks are rendered as raw strings and therefore don´t need to be
checked for XSS. Checking them for XSS disallow users to write articles about
XSS in markdown, for example.

Co-authored-by: Mac Siri <mac@forem.com>
2024-03-07 21:03:39 +00:00
Mac Siri
6dc49e8d0d
[CI] Simplify setup steps (#20742) 2024-03-07 12:55:30 -05:00
Ben Halpern
fad28a1707
Allow feed billboards to be dismissable if dismissal_sku is present (#20737) 2024-03-06 15:16:23 -05:00
Ben Halpern
83878e9c10
Add classes to content wrapper for articles and pages (#20731)
* Add classes to content wrapper for articles and pages

* Add class name check

* Fix org check
2024-03-06 12:44:47 -05:00
Mac Siri
a4eea0da41
[CI] Extend Cuprite timeout (#20734) 2024-03-06 10:54:49 -05:00
Philip How
751e9d70d2
Show ⚠️ icon on /admin when an article is not indexed on search engines (#20713)
* Add in icon when an article is not indexed on admin

* tests

* rubocop

* rubocop
2024-03-05 21:34:20 +00:00
Ben Halpern
f2968baadb
Add optional client-side dismissal SKU for closable billboards (#20716)
* Add optional client-side dismissal SKU for closable billboards

* Safe nav
2024-03-01 16:13:19 -05:00
Anna Buianova
288c9ed31f
Fix articles counts based on display rules (#20669)
* Comment counts for signed in users

* Adjust comments count for articles

* Fixed counts for signed out users, added specs for Comments::Count

* Fixed counts for signed out and added specs for Comments::Count

* Removed debug info from the view

* Removed separate count for signed out users

* Remove irrelevant specs

* Remove unused scope
2024-03-01 07:54:15 -05:00
Mac Siri
feabafcc33
Disable flaky specs (#20704) 2024-02-29 16:17:56 -05:00
Ben Halpern
083732e2f3
Optimize and simplify onboarding recommendations (#20682)
* Improve performance of follow recs

* Finish and simplify

* Update tests

* Update tests

* Update tests

* Change onboardings_controller

* Adjust tests

* Change fallback to use score

* Adjust join
2024-02-29 15:57:52 -05:00
Anna Buianova
f8418a6415
Exclude articles from spammers and suspended users from /mod (#20692) 2024-02-28 17:36:56 +00:00
Ben Halpern
78f9bec3e7
Allow admin to declare whether to include the badge description in message (#20684)
* Allow admin to declare whether to include the badge description in badge achievement message

* Update spec/services/badges/award_spec.rb

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Add proper acceptance to tests

* Tweak tests

* Switch to kwargs

* Clean up test acceptance

* Change interface

* Update spec/requests/admin/badge_achievements_spec.rb

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update app/services/badges/award.rb

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Adjust interface

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2024-02-28 11:02:58 -05:00
Daniel M Brasil
ae07192ecc
improve mention model test coverage (#20652) 2024-02-22 17:29:10 +00:00
Ben Halpern
f88784cc35
Add configuration for admins to specify compliant email strategies (#20663)
* Add configuration for admins to specify compliant email strategies

* Add keys for test
2024-02-21 08:27:26 -08:00
Daniel M Brasil
406e3fec4d
Rremove de-indexing From Accounts With No Comments (#20660)
* remove de-indexing from accounts that have no comments

* add specs for Article#skip_indexing?
2024-02-21 10:54:02 +00:00
Ben Halpern
561bdb278c
Change value of signup in success score (#20647) 2024-02-18 10:30:59 -08:00
Anna Buianova
d0f3fb6fff
Optimize and test comments cache after score change (#20640)
* Add specs for caching article comments, use cache_key_with_version

* Optimize cache busting for spammer comments, reorganized related specs
2024-02-16 14:53:11 +00:00
Ben Halpern
8eb41eef8e
Record billboard signup conversions (#20629)
* Record billboard signup conversions

* Update app/models/billboard_event.rb

* Modify click tracking
2024-02-14 14:18:57 -05:00
Ben Halpern
205aee8c78
Add billboard for bottom of page with allowance to delay until after reading is finished. (#20616)
* Add delayed behavior

* Add special behavior to billboards

* Fix order for test

* Test clicking outside element when close event is present

* Update app/javascript/packs/billboardAfterRenderActions.js
2024-02-13 11:56:32 -05:00
Anna Buianova
fb09a75352
Update comment updated_at when changing score (#20622)
* Change comment updated_at when updating comment score

* Rubocop fixes
2024-02-13 13:17:24 +00:00