maverick/docbrown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix flaky ahoy spec (#20885)

Browse source 
* Try create account flaky spec

* Revert "Try create account flaky spec"

This reverts commit ad2eb73e04c5b951350c1868e338b8d801fa0d54.

* Try with basic sleep

* Refactor
This commit is contained in:
Mac Siri 2024-04-25 16:18:28 -04:00 • committed by GitHub
parent 39c4731b2d
commit f64863b729
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
spec/system/ahoy/tracking_create_account_spec.rb
View file

@ -1,6 +1,11 @@
require "rails_helper"
RSpec.describe "Tracking 'Clicked on Create Account'", :js do
def wait_for_async_events_listener
# temp fix for flaky specs
sleep 5
end
context "when on the homepage" do
before do
user = create(:user)
@ -21,8 +26,8 @@ RSpec.describe "Tracking 'Clicked on Create Account'", :js do
end
it "tracks a click with the correct source", :aggregate_failures do
skip "This is a very flaky test"
expect(Ahoy::Event.count).to eq(0)
wait_for_async_events_listener
find('[data-tracking-id="ca_top_nav"]').click
expect(Ahoy::Event.last.name).to eq("Clicked on Create Account")
@ -34,6 +39,7 @@ RSpec.describe "Tracking 'Clicked on Create Account'", :js do
it "adds an ahoy event", :aggregate_failures do
article = create(:article, user: create(:user))
visit article.path
wait_for_async_events_listener
expect(Ahoy::Event.count).to eq(0)
find(".follow-action-button").click
find(".js-global-signup-modal__create-account").click