VISHAL DEEPAK
c88f8dcdaa
In dashboard show api eager load collection with articles ( #14677 )
...
* In dashboard show api eager load collection with articles
* Dashboard Article Row view now loads collection to suppress bullet warning of eager loading
2021-09-09 11:11:03 +01:00
Daniel Uber
2a75ec8ecc
When calling Faker::Markdown, avoid "sandwich" method ( #14685 )
...
* When calling Faker::Markdown, avoid "sandwich" method
Since random can also be selected by random (without the exclude
list), avoid calling sandwich occassionally from random's call to
random.
This avoids generating body_markdown exceeding 12 newlines (which is
validated in Listing and prevents save, breaking the seeds process).
* just take 10 lines, don't be clever
Co-authored-by: Jamie Gaskins <jamie@forem.com>
Co-authored-by: Jamie Gaskins <jamie@forem.com>
2021-09-08 17:54:53 -05:00
dependabot[bot]
61eed20876
Bump @testing-library/dom from 7.31.2 to 8.2.0 ( #14623 )
...
Bumps [@testing-library/dom](https://github.com/testing-library/dom-testing-library ) from 7.31.2 to 8.2.0.
- [Release notes](https://github.com/testing-library/dom-testing-library/releases )
- [Changelog](https://github.com/testing-library/dom-testing-library/blob/main/CHANGELOG.md )
- [Commits](https://github.com/testing-library/dom-testing-library/compare/v7.31.2...v8.2.0 )
---
updated-dependencies:
- dependency-name: "@testing-library/dom"
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-09-08 14:02:45 -04:00
Daniel Uber
1253d90114
Check for the current version of foreman when deciding to install ( #14682 )
...
* Check for the current version of foreman when deciding to install
0.87.1 was current when this was added, but `gem install foreman` now
installs 0.87.2, so this check always fails (I do not have the older
version present).
I'm suspecting we either don't want to version pin this test (assume
whatever version of foreman installed is fine) or we need to use
something like the Gemfile to have dependabot keep this version info
in sync with the upstream.
All I do here is update the current release version to test against.
* Remove foreman version constraint
If any version of (very stable) foreman is installed, assume it's
recent enough to run the (also very stable) Procfile
Only install foreman gem if it's not installed. Updates are on the user.
2021-09-08 09:31:23 -05:00
Fernando Valverde
a3da4f9bc4
Remove outdated notice ( #14679 )
2021-09-08 14:46:34 +02:00
dependabot[bot]
29949046d6
Bump babel-jest from 26.6.3 to 27.1.0 ( #14670 )
...
Bumps [babel-jest](https://github.com/facebook/jest/tree/HEAD/packages/babel-jest ) from 26.6.3 to 27.1.0.
- [Release notes](https://github.com/facebook/jest/releases )
- [Changelog](https://github.com/facebook/jest/blob/master/CHANGELOG.md )
- [Commits](https://github.com/facebook/jest/commits/v27.1.0/packages/babel-jest )
---
updated-dependencies:
- dependency-name: babel-jest
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-09-08 10:58:33 +07:00
dependabot[bot]
af8d239478
Bump @storybook/addon-storysource from 6.3.7 to 6.3.8 ( #14675 )
2021-09-07 18:45:59 -04:00
dependabot[bot]
eae3ac1cb1
Bump honeycomb-beeline from 2.6.0 to 2.7.0 ( #14680 )
...
Bumps [honeycomb-beeline](https://github.com/honeycombio/beeline-ruby ) from 2.6.0 to 2.7.0.
- [Release notes](https://github.com/honeycombio/beeline-ruby/releases )
- [Changelog](https://github.com/honeycombio/beeline-ruby/blob/main/CHANGELOG.md )
- [Commits](https://github.com/honeycombio/beeline-ruby/compare/v2.6.0...v2.7.0 )
---
updated-dependencies:
- dependency-name: honeycomb-beeline
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-09-07 17:22:04 -04:00
dependabot[bot]
40543ea126
Bump husky from 7.0.1 to 7.0.2 ( #14676 )
2021-09-07 15:42:15 -04:00
dependabot[bot]
330232e97d
Bump @babel/core from 7.15.0 to 7.15.5 ( #14671 )
2021-09-07 15:41:54 -04:00
Keshav Biswa
42c9a10f57
Accessible names for follow buttons ( #14389 )
...
* added follow hidden tags for accessibility
* fixed failing tests
* replaced hidden span with screen-reader-only with aria-label
* add aria-label dynamically to follow buttons
* fixed followButtons
* fixed cypress tests and updated addAriaLabelToButton helper
* Fixed failing tests
* fixed failing tests
* Update cypress/integration/seededFlows/notificationsFlows/followUserFromNotifications.spec.js
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
2021-09-07 16:09:06 +01:00
Jamie Gaskins
5fc3f52299
Allow caching feature flags for a given duration ( #14668 )
...
This duration is specified in the `CACHE_FEATURE_FLAGS_SECONDS`
environment variable. It can't be updated without restarting the
application.
2021-09-07 10:19:29 -04:00
dependabot[bot]
575bce33e7
Bump pusher from 2.0.1 to 2.0.2 ( #14667 )
...
Bumps [pusher](https://github.com/pusher/pusher-http-ruby ) from 2.0.1 to 2.0.2.
- [Release notes](https://github.com/pusher/pusher-http-ruby/releases )
- [Changelog](https://github.com/pusher/pusher-http-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/pusher/pusher-http-ruby/compare/2.0.1...2.0.2 )
---
updated-dependencies:
- dependency-name: pusher
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-09-07 09:48:07 -04:00
dependabot[bot]
847d7c3f17
Bump oj from 3.13.3 to 3.13.4 ( #14673 )
...
Bumps [oj](https://github.com/ohler55/oj ) from 3.13.3 to 3.13.4.
- [Release notes](https://github.com/ohler55/oj/releases )
- [Changelog](https://github.com/ohler55/oj/blob/develop/CHANGELOG.md )
- [Commits](https://github.com/ohler55/oj/compare/v3.13.3...v3.13.4 )
---
updated-dependencies:
- dependency-name: oj
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-09-07 09:44:28 -04:00
dependabot[bot]
628202646b
Bump eslint-plugin-react from 7.24.0 to 7.25.1 ( #14627 )
...
Bumps [eslint-plugin-react](https://github.com/yannickcr/eslint-plugin-react ) from 7.24.0 to 7.25.1.
- [Release notes](https://github.com/yannickcr/eslint-plugin-react/releases )
- [Changelog](https://github.com/yannickcr/eslint-plugin-react/blob/master/CHANGELOG.md )
- [Commits](https://github.com/yannickcr/eslint-plugin-react/compare/v7.24.0...v7.25.1 )
---
updated-dependencies:
- dependency-name: eslint-plugin-react
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-09-07 09:27:14 +01:00
Daniel Uber
c6cb4c9573
Replace splatted constant with its value ( #14666 )
...
Fixes #14664
2021-09-03 11:49:19 -05:00
Arit Amana
877cb5c322
Save Confirmation - Admin (Part 1 of 2) ( #14418 )
2021-09-02 11:49:05 -04:00
dependabot[bot]
eec0793c06
Bump oj from 3.13.2 to 3.13.3 ( #14640 )
...
Bumps [oj](https://github.com/ohler55/oj ) from 3.13.2 to 3.13.3.
- [Release notes](https://github.com/ohler55/oj/releases )
- [Changelog](https://github.com/ohler55/oj/blob/develop/CHANGELOG.md )
- [Commits](https://github.com/ohler55/oj/compare/v3.13.2...v3.13.3 )
---
updated-dependencies:
- dependency-name: oj
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-09-02 10:38:28 -04:00
dependabot[bot]
e586d9f313
Bump view_component from 2.38.0 to 2.39.0 ( #14654 )
...
Bumps [view_component](https://github.com/github/view_component ) from 2.38.0 to 2.39.0.
- [Release notes](https://github.com/github/view_component/releases )
- [Changelog](https://github.com/github/view_component/blob/main/docs/CHANGELOG.md )
- [Commits](https://github.com/github/view_component/compare/v2.38.0...v2.39.0 )
---
updated-dependencies:
- dependency-name: view_component
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-09-01 13:03:11 -06:00
dependabot[bot]
6a7ae9576e
Bump bundler-audit from 0.8.0 to 0.9.0.1 ( #14653 )
...
Bumps [bundler-audit](https://github.com/postmodern/bundler-audit ) from 0.8.0 to 0.9.0.1.
- [Release notes](https://github.com/postmodern/bundler-audit/releases )
- [Changelog](https://github.com/rubysec/bundler-audit/blob/master/ChangeLog.md )
- [Commits](https://github.com/postmodern/bundler-audit/compare/v0.8.0...v0.9.0.1 )
---
updated-dependencies:
- dependency-name: bundler-audit
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-09-01 13:02:46 -06:00
Fernando Valverde
49efd6e41d
Removes target=_blank and small banner redirect tweak ( #14548 )
2021-09-01 08:27:24 -06:00
dependabot[bot]
9c1cf476ae
Bump tar from 6.1.3 to 6.1.11 ( #14638 )
...
Bumps [tar](https://github.com/npm/node-tar ) from 6.1.3 to 6.1.11.
- [Release notes](https://github.com/npm/node-tar/releases )
- [Changelog](https://github.com/npm/node-tar/blob/main/CHANGELOG.md )
- [Commits](https://github.com/npm/node-tar/compare/v6.1.3...v6.1.11 )
---
updated-dependencies:
- dependency-name: tar
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-09-01 11:04:37 +01:00
dependabot[bot]
148276c93d
Bump svgo from 2.4.0 to 2.5.0 ( #14636 )
...
Bumps [svgo](https://github.com/svg/svgo ) from 2.4.0 to 2.5.0.
- [Release notes](https://github.com/svg/svgo/releases )
- [Changelog](https://github.com/svg/svgo/blob/master/CHANGELOG-old.md )
- [Commits](https://github.com/svg/svgo/compare/v2.4.0...v2.5.0 )
---
updated-dependencies:
- dependency-name: svgo
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-09-01 11:03:19 +01:00
Suzanne Aitchison
dcecc8bf00
Log prop-types warnings to console in development ( #14635 )
...
* enable debug for warnings in dev env
* remove preact/devtools call no longer needed
* fix majority of proptype errors on home page
* sweep up proptype errors from listings page
* fix article form error
2021-09-01 09:27:58 +01:00
Fernando Valverde
e45b6c5ab2
Adds validations to avoid creating unnecessary PNs ( #14621 )
...
* Adds validations to avoid creating unnecessary PNs
* Fix conditional + add tests
* Trigger CI
* Trigger CI
* Add missing rpush mock in spec
* Mock before testing d'oh
* Extend ability to mock rpush in helpers
* Remove unnecessary user3 from spec
2021-08-31 15:00:30 -06:00
dependabot[bot]
75d192f6a5
Bump eslint-plugin-import from 2.24.1 to 2.24.2 ( #14631 )
...
Bumps [eslint-plugin-import](https://github.com/import-js/eslint-plugin-import ) from 2.24.1 to 2.24.2.
- [Release notes](https://github.com/import-js/eslint-plugin-import/releases )
- [Changelog](https://github.com/import-js/eslint-plugin-import/blob/main/CHANGELOG.md )
- [Commits](https://github.com/import-js/eslint-plugin-import/compare/v2.24.1...v2.24.2 )
---
updated-dependencies:
- dependency-name: eslint-plugin-import
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-08-31 14:01:47 -06:00
dependabot[bot]
114cead780
Bump core-js from 3.16.2 to 3.16.4 ( #14624 )
...
Bumps [core-js](https://github.com/zloirock/core-js ) from 3.16.2 to 3.16.4.
- [Release notes](https://github.com/zloirock/core-js/releases )
- [Changelog](https://github.com/zloirock/core-js/blob/master/CHANGELOG.md )
- [Commits](https://github.com/zloirock/core-js/compare/v3.16.2...v3.16.4 )
---
updated-dependencies:
- dependency-name: core-js
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-08-31 13:59:38 -06:00
Michael Kohl
e59fccabb3
Only tech admins can manage page feature flags ( #14618 )
2021-08-31 15:35:42 -04:00
Jamie Gaskins
94841d5934
Remove Database.table_available? ( #14639 )
...
ActiveRecord already implements this at the model level and also makes
use of the ActiveRecord schema cache. `Database.table_available?` did
not use this query cache and ended up sending *all* of those queries to
Postgres every single time.
2021-08-31 13:53:34 -04:00
dependabot[bot]
f92b91d18f
Bump autoprefixer from 10.3.2 to 10.3.3 ( #14632 )
...
Bumps [autoprefixer](https://github.com/postcss/autoprefixer ) from 10.3.2 to 10.3.3.
- [Release notes](https://github.com/postcss/autoprefixer/releases )
- [Changelog](https://github.com/postcss/autoprefixer/blob/main/CHANGELOG.md )
- [Commits](https://github.com/postcss/autoprefixer/compare/10.3.2...10.3.3 )
---
updated-dependencies:
- dependency-name: autoprefixer
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-08-31 16:58:48 +01:00
Michael Kohl
4b6a9a1567
Update README.md ( #14633 )
2021-08-31 09:29:52 -05:00
dependabot[bot]
7792246fad
Bump cypress from 8.3.0 to 8.3.1 ( #14622 )
...
Bumps [cypress](https://github.com/cypress-io/cypress ) from 8.3.0 to 8.3.1.
- [Release notes](https://github.com/cypress-io/cypress/releases )
- [Changelog](https://github.com/cypress-io/cypress/blob/develop/.releaserc.base.js )
- [Commits](https://github.com/cypress-io/cypress/compare/v8.3.0...v8.3.1 )
---
updated-dependencies:
- dependency-name: cypress
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-08-31 08:21:42 +01:00
Suzanne Aitchison
89632249bd
make sure input can scroll into view on mobile ( #14619 )
2021-08-31 08:11:00 +01:00
Manoj Naidu
909f5ae263
Fixed button styling ( #14617 )
2021-08-31 08:09:40 +01:00
Michael Kohl
baa94a0abd
Various cleanups ( #14616 )
...
* Remove unused constant
* Remove unused column from OrganizationMembership
* Remove outdated comment
* Remove references to no longer existing roles
* Remove legacy service worker code
* Remove duration_in_seconds_column from podcast_episodes
* Remove app_bundle from devices
2021-08-31 09:17:24 +07:00
dependabot[bot]
607a5d7c0c
Bump test-prof from 1.0.6 to 1.0.7 ( #14626 )
...
Bumps [test-prof](https://github.com/test-prof/test-prof ) from 1.0.6 to 1.0.7.
- [Release notes](https://github.com/test-prof/test-prof/releases )
- [Changelog](https://github.com/test-prof/test-prof/blob/master/CHANGELOG.md )
- [Commits](https://github.com/test-prof/test-prof/compare/v1.0.6...v1.0.7 )
---
updated-dependencies:
- dependency-name: test-prof
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-08-30 16:44:30 -04:00
dependabot[bot]
5ebb81e16b
Bump nokogiri from 1.12.3 to 1.12.4 ( #14628 )
...
Bumps [nokogiri](https://github.com/sparklemotion/nokogiri ) from 1.12.3 to 1.12.4.
- [Release notes](https://github.com/sparklemotion/nokogiri/releases )
- [Changelog](https://github.com/sparklemotion/nokogiri/blob/main/CHANGELOG.md )
- [Commits](https://github.com/sparklemotion/nokogiri/compare/v1.12.3...v1.12.4 )
---
updated-dependencies:
- dependency-name: nokogiri
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-08-30 14:06:42 -06:00
Michael Kohl
13bf3c5ef0
Routine Rubocop autofixes ( #14604 )
2021-08-30 11:44:57 -04:00
Suzanne Aitchison
3b67810b9d
Add support for JSX copy paste in Storybook ( #14591 )
...
* add support for JSX and HTML copy paste
* remove html addon, refactor dropdown story
* undo html addon settings
2021-08-30 09:36:01 +01:00
Michael Kohl
a885483059
Introduce Settings::Base ( #14138 )
...
* Introduce Settings::Base
* Temporarily re-add gem
* Update Settings::Base to use RequestStore
* Add after_commit hook
* Restructure code
* Finish specs, rename field -> setting
* Update comment
* Undo unrelated change
* Remove redundant get_default
* Fix Doorkeeper issue
* Update docs/backend/configuration.md
Co-authored-by: Josh Puetz <josh@dev.to>
* Clarify comment and documentation
* Update vendored gems
* Fix nil-handling bug in Settings::Base
* Remove accidentaly changes from Gemfile.lock
* Update vendored gems
Co-authored-by: Josh Puetz <josh@dev.to>
2021-08-30 10:27:08 +07:00
Daniel Uber
c3bfdc585d
Install foreman for procfile and setup appdomain in gitpod ( #14612 )
...
* Install foreman for procfile and setup appdomain for csrf in gitpod
Foreman was not installed (so bin/startup would fail fast).
Additionally, the APP_DOMAIN can be fetched from the `gp` utility to
get the url for port 3000
Since the .env file is read top down - it's easier to implement
appending the corrected value than to replace it at the beginning, but
I'm completely open to redoing this via a sed command or similar to
change the variable at the top (this would be less confusing for
anyone else dealing with the file).
* Ensure command executes as a series of commands
TODO: if this works move the echo commands into the setup section
* move .env setup commands to init section
2021-08-27 18:21:07 -05:00
dependabot[bot]
3f52089695
Bump counter_culture from 2.8.0 to 2.9.0 ( #14610 )
...
Bumps [counter_culture](https://github.com/magnusvk/counter_culture ) from 2.8.0 to 2.9.0.
- [Release notes](https://github.com/magnusvk/counter_culture/releases )
- [Changelog](https://github.com/magnusvk/counter_culture/blob/master/CHANGELOG.md )
- [Commits](https://github.com/magnusvk/counter_culture/compare/v2.8.0...v2.9.0 )
---
updated-dependencies:
- dependency-name: counter_culture
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-08-27 15:22:44 -04:00
dependabot[bot]
fd3ab09199
Bump bootsnap from 1.8.0 to 1.8.1 ( #14611 )
...
Bumps [bootsnap](https://github.com/Shopify/bootsnap ) from 1.8.0 to 1.8.1.
- [Release notes](https://github.com/Shopify/bootsnap/releases )
- [Changelog](https://github.com/Shopify/bootsnap/blob/master/CHANGELOG.md )
- [Commits](https://github.com/Shopify/bootsnap/compare/v1.8.0...v1.8.1 )
---
updated-dependencies:
- dependency-name: bootsnap
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-08-27 15:20:54 -04:00
Daniel Uber
bad23b153c
ignore dump.rdb redis backup file ( #14586 )
...
* ignore dump.rdb redis backup file
* Update .gitignore
Co-authored-by: rhymes <github@rhymes.dev>
Co-authored-by: rhymes <github@rhymes.dev>
2021-08-27 12:36:04 -05:00
Suzanne Aitchison
bfb4f00aae
Add copy to HTML feature for storybook ( #14599 )
...
* Add copy to HTML feature for storybook, inc fix for article markup
* remove html stories no longer needed
2021-08-27 16:09:21 +01:00
Suzanne Aitchison
62e2e0b898
Minor accessibility fixes for the podcast area ( #14606 )
...
* remove duplicate header, convert heading to h1
* hide decorative image from sr, convert nav to a nav
* minor fix for items in nav list
* minor fixes to the podcast page
* trigger CI checks
2021-08-27 15:26:52 +01:00
Nick Taylor
cb065a8645
Remove static Storybook folder when doing local Storybook development ( #14608 )
2021-08-27 10:05:51 -04:00
Daniel Uber
e33b15e1e5
Add counts for number of views when showing referrers ( #14600 )
...
* Add counts for number of views when showing referrers
We're sampling unauthenticated page views (every 10th visit is
recorded) and using the "counts_for_number_of_views" attribute to mark
the 10x weight of these sampled events.
The referrers section of the statistics page however was counting the
number of page view rows (without regard to the weight) and it looked
like external referrers (like a google search) were counting 10 times
on the statistics page.
Update the analytics service to show the sum of the weights, rather
than the count of events, on the "Traffic Source Summary" of the
article stats page.
This is loaded from /api/analytics/referrers?article_id=:id on the
front end.
Needs a test that demonstrates this (currently all specs for this
stayed green suggesting the coverage didn't include anything that
represents this situation).
* Avoid calling sum twice by reusing the value alias
the .sum(:column) method in this chain creates an alias 'select
sum(column) as sum_column' which can be used here to avoid
recalculating the sum once for sorting and again for return value.
Sort by the return value's alias.
* Update the test to include weighted page views
Since we want to demonstrate that the count shown for visits matches
the sum of the weighted page views, add weighting to the top url
visits and expect the sum of the weights to be presented.
2021-08-27 08:03:43 -05:00
Nick Taylor
e0ee5e71f4
Some eslint fixes. ( #14605 )
2021-08-27 08:37:09 +01:00
dependabot[bot]
1c2f265bd7
Bump rubocop from 1.19.1 to 1.20.0 ( #14602 )
...
Bumps [rubocop](https://github.com/rubocop/rubocop ) from 1.19.1 to 1.20.0.
- [Release notes](https://github.com/rubocop/rubocop/releases )
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop/compare/v1.19.1...v1.20.0 )
---
updated-dependencies:
- dependency-name: rubocop
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-08-27 10:05:27 +07:00
